mbox series

[v2,0/3] dump: Arch info function pointer addition and cleanup

Message ID 20231109120443.185979-1-frankja@linux.ibm.com
Headers show
Series dump: Arch info function pointer addition and cleanup | expand

Message

Janosch Frank Nov. 9, 2023, 12:04 p.m. UTC 
Small cleanups/fixes to the dump info function pointer assignments as
well as a new function pointer for cleanup of residual state.

This has come up because test managed to dump a s390 PV vm onto a disk
that was too small for the dump. After the dump failed, the vm wasn't
able to resume running since KVM was still in dump mode which blocks
vcpu entry.

The new function pointer allows cleanup of such a situation.

v2:
	- Usage of g_autofree
	- Dropped explicit NULLing of function pointers

Janosch Frank (3):
  target/s390x/dump: Remove unneeded dump info function pointer init
  dump: Add arch cleanup function
  target/s390x/arch_dump: Add arch cleanup function for PV dumps

 dump/dump.c                |  4 ++++
 include/sysemu/dump-arch.h |  1 +
 target/s390x/arch_dump.c   | 21 +++++++++++++++++----
 3 files changed, 22 insertions(+), 4 deletions(-)

Comments

Marc-André Lureau Nov. 10, 2023, 1:35 p.m. UTC | #1 
Hi

On Thu, Nov 9, 2023 at 4:05 PM Janosch Frank <frankja@linux.ibm.com> wrote:
>
> Small cleanups/fixes to the dump info function pointer assignments as
> well as a new function pointer for cleanup of residual state.
>
> This has come up because test managed to dump a s390 PV vm onto a disk
> that was too small for the dump. After the dump failed, the vm wasn't
> able to resume running since KVM was still in dump mode which blocks
> vcpu entry.
>
> The new function pointer allows cleanup of such a situation.
>
> v2:
>         - Usage of g_autofree
>         - Dropped explicit NULLing of function pointers
>
> Janosch Frank (3):
>   target/s390x/dump: Remove unneeded dump info function pointer init
>   dump: Add arch cleanup function
>   target/s390x/arch_dump: Add arch cleanup function for PV dumps
>
>  dump/dump.c                |  4 ++++
>  include/sysemu/dump-arch.h |  1 +
>  target/s390x/arch_dump.c   | 21 +++++++++++++++++----
>  3 files changed, 22 insertions(+), 4 deletions(-)
>

Series:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>