mbox series

[0/2] dump: Fix issues flagged by Coverity

Message ID 20231108053731.112043-1-armbru@redhat.com
Headers show
Series dump: Fix issues flagged by Coverity | expand

Message

Markus Armbruster Nov. 8, 2023, 5:37 a.m. UTC 
Markus Armbruster (2):
  dump: Plug file descriptor leak on non-seekable file
  dump: Fix HMP dump-guest-memory -z without -R

 dump/dump-hmp-cmds.c | 2 +-
 dump/dump.c          | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Stephen Brennan Nov. 8, 2023, 7:36 a.m. UTC | #1 
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster (2):
>   dump: Plug file descriptor leak on non-seekable file
>   dump: Fix HMP dump-guest-memory -z without -R

Hi Markus,

I'm a bit late on the uptake here as these are already queued, but thank
you so much for finding and fixing my issues. Sorry for the extra work.

Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>
Markus Armbruster Nov. 8, 2023, 10:31 a.m. UTC | #2 
Stephen Brennan <stephen.s.brennan@oracle.com> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>> Markus Armbruster (2):
>>   dump: Plug file descriptor leak on non-seekable file
>>   dump: Fix HMP dump-guest-memory -z without -R
>
> Hi Markus,
>
> I'm a bit late on the uptake here as these are already queued, but thank
> you so much for finding and fixing my issues. Sorry for the extra work.

Happens :)

> Reviewed-by: Stephen Brennan <stephen.s.brennan@oracle.com>

Thanks!