| Message ID | 20231018181259.748819-1-nabihestefan@google.com |
|---|---|
| Headers | show |
| Series | Implementation of NPI Mailbox and GMAC Networking Module | expand |
On Wed, 18 Oct 2023 at 19:13, Nabih Estefan <nabihestefan@google.com> wrote: > > From: Nabih Estefan Diaz <nabihestefan@google.com> > > [Changes since v3] > Fixed comments from Hao Wu (wuhaotsh@google.com) > > [Changes since v2] > Fixed bugs related to the RC functionality of the GMAC. Added and > squashed patches related to that. > [Changes since v1] > Fixed some errors in formatting. > Fixed a merge error that I didn't see in v1. > Removed Nuvoton 8xx references since that is a separate patch set. > > [Original Cover] > Creates NPI Mailbox Module with data verification for read and write (internal and external), > wiring to the Nuvoton SoC, and QTests. > > Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors > and registers. Also includes QTests for the different functionalities. > > Hao Wu (5): > hw/misc: Add Nuvoton's PCI Mailbox Module > hw/arm: Add PCI mailbox module to Nuvoton SoC > hw/misc: Add qtest for NPCM7xx PCI Mailbox > hw/net: Add NPCMXXX GMAC device > hw/arm: Add GMAC devices to NPCM7XX SoC > > Nabih Estefan Diaz (6): > tests/qtest: Creating qtest for GMAC Module > include/hw/net: Implemented Classes and Masks for GMAC Descriptors > hw/net: General GMAC Implementation > hw/net: GMAC Rx Implementation > hw/net: GMAC Tx Implementation > tests/qtest: Adding PCS Module test to GMAC Qtest Hi; I'm afraid this is going to miss the 8.2 release, because it is still missing any review from Google or Nuvoton people. PS: your patch 4 commit message seems to have got mangled somehow -- it appears to be multiple commit messages that have got concatenated. Was this intended to be more than one patch ? Also, for patches 1-5 which are by Hao Wu, you should add your Signed-off-by: after theirs, to indicate that their patch has come to QEMU via you. thanks -- PMM
From: Nabih Estefan Diaz <nabihestefan@google.com> [Changes since v3] Fixed comments from Hao Wu (wuhaotsh@google.com) [Changes since v2] Fixed bugs related to the RC functionality of the GMAC. Added and squashed patches related to that. [Changes since v1] Fixed some errors in formatting. Fixed a merge error that I didn't see in v1. Removed Nuvoton 8xx references since that is a separate patch set. [Original Cover] Creates NPI Mailbox Module with data verification for read and write (internal and external), wiring to the Nuvoton SoC, and QTests. Also creates the GMAC Networking Module. Implements read and write functionalities with cooresponding descriptors and registers. Also includes QTests for the different functionalities. Hao Wu (5): hw/misc: Add Nuvoton's PCI Mailbox Module hw/arm: Add PCI mailbox module to Nuvoton SoC hw/misc: Add qtest for NPCM7xx PCI Mailbox hw/net: Add NPCMXXX GMAC device hw/arm: Add GMAC devices to NPCM7XX SoC Nabih Estefan Diaz (6): tests/qtest: Creating qtest for GMAC Module include/hw/net: Implemented Classes and Masks for GMAC Descriptors hw/net: General GMAC Implementation hw/net: GMAC Rx Implementation hw/net: GMAC Tx Implementation tests/qtest: Adding PCS Module test to GMAC Qtest docs/system/arm/nuvoton.rst | 2 + hw/arm/npcm7xx.c | 53 +- hw/misc/meson.build | 1 + hw/misc/npcm7xx_pci_mbox.c | 324 ++++++++++ hw/misc/trace-events | 5 + hw/net/meson.build | 2 +- hw/net/npcm_gmac.c | 943 ++++++++++++++++++++++++++++ hw/net/trace-events | 20 + include/hw/arm/npcm7xx.h | 4 + include/hw/misc/npcm7xx_pci_mbox.h | 81 +++ include/hw/net/npcm_gmac.h | 340 ++++++++++ tests/qtest/meson.build | 8 +- tests/qtest/npcm7xx_pci_mbox-test.c | 238 +++++++ tests/qtest/npcm_gmac-test.c | 341 ++++++++++ 14 files changed, 2353 insertions(+), 9 deletions(-) create mode 100644 hw/misc/npcm7xx_pci_mbox.c create mode 100644 hw/net/npcm_gmac.c create mode 100644 include/hw/misc/npcm7xx_pci_mbox.h create mode 100644 include/hw/net/npcm_gmac.h create mode 100644 tests/qtest/npcm7xx_pci_mbox-test.c create mode 100644 tests/qtest/npcm_gmac-test.c