Message ID | 20231005045041.52649-1-philmd@linaro.org |
---|---|
Headers | show |
Series | qapi: Kill 'qapi/qmp/qerror.h' for good | expand |
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > Since v1: > - Fixed checkpatch warnings (Juan) > - Added R-b tags > - New patch for 'vcpu_dirty_limit' > > Hi, > > This is kind of a selfish series. I'm really tired to grep > and read this comment from 2015 in qapi/qmp/qerror.h: > /* > * These macros will go away, please don't use > * in new code, and do not add new ones! > */ > > Besides, these definitions are still added in recent code > (see for example commit 09f9ec9913 from June 2023). So > let's finish with this 8 years old technical debt. Gee, a late birthday present for me! Thank you! > Overall it took me 3h: 1h to find the correct Coccinelle > doc about Python use and read it again [*], then 1h to > adapt the script for each patch, rest is testing and > writing comments, so the scripts used could be used as > reference later. By the time you're done, it'll likely be 6h or more...
Your patches are sane, the problem is they made me look at the code they patch, much of which is not fine. Let's chat off list to figure out how to best get your patches merged.