mbox series

[0/5] RFC: migration: check required entries and sections are loaded

Message ID 20230926155925.1396309-1-marcandre.lureau@redhat.com
Headers show
Series RFC: migration: check required entries and sections are loaded | expand

Message

Marc-André Lureau Sept. 26, 2023, 3:59 p.m. UTC 
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

To my surprise, QEMU didn't seem to check that required migration entries and
subsections are loaded. I took a naive approach to add such check, by adding
some "visited" marks along the loading path, and checking by the end that all
required entries have been loaded.

Note, I haven't thoroughly tested it yet (it passed make check on x86 targets
with the preliminary "fixes" applied).

Comments welcome!

Marc-André Lureau (5):
  block/fdc: 'phase' is not needed on load
  virtio: make endian_needed() work during loading
  net/slirp: use different IDs for each instance
  RFC: migration: check required subsections are loaded, once
  RFC: migration: check required entries are loaded, once

 hw/block/fdc.c      |  5 +++++
 hw/virtio/virtio.c  |  6 +++++-
 migration/savevm.c  | 43 +++++++++++++++++++++++++++++++++++++++++++
 migration/vmstate.c | 40 ++++++++++++++++++++++++++++++++++++++--
 net/slirp.c         |  3 ++-
 5 files changed, 93 insertions(+), 4 deletions(-)

Comments

Peter Xu Oct. 4, 2023, 4:26 p.m. UTC | #1 
On Tue, Sep 26, 2023 at 07:59:20PM +0400, marcandre.lureau@redhat.com wrote:
> Marc-André Lureau (5):
>   block/fdc: 'phase' is not needed on load
>   virtio: make endian_needed() work during loading
>   net/slirp: use different IDs for each instance

First 3 patches are bug fixes, am I right?

It'll be great if they can be acked (or even picked up earlier?) by
subsystem maintainers if so, and copy stable if justified proper.

Thanks,