From patchwork Thu Aug 31 18:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabiano Rosas X-Patchwork-Id: 1828465 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dezZ8WS2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9kkR54pk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Rc92b1htpz1ygM for ; Fri, 1 Sep 2023 04:40:23 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbmZr-0001cc-MO; Thu, 31 Aug 2023 14:39:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbmZi-0001Q1-5s for qemu-devel@nongnu.org; Thu, 31 Aug 2023 14:39:26 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbmZf-0002EI-Qr for qemu-devel@nongnu.org; Thu, 31 Aug 2023 14:39:25 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A37322184E; Thu, 31 Aug 2023 18:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693507160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4aRw5U2OZALuNTxa7TG2E5cwPWJVuQ46x2iy2ZbnvpI=; b=dezZ8WS2Wv/wujS/erwd6QyU1LE0+7uMVYjI7Pd63t66GAP9DaI0wLGJkVASC4xK7neXxU JKV6wxADv2rTtvmyUlGxGPAO9WCBMc9eAa5sDHj6TNzkxVQONxWGLf/JIcVsh5dX+8tV9/ f+JQug7xjKTI7WHPztd9A6M4cVrcq6Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693507160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4aRw5U2OZALuNTxa7TG2E5cwPWJVuQ46x2iy2ZbnvpI=; b=9kkR54pkhUON53ocFyMfMrnWA6dkmBWDXrQVyL7sGGTs4/s8eaz+0MZXBTanUCftlI+Igc 0llwx/9whTJct6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 592FF13583; Thu, 31 Aug 2023 18:39:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id muAdCVfe8GQhPgAAMHmgww (envelope-from ); Thu, 31 Aug 2023 18:39:19 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Wei Wang Subject: [PATCH v5 0/8] Fix segfault on migration return path Date: Thu, 31 Aug 2023 15:39:08 -0300 Message-Id: <20230831183916.13203-1-farosas@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org What was left from v4 was to figure out how to pair the yank register/unregister for the QEMUFiles. I noticed that we don't really need to call unregister_yank under the lock. We just need to make sure the pointer is still valid. So I went with Peter's first suggestion which was to call the function individually for the QIOChannels we know yank is registered. CI run: https://gitlab.com/farosas/qemu/-/pipelines/988224440 v4: https://lore.kernel.org/r/20230816142510.5637-1-farosas@suse.de v3: https://lore.kernel.org/r/20230811150836.2895-1-farosas@suse.de v2: https://lore.kernel.org/r/20230802143644.7534-1-farosas@suse.de v1: https://lore.kernel.org/r/20230728121516.16258-1-farosas@suse.de Fabiano Rosas (8): migration: Fix possible race when setting rp_state.error migration: Fix possible races when shutting down the return path migration: Fix possible race when shutting down to_dst_file migration: Remove redundant cleanup of postcopy_qemufile_src migration: Consolidate return path closing code migration: Replace the return path retry logic migration: Move return path cleanup to main migration thread migration: Add a wrapper to cleanup migration files migration/migration.c | 231 +++++++++++++------------------------ migration/migration.h | 1 - migration/yank_functions.c | 5 + 3 files changed, 88 insertions(+), 149 deletions(-)