From patchwork Wed Aug 30 22:47:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 1828035 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F/4goVB3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RbfbS2ppxz1yfm for ; Thu, 31 Aug 2023 08:48:36 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbTyw-0006TN-0q; Wed, 30 Aug 2023 18:48:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbTyt-0006RN-Ty for qemu-devel@nongnu.org; Wed, 30 Aug 2023 18:48:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbTyr-0001KG-RS for qemu-devel@nongnu.org; Wed, 30 Aug 2023 18:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693435688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AxrAblbhpof7DMyt9/wfYw7XgNulpGCBvps1Od41TZk=; b=F/4goVB3w/Zd7wno++QH7r8Vk5v60f+i2KQDuPJjf9d1hyjaoqGAJav/UFl6FZ+l8m2fEq Y0KAZtcz/gr7kuJyY+9XXriANriVw+yo57jC4v4rJQM/VPllvngZutqrPDZYdQGYu6OIGN tr/dioleRF+tw0T/XQCbiWrutg3arIA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-54-zbkyx7d2NaCu4yix7pi4JQ-1; Wed, 30 Aug 2023 18:48:04 -0400 X-MC-Unique: zbkyx7d2NaCu4yix7pi4JQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F611858EED; Wed, 30 Aug 2023 22:48:04 +0000 (UTC) Received: from localhost (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78A48492C18; Wed, 30 Aug 2023 22:48:03 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Daniel Berrange , Vladimir Sementsov-Ogievskiy , Leonardo Bras , farosas@suse.de, Hanna Reitz , Juan Quintela , Paolo Bonzini , Peter Xu , kwolf@redhat.com, Coiby Xu , Fam Zheng , eblake@redhat.com, , Stefan Hajnoczi Subject: [PATCH v3 0/4] io: follow coroutine AioContext in qio_channel_yield() Date: Wed, 30 Aug 2023 18:47:58 -0400 Message-ID: <20230830224802.493686-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org v3: - Fix wrong copy-pasted function name in doc comment [Eric] - Fix "match" -> "matches" in comment [Eric] v2: - Add Patch 1 & 2 to remove unused NBD aio_context arguments and dead code [Fabiano] - Remove attach/detach prototypes from "io/channel.h" [Daniel] - Add utility function to set fd handlers [Daniel] The ongoing QEMU multi-queue block layer effort makes it possible for multiple threads to process I/O in parallel. The nbd block driver is not compatible with the multi-queue block layer yet because QIOChannel cannot be used easily from coroutines running in multiple threads. This series changes the QIOChannel API to make that possible. Stefan Hajnoczi (4): nbd: drop unused nbd_receive_negotiate() aio_context argument nbd: drop unused nbd_start_negotiate() aio_context argument io: check there are no qio_channel_yield() coroutines during ->finalize() io: follow coroutine AioContext in qio_channel_yield() include/block/nbd.h | 3 +- include/io/channel-util.h | 23 ++++++ include/io/channel.h | 69 ++++++++--------- include/qemu/vhost-user-server.h | 1 + block/nbd.c | 11 +-- io/channel-command.c | 10 ++- io/channel-file.c | 9 ++- io/channel-null.c | 3 +- io/channel-socket.c | 9 ++- io/channel-tls.c | 6 +- io/channel-util.c | 24 ++++++ io/channel.c | 124 ++++++++++++++++++++++--------- migration/channel-block.c | 3 +- nbd/client-connection.c | 3 +- nbd/client.c | 14 +--- nbd/server.c | 14 +--- qemu-nbd.c | 4 +- scsi/qemu-pr-helper.c | 4 +- util/vhost-user-server.c | 27 +++++-- 19 files changed, 228 insertions(+), 133 deletions(-)