mbox series

[0/2] docs tests: Fix use of migrate_set_parameter

Message ID 20230825155923.1983141-1-armbru@redhat.com
Headers show
Series docs tests: Fix use of migrate_set_parameter | expand

Message

Markus Armbruster Aug. 25, 2023, 3:59 p.m. UTC 
I spotted a bad use of migrate_set_parameter in test-hmp.c, and looked
for more.

I also looked for more failing HMP commands in test-hmp.c.  I found
some, but they fail only on some machines, which feels okay.  They
are:

* device_add usb-mouse,id=mouse1
  device_del mouse1

  Fail when the device is not compiled in, and when the machine
  doesn't provide USB.

* memsave 0 4096 "/dev/null"

  Fails when the machine doesn't have memory there.

* screendump /dev/null

  Fails when there is no console.

* dump-guest-memory /dev/null 0 4096

  Fails for targets that don't support dumping, and when the machine
  doesn't have memory there.

* nmi

  Fails when the machine doesn't provide NMIs.

Markus Armbruster (2):
  docs tests: Fix use of migrate_set_parameter
  tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test

 docs/multi-thread-compression.txt | 12 ++++++------
 docs/rdma.txt                     |  2 +-
 tests/qtest/test-hmp.c            |  6 +++---
 tests/qemu-iotests/181            |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

Comments

Michael Tokarev Aug. 29, 2023, 5:37 p.m. UTC | #1 
25.08.2023 18:59, Markus Armbruster wrote:
> I spotted a bad use of migrate_set_parameter in test-hmp.c, and looked
> for more.

Applied to my trivial-patches tree. Thanks!

/mjt