From patchwork Thu Aug 17 15:58:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 1822438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OJYwZBMf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RRVGw4pslz1yZd for ; Fri, 18 Aug 2023 02:06:00 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWfP6-0007Fc-PX; Thu, 17 Aug 2023 11:59:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWfOy-00070U-LY for qemu-devel@nongnu.org; Thu, 17 Aug 2023 11:59:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWfOq-0003m0-6l for qemu-devel@nongnu.org; Thu, 17 Aug 2023 11:59:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692287934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oTT7bKV9KwvS314ipvuTanKXvhR68UXiljwmEfE3uNo=; b=OJYwZBMfI3W6tf+LhIRa7j/6Hzo3hxIwCwr3lh7ialEYq0RaNHQPFIbhj+GAR1ewWGzGUb ndvE8QwBPRlS+rOkhSyUSEuzG+mY8JWEUsrvSKV+r6hlt+3VGYtJV/jCxaBAX8bnEz/+Gl IYxa4UANet5Ixe9oSNFyzMuplrESAz8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-370-_PYTQOiYObCub5SvCMnmSQ-1; Thu, 17 Aug 2023 11:58:50 -0400 X-MC-Unique: _PYTQOiYObCub5SvCMnmSQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4639D8DC66D; Thu, 17 Aug 2023 15:58:50 +0000 (UTC) Received: from localhost (unknown [10.39.193.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C3F9C15BAE; Thu, 17 Aug 2023 15:58:48 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: , Stefan Hajnoczi , Fam Zheng , xen-devel@lists.xenproject.org, Anthony Perard , Hanna Reitz , Kevin Wolf , Julia Suvorova , Stefano Garzarella , Paolo Bonzini , Aarushi Mehta , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Stefano Stabellini , Paul Durrant , Ilya Maximets Subject: [PATCH v2 0/4] virtio-blk: use blk_io_plug_call() instead of notification BH Date: Thu, 17 Aug 2023 11:58:43 -0400 Message-ID: <20230817155847.3605115-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.021, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org v2: - Rename blk_io_plug() to defer_call() and move it to util/ so the net subsystem can use it [Ilya] - Add defer_call_begin()/end() to thread_pool_completion_bh() to match Linux AIO and io_uring completion batching Replace the seldom-used virtio-blk notification BH mechanism with blk_io_plug(). This is part of an effort to enable the multi-queue block layer in virtio-blk. The notification BH was not multi-queue friendly. The blk_io_plug() mechanism improves fio rw=randread bs=4k iodepth=64 numjobs=8 IOPS by ~9% with a single IOThread and 8 vCPUs (this is not even a multi-queue block layer configuration) compared to no completion batching. iodepth=1 decreases by ~1% but this could be noise. Benchmark details are available here: https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd Stefan Hajnoczi (4): block: rename blk_io_plug_call() API to defer_call() util/defer-call: move defer_call() to util/ virtio: use defer_call() in virtio_irqfd_notify() virtio-blk: remove batch notification BH MAINTAINERS | 3 +- include/qemu/defer-call.h | 15 +++ include/sysemu/block-backend-io.h | 4 - block/blkio.c | 9 +- block/io_uring.c | 11 ++- block/linux-aio.c | 9 +- block/nvme.c | 5 +- block/plug.c | 159 ------------------------------ hw/block/dataplane/virtio-blk.c | 48 +-------- hw/block/dataplane/xen-block.c | 11 ++- hw/block/virtio-blk.c | 5 +- hw/scsi/virtio-scsi.c | 7 +- hw/virtio/virtio.c | 11 ++- util/defer-call.c | 156 +++++++++++++++++++++++++++++ util/thread-pool.c | 5 + block/meson.build | 1 - util/meson.build | 1 + 17 files changed, 227 insertions(+), 233 deletions(-) create mode 100644 include/qemu/defer-call.h delete mode 100644 block/plug.c create mode 100644 util/defer-call.c