From patchwork Tue Jul 11 16:58:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Max Chou X-Patchwork-Id: 1806484 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=K4VoyTHz; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R0nK05T02z20ZZ for ; Wed, 12 Jul 2023 03:04:04 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJGiH-00010L-U4; Tue, 11 Jul 2023 12:59:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJGiE-0000zH-IS for qemu-devel@nongnu.org; Tue, 11 Jul 2023 12:59:43 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJGiC-0000cv-7I for qemu-devel@nongnu.org; Tue, 11 Jul 2023 12:59:42 -0400 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-55b66ca1c80so3087983a12.0 for ; Tue, 11 Jul 2023 09:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1689094777; x=1691686777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hM2G7f2bsClZF2OPApd5PTF/It0iMznwAf+FEtJW4dE=; b=K4VoyTHzAuDTlXz1N1bjRwvPGxKpsK0+edNb0XCiIvCpwq0TIDD1XW8ck34p0QAs+I O8oYm4YzTLm8TJXvBQNt7XHJZcEu9qawxHVuYiIvsLzXoRe1ARM/FAV33NF++3A44laI yDDzpAzjZpPG9dbeROb1sYr0P7d5ttuTEbu00axyKhv/Tu+9hKodCfQLKF7OHuDNVGep +KDdS+/4OBCIHL8tLDBPd1I9Sc+T5d/GnEV2Z2Nf6n++yvijfW1dBHBbMj3k6/eOH83s ZIhdhIY9uAkKmQjYK5Anu+JP8lgzkgKjUr0gpGw7rxr29DvjiPRZ7cdQfhG5r0oI7iNj x2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689094777; x=1691686777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hM2G7f2bsClZF2OPApd5PTF/It0iMznwAf+FEtJW4dE=; b=VnTyZCauYBWWBJ3OaE9ay7+m8bhIWSJ3vjxnFhlrD6znYdYwOmxHp0yUFG5MhAPlho lyJWB7OupptJvZWPfvuKMshdvwxLVgTnDWfRVqamN8IjzSirnJZtEve9MiM7i9S7V2qy LPruPb9Mve7MPAOsESdHr+uoI2oSswcLD2z2T8ZK2LE/gJmLW2fTUcqsIJyMPh9rEzXJ KsDPioVSyrWg9h/12r1Lo0KZFzGh4LYTimVcFGmm/8nU22MTJyfWHwlk/8QOyhomDCl+ y8dhHNIqJ5tCEYm9UlhqhN0qQEg89F+t4ANNfDIzeVwK3cnuiFyaOQgTmDhAqykHyyYD cHSg== X-Gm-Message-State: ABy/qLb3c00jBZ0YoPb0QpiwzTojoEOP3OO5WPJ35hcUEYG6fJgLAlrf VMOTRSiNd/cbrJDXEPWwMpz1olJRzsdUuJXxiC18IsSNeuXDiASCNEeVIMNexnrpGOZkO8Cy8Rr btSt+kCWL5nAJ4m27N6pLsv4Z/tT6g2+G5lfYzl5rM+KRvuj/rqO1NWcT12tVoccG18OqSjzon4 Lqc1g= X-Google-Smtp-Source: APBJJlFcf9+OJsXaQgnmF5VTgqvZzTA121updsJB7E3wa4/TmR/TOQtcg9btJkhcyywvOQz96OPWiQ== X-Received: by 2002:a17:90a:1789:b0:259:10a8:2389 with SMTP id q9-20020a17090a178900b0025910a82389mr12065171pja.35.1689094777211; Tue, 11 Jul 2023 09:59:37 -0700 (PDT) Received: from duncan.localdomain (125-228-20-175.hinet-ip.hinet.net. [125.228.20.175]) by smtp.gmail.com with ESMTPSA id gw10-20020a17090b0a4a00b00262fc84b931sm8381793pjb.44.2023.07.11.09.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 09:59:36 -0700 (PDT) From: Max Chou To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: dbarboza@ventanamicro.com, alistair23@gmail.com, Max Chou Subject: [PATCH v8 00/15] Add RISC-V vector cryptographic instruction set support Date: Wed, 12 Jul 2023 00:58:59 +0800 Message-Id: <20230711165917.2629866-1-max.chou@sifive.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=max.chou@sifive.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patchset provides an implementation for Zvbb, Zvbc, Zvkned, Zvknh, Zvksh, Zvkg, and Zvksed of the draft RISC-V vector cryptography extensions as per the v20230620 version of the specification(1)(168e7b4). This is an update to the patchset submitted to qemu-devel on Wed, 12 Jul 2023 00:31:21 +0800 v2: Squashed commits into one commit per extension with separate commits for each refactoring. Unified trans_rvzvk*.c.inc files into one trans_rvvk.c.inc. Style fixes in insn32.decode and other files. Added macros for EGS values in translation functions. Updated from v20230303 to v20230407 of the spec: Zvkb has been split into Zvbb and Zvbc. vbrev, vclz, vctz, vcpop and vwsll have been added to Zvbb. v3: New patch 03/19 removes redundant “cpu_vl == 0” checks from trans_rvv.c.inc. Introduction of new tcg ops has been factored out of patch 11/19 and into 09/19. These ops are now added to non riscv-specific files. v4: New patch 08/17 fixes the tcg_gen_gvec_andcs temporary variable issue. Patch 09/17 fixes imm mode for vror.vi. Rebased to riscv-to-apply.next branch (de395bb): Replace vstart constraint checking by TCG op. Verified by code examples provided by vector crypto spec repository (riscv-crypto). v5: Imported aes-round.h for Zvkned extension. Rebased to 20230620110758.787479-1-richard.henderson@linaro.org Exposed the properties of v4 patch 17/17 to the patches that the extension was added. Removed v4 patch 08/17 that is queued to tcg-next. v6: Resent the same content becaue v5 was splitted by broken git-send-mail v7: Fixed endian issues Replace the TCG ops of vstart & vl EGS checking by helper function Changed the SEW selection of vsha2c[hl].vv to TCG translation v8: Rebased to the riscv-to-apply.next branch Fixed cross win32 build issue Removed redundent swap in AES key expanding (vaeskf1 & vaeskf2) As v20230620 is a frozen version, we are not expecting any significant changes to the specification or this patch series. Please note that the Zvkt data-independent execution latency extension (and all extensions including it) has not been implemented, and we would recommend not using these patches in an environment where timing attacks are an issue. Work performed by Dickon, Lawrence, Nazar, Kiran, and William from Codethink sponsored by SiFive, as well as Max Chou and Frank Chang from SiFive. https://github.com/riscv/riscv-crypto/releases Thanks to those who have already reviewed: Daniel Henrique Barboza dbarboza@ventanamicro.com [PATCH v4 09/17] target/riscv: Add Zvbb ISA extension support [PATCH v4 10/17] target/riscv: Add Zvkned ISA extension support [PATCH v4 11/17] target/riscv: Add Zvknh ISA extension support [PATCH v4 12/17] target/riscv: Add Zvksh ISA extension support [PATCH v4 13/17] target/riscv: Add Zvkg ISA extension support Weiwei Li liweiwei@iscas.ac.cn [PATCH v3 01/19] target/riscv: Refactor some of the generic vector functionality [PATCH v3 02/19] target/riscv: Refactor vector-vector translation macro [PATCH v3 03/19] target/riscv: Remove redundant "cpu_vl == 0" checks [PATCH v3 05/19] target/riscv: Move vector translation checks [PATCH v3 06/19] target/riscv: Refactor translation of vector-widening instruction [PATCH v3 07/19] target/riscv: Refactor some of the generic vector functionality [PATCH v3 19/19] target/riscv: Expose Zvk* and Zvb[b, c] cpu properties Richard Henderson richard.henderson@linaro.org [PATCH v2 02/17] target/riscv: Refactor vector-vector translation macro [PATCH v2 04/17] target/riscv: Move vector translation checks [PATCH v2 05/17] target/riscv: Refactor translation of vector-widening instruction [PATCH v2 07/17] qemu/bitops.h: Limit rotate amounts [PATCH v2 08/17] qemu/host-utils.h: Add clz and ctz functions for lower-bit integers [PATCH v2 14/17] crypto: Create sm4_subword Alistair Francis alistair.francis@wdc.com [PATCH v2 02/17] target/riscv: Refactor vector-vector translation macro Philipp Tomsich philipp.tomsich@vrull.eu Various v1 reviews Christoph Müllner christoph.muellner@vrull.eu Various v1 reviews Dickon Hood (2): target/riscv: Refactor translation of vector-widening instruction target/riscv: Add Zvbb ISA extension support Kiran Ostrolenk (4): target/riscv: Refactor some of the generic vector functionality target/riscv: Refactor vector-vector translation macro target/riscv: Refactor some of the generic vector functionality target/riscv: Add Zvknh ISA extension support Lawrence Hunter (2): target/riscv: Add Zvbc ISA extension support target/riscv: Add Zvksh ISA extension support Max Chou (3): crypto: Create sm4_subword crypto: Add SM4 constant parameter CK target/riscv: Add Zvksed ISA extension support Nazar Kazakov (4): target/riscv: Remove redundant "cpu_vl == 0" checks target/riscv: Move vector translation checks target/riscv: Add Zvkned ISA extension support target/riscv: Add Zvkg ISA extension support crypto/sm4.c | 10 + include/crypto/sm4.h | 9 + target/arm/tcg/crypto_helper.c | 10 +- target/riscv/cpu.c | 37 + target/riscv/cpu_cfg.h | 8 + target/riscv/helper.h | 98 +++ target/riscv/insn32.decode | 58 ++ target/riscv/insn_trans/trans_rvv.c.inc | 171 ++-- target/riscv/insn_trans/trans_rvvk.c.inc | 606 ++++++++++++++ target/riscv/meson.build | 4 +- target/riscv/translate.c | 1 + target/riscv/vcrypto_helper.c | 970 +++++++++++++++++++++++ target/riscv/vector_helper.c | 243 +----- target/riscv/vector_internals.c | 81 ++ target/riscv/vector_internals.h | 228 ++++++ 15 files changed, 2179 insertions(+), 355 deletions(-) create mode 100644 target/riscv/insn_trans/trans_rvvk.c.inc create mode 100644 target/riscv/vcrypto_helper.c create mode 100644 target/riscv/vector_internals.c create mode 100644 target/riscv/vector_internals.h