mbox series

[v4,0/6] migration: Test the new "file:" migration

Message ID 20230706201927.15442-1-farosas@suse.de
Headers show
Series migration: Test the new "file:" migration | expand

Message

Fabiano Rosas July 6, 2023, 8:19 p.m. UTC
Based-on:
[PATCH V4 0/2] migration file URI
https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sistare@oracle.com

Since v3:

- used FILE_TEST_FILENAME for the three tests

v3:
https://lore.kernel.org/r/20230630212902.19925-1-farosas@suse.de

v2:
https://lore.kernel.org/r/20230628165542.17214-1-farosas@suse.de

v1:
https://lore.kernel.org/r/20230626182210.8792-1-farosas@suse.de

Here's the test for the file: migration.

I hit an issue with the setting of migration status. If we call
query-migrate too soon after migrate-incoming, the query returns an
empty response because we're not setting the MIGRATION_STATUS_SETUP in
the incoming path. We just send the event, but never actually change
state.

Aside from the fix, there's some tidying up to avoid duplicating too
much code in the tests.

Thanks

CI run: https://gitlab.com/farosas/qemu/-/pipelines/912226554

Fabiano Rosas (6):
  tests/qtest: migration: Expose migrate_set_capability
  tests/qtest: migration: Add migrate_incoming_qmp helper
  tests/qtest: migration: Use migrate_incoming_qmp where appropriate
  migration: Set migration status early in incoming side
  tests/qtest: migration: Add support for negative testing of
    qmp_migrate
  tests/qtest: migration-test: Add tests for file-based migration

 migration/migration.c             |   7 +-
 tests/qtest/libqtest.c            |  33 +++++++
 tests/qtest/libqtest.h            |  28 ++++++
 tests/qtest/meson.build           |   1 +
 tests/qtest/migration-helpers.c   |  60 +++++++++++++
 tests/qtest/migration-helpers.h   |  10 +++
 tests/qtest/migration-test.c      | 138 +++++++++++++++++++++++++-----
 tests/qtest/virtio-net-failover.c |  77 ++---------------
 8 files changed, 261 insertions(+), 93 deletions(-)