From patchwork Tue Jun 27 16:09:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1800680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Xc/FwAb9; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qr8qh59vsz242J for ; Wed, 28 Jun 2023 02:12:16 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEBGN-0008FM-Fe; Tue, 27 Jun 2023 12:09:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEBGI-0007lo-Ig for qemu-devel@nongnu.org; Tue, 27 Jun 2023 12:09:50 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEBGE-0005mC-DR for qemu-devel@nongnu.org; Tue, 27 Jun 2023 12:09:50 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-313f59cd193so2091549f8f.2 for ; Tue, 27 Jun 2023 09:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687882185; x=1690474185; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EkR9h8Ua4R2j31dBp31QD7DyNEN7yRbsUjm22wy9EEQ=; b=Xc/FwAb9QnSXKN4i/SPg/3DIuHjvKx4tayLmSXbavSUNNs2xPdlpF9qxIyScfIVDL3 ejZBfPPIEMswBifiXe0zWa/aXt5/f9Lf6IbzPQ8mr+njD/wEK8A0E6WF8rDntCyt05ve ef+MV0MSLIzuqp0bMSDnsvzf3sjr6bLm/B8Yw8VDyWg65xDcrGLJk4Ocu2kV07m6H6BV d01JFNVSD3bFzHivmb/MJj/+S37K5rE/HwMoawLq6K//CoKvYYdf9N8PhCisS0BfatM1 78HdOcwq4KIu648wvDsPUL2/bsCPZiEtan6YY8LNwaKjNexsnCuIe3+phUIeJHJLoQ6j GAuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687882185; x=1690474185; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EkR9h8Ua4R2j31dBp31QD7DyNEN7yRbsUjm22wy9EEQ=; b=MtV7me8kdQIsbtBi5d9JuDhnYtFW1kynrlSeWztMxgdPXuAiLlFSyGVVp05czWaMJy 0Uwlo3MV8Jk8yvLpnuQ/N8kNLGDaVOLpa3FpXEz8up6fRIN2ddWboND04l+VjYYcrIYC fygn//nKGGg4DqvtEaXi0zVHH1pujy0rEH5twm+A5rK11Wd6Y1VZfh8u5MygoGra4ko3 +/NCLhKStBCoV19++s4WSZ84zk8b+6B+ekIQ1D0IAFnluYTEZA996d7A6uM+FJ49y27J Ziwdq9N2es4z0oeBChzK6Ukv5pvuCvqStT0oKWqu7WgAAdW7PJWgbmCeO8YkQ/PGNd/i +Pnw== X-Gm-Message-State: AC+VfDxws9M/kwDorJj74cWv/rNIvMwmuXTeZwAlisgwO+6q86x8+giJ xdeD1CufxwvM49wTu6pnZEsLeQ== X-Google-Smtp-Source: ACHHUZ49p24qE0C7bj0Imu3KQqVZPo5AxCIqn/A/TY4IH56vlJkFFcNPnje4gieRUYENE3UQ6ZrAWA== X-Received: by 2002:a5d:4684:0:b0:313:e3b9:21a4 with SMTP id u4-20020a5d4684000000b00313e3b921a4mr8098497wrq.48.1687882184819; Tue, 27 Jun 2023 09:09:44 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id h15-20020a05600004cf00b0030e52d4c1bcsm10962939wri.71.2023.06.27.09.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 09:09:44 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DFED61FFBC; Tue, 27 Jun 2023 17:09:43 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Juan Quintela , Thomas Huth , Cleber Rosa , Leonardo Bras , Beraldo Leal , Peter Maydell , Bin Meng , Yanan Wang , Darren Kenny , Alexander Bulekov , Marcel Apfelbaum , Peter Xu , Radoslaw Biernacki , Laurent Vivier , Paolo Bonzini , Eduardo Habkost , qemu-arm@nongnu.org, Stefan Hajnoczi , Richard Henderson , Bandan Das , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?= =?utf-8?q?el_P=2E_Berrang=C3=A9?= , Alexandre Iooss , Marcin Juszkiewicz , Leif Lindholm , Laurent Vivier , Qiuhao Li , Mahmoud Mandour , Riku Voipio , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v3 00/36] maintainer omnibus: testing, fuzz, plugins, documentation, gdbstub (pre-PR) Date: Tue, 27 Jun 2023 17:09:07 +0100 Message-Id: <20230627160943.2956928-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As softfreeze is fast approaching I thought it would be work combining my various trees into an omnibus series to ease the review and merging. The testing updates exposed a number of latent leaks that confused the oss-fuzz jobs (hence the test-fuzz addition to help debug that). This also includes some minor plugin updates and finally some documentation updates that clean-up and expose the QOM and QDEV APIs which are so core to emulating anything in QEMU. v2 - applied a bunch of review tags - added missing doc suggestions from Paolo - tweaked the plugin fix for CI v3 - few more tags - checkpatch cleanups - rolled in gdbstub/next The following are still missing review: - gdbstub: lightly refactor connection to avoid snprintf - docs/devel: introduce some key concepts for QOM development - tests/docker: convert riscv64-cross to lcitool - tests/lcitool: introduce qemu-minimal - tests/lcitool: add an explicit gcc-native package (1 acks, 1 sobs, 0 tbs) - tests/lcitool: update to latest version (1 acks, 1 sobs, 0 tbs) - tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée (21): gitlab: reduce testing scope of check-gcov tests/tcg: add mechanism to handle plugin arguments qemu-keymap: properly check return from xkb_keymap_mod_get_index scripts/oss-fuzz: add a suppression for keymap tests/qtests: clean-up and fix leak in generic_fuzz tests/docker: add test-fuzz Makefile: add lcitool-refresh to UNCHECKED_GOALS tests/lcitool: update to latest version tests/lcitool: add an explicit gcc-native package tests/lcitool: introduce qemu-minimal tests/docker: convert riscv64-cross to lcitool plugins: force slow path when plugins instrument memory ops plugins: fix memory leak while parsing options plugins: update lockstep to use g_memdup2 docs/devel: add some front matter to the devel index include/migration: mark vmstate_register() as a legacy function include/hw/qdev-core: fixup kerneldoc annotations docs/devel: split qom-api reference into new file docs/devel: introduce some key concepts for QOM development gdbstub: lightly refactor connection to avoid snprintf gdbstub: clean-up vcont handling to avoid goto Ani Sinha (1): docs/devel: remind developers to run CI container pipeline when updating images Daniel P. Berrangé (2): gitlab: explicit set artifacts publishing criteria gitlab: ensure coverage job also publishes meson log Erik Skultety (1): tests/lcitool: Bump fedora container versions Ilya Leoshkevich (8): linux-user: Expose do_guest_openat() and do_guest_readlink() linux-user: Add "safe" parameter to do_guest_openat() linux-user: Emulate /proc/self/smaps gdbstub: Expose gdb_get_process() and gdb_get_first_cpu_in_process() gdbstub: Report the actual qemu-user pid gdbstub: Add support for info proc mappings docs: Document security implications of debugging tests/tcg: Add a test for info proc mappings Marcin Juszkiewicz (1): tests/avocado: update firmware to enable sbsa-ref/max Nicholas Piggin (1): gdbstub: Permit reverse step/break to provide stop response Philippe Mathieu-Daudé (1): docs/devel/qom.rst: Correct code style MAINTAINERS | 1 + docs/devel/index-api.rst | 2 + docs/devel/index-process.rst | 2 + docs/devel/index-tcg.rst | 2 + docs/devel/index.rst | 24 +- docs/devel/qdev-api.rst | 7 + docs/devel/qom-api.rst | 9 + docs/devel/qom.rst | 65 +++- docs/devel/tcg.rst | 2 + docs/devel/testing.rst | 6 + docs/system/gdb.rst | 15 + Makefile | 2 +- gdbstub/internals.h | 7 + include/exec/cpu-all.h | 2 +- include/hw/core/cpu.h | 17 + include/hw/qdev-core.h | 367 ++++++++++++------ include/migration/vmstate.h | 10 +- linux-user/qemu.h | 3 + accel/tcg/cputlb.c | 5 +- accel/tcg/user-exec.c | 8 +- contrib/plugins/cache.c | 2 +- contrib/plugins/drcov.c | 2 +- contrib/plugins/execlog.c | 2 +- contrib/plugins/hotblocks.c | 2 +- contrib/plugins/hotpages.c | 2 +- contrib/plugins/howvec.c | 2 +- contrib/plugins/hwprofile.c | 2 +- contrib/plugins/lockstep.c | 4 +- gdbstub/gdbstub.c | 115 ++++-- gdbstub/softmmu.c | 19 +- gdbstub/user-target.c | 139 +++++++ linux-user/syscall.c | 128 ++++-- qemu-keymap.c | 24 +- target/arm/tcg/sve_helper.c | 4 - tests/plugin/bb.c | 2 +- tests/plugin/insn.c | 2 +- tests/plugin/mem.c | 2 +- tests/plugin/syscall.c | 2 +- tests/qtest/fuzz/generic_fuzz.c | 11 +- .gitlab-ci.d/buildtest-template.yml | 4 +- .gitlab-ci.d/buildtest.yml | 7 +- .gitlab-ci.d/crossbuild-template.yml | 1 + .gitlab-ci.d/crossbuilds.yml | 2 + .gitlab-ci.d/opensbi.yml | 1 + scripts/oss-fuzz/lsan_suppressions.txt | 3 + tests/avocado/machine_aarch64_sbsaref.py | 23 +- tests/docker/dockerfiles/alpine.docker | 4 +- .../dockerfiles/debian-amd64-cross.docker | 1 + .../dockerfiles/debian-arm64-cross.docker | 1 + .../dockerfiles/debian-armel-cross.docker | 1 + .../dockerfiles/debian-armhf-cross.docker | 1 + .../dockerfiles/debian-mips64el-cross.docker | 1 + .../dockerfiles/debian-mipsel-cross.docker | 1 + .../dockerfiles/debian-ppc64el-cross.docker | 1 + .../dockerfiles/debian-riscv64-cross.docker | 119 +++--- .../dockerfiles/debian-s390x-cross.docker | 1 + .../dockerfiles/fedora-win32-cross.docker | 5 +- .../dockerfiles/fedora-win64-cross.docker | 5 +- tests/docker/dockerfiles/fedora.docker | 4 +- tests/docker/test-fuzz | 28 ++ tests/lcitool/libvirt-ci | 2 +- tests/lcitool/projects/qemu-minimal.yml | 27 ++ tests/lcitool/projects/qemu.yml | 1 + tests/lcitool/refresh | 18 +- tests/tcg/Makefile.target | 8 +- tests/tcg/aarch64/Makefile.target | 8 + tests/tcg/multiarch/Makefile.target | 9 +- .../multiarch/gdbstub/test-proc-mappings.py | 65 ++++ 68 files changed, 1061 insertions(+), 313 deletions(-) create mode 100644 docs/devel/qdev-api.rst create mode 100644 docs/devel/qom-api.rst create mode 100755 tests/docker/test-fuzz create mode 100644 tests/lcitool/projects/qemu-minimal.yml create mode 100644 tests/tcg/multiarch/gdbstub/test-proc-mappings.py