From patchwork Wed Jun 21 00:21:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 1797601 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WLPqj+0J; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qm43T1w7Tz20Xg for ; Wed, 21 Jun 2023 10:23:17 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBlbX-00041f-PY; Tue, 20 Jun 2023 20:21:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBlbU-0003yV-7W for qemu-devel@nongnu.org; Tue, 20 Jun 2023 20:21:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBlbQ-00007I-Ms for qemu-devel@nongnu.org; Tue, 20 Jun 2023 20:21:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687306899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rpb0bW17Lq9dL8U2yqW0FfJJAd283MW1GSXaVIBmnXA=; b=WLPqj+0J+A7+cbNky+DmWQh9HII8rl0+Puop39xGNF+AyXJyGjTmMO3tjyogls60ISYp9d 645XZfHeNiHWcc7pEVGuoRCqlz62Iebf8MZ0RJ+Jr8NqkU5vPv9po0T+rF7Sc69QP55u6c 00HQ8vLLn/LHC0qktyjreIYh8BH2xwE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-116-GzpYEc-lPVm9GYtFL0gT5g-1; Tue, 20 Jun 2023 20:21:35 -0400 X-MC-Unique: GzpYEc-lPVm9GYtFL0gT5g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F22680123E; Wed, 21 Jun 2023 00:21:35 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.32.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00321112132C; Wed, 21 Jun 2023 00:21:21 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-block@nongnu.org, Beraldo Leal , Hanna Reitz , =?utf-8?q?Alex_Benn=C3=A9e?= , John Snow , Kevin Wolf , Cleber Rosa , Paolo Bonzini Subject: [PATCH RFC 0/6] Switch iotests to pyvenv Date: Tue, 20 Jun 2023 20:21:15 -0400 Message-Id: <20230621002121.1609612-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi, this is ... a fairly incomplete series about trying to get iotests to run out of the configure-time venv. I'm looking for some feedback, so out to the list it goes. Primarily, I'm having doubts about these points: 1) I think I need something like "mkvenv install" in the first patch, but mkvenv.py is getting pretty long... 2) Is there a way to optimize the speed for patch #2? Maybe installing this package can be skipped until it's needed, but that means that things like iotest's ./check might get complicated to support that. 3) I cheated quite a bit in patch 4 to use the correct Python to launch iotests, but I'm wondering if there's a nicer way to solve this more *completely*. John Snow (6): experiment: add mkvenv install build, tests: Add qemu in-tree packages to pyvenv at configure time. iotests: get rid of '..' in path environment output iotests: use the correct python to run linters iotests: use pyvenv/bin/python3 to launch child test processes iotests: don't add qemu.git/python to PYTHONPATH configure | 31 +++++++++++++++++++++++++++ python/scripts/mkvenv.py | 40 +++++++++++++++++++++++++++++++++++ tests/qemu-iotests/linters.py | 2 +- tests/qemu-iotests/testenv.py | 21 ++++++++++++------ 4 files changed, 87 insertions(+), 7 deletions(-)