mbox series

[0/2] migration: switchover-hold flag

Message ID 20230602144715.249002-1-peterx@redhat.com
Headers show
Series migration: switchover-hold flag | expand

Message

Peter Xu June 2, 2023, 2:47 p.m. UTC 
This v1 patchset is based on Juan's latest pull request:

[PULL 00/10] Migration 20230602 patches
git: https://gitlab.com/juan.quintela/qemu.git tags/migration-20230602-pull-request
Based-on: <20230602104910.35157-1-quintela@redhat.com>

The solution is heavily based on the original idea from Daniel, however the
impl is done by a new flag introduced which could be hopefully cleaner
approach.

Comparing to RFC version, this v1:

  - Dropped the RFC tag, rebased to Juan's recent pull request so patch 2 dropped
  - In the last patch, start to set bw=0 by default for all tests
  - Enhanced commit messages / comments

A new flag "switchover-hold" is added to allow src qemu explicitly hold
switchover for precopy migration.  Note that this flag will not affect
postcopy switchover because src qemu already has migrate-start-postcopy,
which is a finer grained knob just for that.  In general this flag only
affects reaching migration completion phase, when set it'll block it from
happening while keep the migration iteration going.

This can be used in two cases so far in my mind:

  (1) One can use this parameter to start pre-heating migration (but not
      really migrating, so a migrate-cancel will cancel the preheat).  When
      the user wants to really migrate, just clear the flag.  It'll in most
      cases migrate immediately because most pages are already synced.

  (2) Can also be used as a clean way to do qtest, in many of the precopy
      tests we have requirement to run after 1 iteration without completing
      the precopy migration.  Before that we have either set bandwidth to
      ridiculous low value, or tricks on detecting guest memory change over
      some adhoc guest memory position.  Now we can simply set this flag
      then we know precopy won't complete and will just keep going.

The 1st use case may look a bit like COLO where we can actually keep both
QEMU _mostly_ in sync.  I'm not sure whether it can be useful anywhere,
though.

Patch 1 will introduce the new flag.

Patch 2 will leverage the new flag to speed up migration-test. An initial
test is this can make migration-test finish within a little bit more than
1m.

Please have a look, thanks.

Peter Xu (2):
  migration: switchover-hold parameter
  qtest/migration: Use switchover-hold to speedup

 qapi/migration.json            | 25 +++++++++++++--
 migration/migration.h          | 16 ++++++++++
 migration/migration-hmp-cmds.c |  3 ++
 migration/migration.c          | 56 ++++++++++++++++++++++++++++++++--
 migration/options.c            | 17 +++++++++++
 tests/qtest/migration-test.c   | 24 +++++++++++----
 6 files changed, 129 insertions(+), 12 deletions(-)