From patchwork Thu Jul 14 18:28:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Wu X-Patchwork-Id: 1656613 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=iAok/zjV; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LkNW162s7z9s09 for ; Fri, 15 Jul 2022 04:36:45 +1000 (AEST) Received: from localhost ([::1]:55804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC3hb-0004Iv-MH for incoming@patchwork.ozlabs.org; Thu, 14 Jul 2022 14:36:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3V2DQYggKCnYqobUinmbaiiafY.WigkYgo-XYpYfhihaho.ila@flex--wuhaotsh.bounces.google.com>) id 1oC3Zs-0005Ut-Dq for qemu-devel@nongnu.org; Thu, 14 Jul 2022 14:28:44 -0400 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]:48048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3V2DQYggKCnYqobUinmbaiiafY.WigkYgo-XYpYfhihaho.ila@flex--wuhaotsh.bounces.google.com>) id 1oC3Zp-00081q-Jy for qemu-devel@nongnu.org; Thu, 14 Jul 2022 14:28:44 -0400 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-31c8a5d51adso21235227b3.14 for ; Thu, 14 Jul 2022 11:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=gV+TyTQO6jOPvTt4hw3npsX3ehauWxm2nzUt3iPAaNg=; b=iAok/zjVWI7ARRKtn0IpBIkv+2yPjnvlx9S7YgoP2HPIcn9rYmSe2i1q0xjWepJadO skft2NHmg0DAgjuDj5skOGJCLCIIQM+Qy7XSwX3Ea6z88gmYpvV2QRtXBrI9qP3d0g6v Lue3UiJkUWgnNXReySLTwxEYHLdl1p3FTeIpNhPAwVrSjUX186GSJ03ipUA/6KVOH0+E VyPoWOy0q6b5WUAXt7L56rqirUhu/YRbL0nce0t8rDutZAGoGEU5VH+SUPmfAgbq/fSo xzIqxHU+Vx/EGnuY4WJnzBUcwOIdrHDsNHziJKqsVoAe2a9jwXgX84ncJYaHXRcEpC7r 7w8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=gV+TyTQO6jOPvTt4hw3npsX3ehauWxm2nzUt3iPAaNg=; b=pn7JL3983G22Ymc2ii5CS9BLkkk3OVVJTn819OBfSocYNhJffxEq5x9OlXbLcYJGqh hlWB1V+O2iMztJfUZBMnRxj7DSaaltqbbnTiP+xeBEnqW0tNLYIASCxlWLyO+AHul9M7 c9axr1EQG5dhjN4yv0pORwS119Yfyp88mbuqk88baqzH55BWRSK5vl6Z+OJVvnzz4b2n jtiK1khW00wwPGQO5wBAlsHZI7j/wKWhjEaMv6jZLhI5tWXi2CW122rO4JS9Z4b//o+l 944iuv6uT7WlV/pGGkFvQ6q0nR4B3mUlx4NJKiG6D8QfIyckIpMaTc5e6DYrVpAVev5R 23Bw== X-Gm-Message-State: AJIora8j36wF25a0fZT91wEttqDi9akgJilNv2X99032DbmXPl/DotJC O7ojSlKR8jSRpEyUMHAXO2OulAq8THqbow== X-Google-Smtp-Source: AGRyM1v/E0LEwLXH24tBC+0Va91tL6oCc0IWdtCEaQrLo2/qlEnkptqbvvxiUkAvrboTG3hBpue8CfmYW4euTw== X-Received: from mimik.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:4e]) (user=wuhaotsh job=sendgmr) by 2002:a25:5f4a:0:b0:66e:e941:22ef with SMTP id h10-20020a255f4a000000b0066ee94122efmr9603976ybm.229.1657823319948; Thu, 14 Jul 2022 11:28:39 -0700 (PDT) Date: Thu, 14 Jul 2022 11:28:28 -0700 Message-Id: <20220714182836.89602-1-wuhaotsh@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.0.170.g444d1eabd0-goog Subject: [PATCH v5 0/8] Misc NPCM7XX patches From: Hao Wu To: peter.maydell@linaro.org Cc: richard.henderson@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, wuhaotsh@google.com, venture@google.com, Avi.Fishman@nuvoton.com, kfting@nuvoton.com, hskinnemoen@google.com, f4bug@amsat.org, bin.meng@windriver.com, qemu-block@nongnu.org, armbru@redhat.com, thuth@redhat.com Received-SPF: pass client-ip=2607:f8b0:4864:20::114a; envelope-from=3V2DQYggKCnYqobUinmbaiiafY.WigkYgo-XYpYfhihaho.ila@flex--wuhaotsh.bounces.google.com; helo=mail-yw1-x114a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" [NOTE: I'm reviving a bunch of patches that was in the process of upstreaming a while ago but paused.] This patch set contains a few bug fixes and I2C devices for some NPCM7XX boards. Patch 1~2 fix a problem that causes the SMBus module to behave incorrectly when it's in FIFO mode and trying to receive more than 16 bytes at a time. Patch 3 fixes a error in a register for ADC module. Patch 4 makes the ADC input to be R/W instead of write only. It allows a test system to read these via QMP and has no negative effect. Patch 5 adds a new blockdev IF type IF_OTHER. Patch 6 allows at24c_eeprom_init to take a bus as parameter so it can be used by more use cases (e.g. behind an I2C mux.) Patch 7 allows at24c_eeprom_init to take a drive as property, similar to sdhci_attach_device(). Patch 8 uses the function defined in patch 5 to add the EEPROM and other I2C devices for Quanta GBS board. -- Changes since v4: 1. Add comments to patch 5. 2. Split patch 6 into 2 patches according to the feedback. Each patch does it own task. -- Changes since v3: 1. Add a new blockdev IF type IF_OTHER. 2. Use IF_OTHER instead of IF_NONE. -- Changes since v2: 1. Dropped patch 7. 2. Drop an extra variable in patch 5. -- Changes since v1: 1. Rewrote patch 5 to implement the function in NPCM7xx board file instead of the EEPROM device file. 2. Slightly modify patch 6 to adapt to the changes and QEMU comment style. 3. Squash patch 7 into patch 5 to make it compile. 4. Add a new patch 7. Hao Wu (7): hw/i2c: Clear ACK bit in NPCM7xx SMBus module hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBus hw/adc: Fix CONV bit in NPCM7XX ADC CON register hw/adc: Make adci[*] R/W in NPCM7XX ADC blockdev: Add a new IF type IF_OTHER hw/arm: npcm8xx_boards: EEPROMs can take bus as parameter hw/arm: Set drive property for at24c eeprom Patrick Venture (1): hw/arm: quanta-gbs-bmc add i2c devices blockdev.c | 4 +- hw/adc/npcm7xx_adc.c | 4 +- hw/arm/npcm7xx_boards.c | 102 ++++++++++++++++++++------------- hw/i2c/npcm7xx_smbus.c | 8 +-- include/sysemu/blockdev.h | 1 + tests/qtest/npcm7xx_adc-test.c | 2 +- 6 files changed, 73 insertions(+), 48 deletions(-)