mbox series

[00/12] hw/nvme: misc fixes and updates

Message ID 20220623211821.50534-1-its@irrelevant.dk
Headers show
Series hw/nvme: misc fixes and updates | expand

Message

Klaus Jensen June 23, 2022, 9:18 p.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

This series includes a couple of misc fixes as well as some cleanup
pertaining to the aio handling in flush, dsm, copy and zone reset. As
Jinhao gets around to iothread stuff, it might come in handy to have
this stuff cleaned up a bit.

Dmitrys fix (nvme-next commit "hw/nvme: add missing return statement")
for dsm prompted me to audit the flush, dsm, zone reset and copy code
and that resulted in the discovery of some bugs and some general clean
up.

Klaus Jensen (12):
  hw/nvme: fix incorrect use of errp/local_err
  hw/nvme: remove redundant passing of PCIDevice
  hw/nvme: cleanup error reporting in nvme_init_pci()
  hw/nvme: fix numzrwa handling
  hw/nvme: fix accidental reintroduction of redundant code
  hw/nvme: fix cancellation of format operations
  hw/nvme: fix flush cancel
  hw/nvme: rework flush bh scheduling
  hw/nvme: improve cancellation handling in zone reset
  hw/nvme: improve cancellation handling in dsm
  hw/nvme: simplify copy command error handling
  hw/nvme: align logic of format with flush

 hw/nvme/ctrl.c | 252 +++++++++++++++++++++++--------------------------
 hw/nvme/ns.c   |   4 +-
 2 files changed, 119 insertions(+), 137 deletions(-)

Comments

Klaus Jensen July 14, 2022, 5:37 a.m. UTC | #1
On Jun 23 23:18, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This series includes a couple of misc fixes as well as some cleanup
> pertaining to the aio handling in flush, dsm, copy and zone reset. As
> Jinhao gets around to iothread stuff, it might come in handy to have
> this stuff cleaned up a bit.
> 
> Dmitrys fix (nvme-next commit "hw/nvme: add missing return statement")
> for dsm prompted me to audit the flush, dsm, zone reset and copy code
> and that resulted in the discovery of some bugs and some general clean
> up.
> 
> Klaus Jensen (12):
>   hw/nvme: fix incorrect use of errp/local_err
>   hw/nvme: remove redundant passing of PCIDevice
>   hw/nvme: cleanup error reporting in nvme_init_pci()
>   hw/nvme: fix numzrwa handling
>   hw/nvme: fix accidental reintroduction of redundant code
>   hw/nvme: fix cancellation of format operations
>   hw/nvme: fix flush cancel
>   hw/nvme: rework flush bh scheduling
>   hw/nvme: improve cancellation handling in zone reset
>   hw/nvme: improve cancellation handling in dsm
>   hw/nvme: simplify copy command error handling
>   hw/nvme: align logic of format with flush
> 
>  hw/nvme/ctrl.c | 252 +++++++++++++++++++++++--------------------------
>  hw/nvme/ns.c   |   4 +-
>  2 files changed, 119 insertions(+), 137 deletions(-)
> 
> -- 
> 2.36.1
> 

Ping,

We are coming up on the 7.1 soft-freeze. Most of the above are fixes, so
they can go in after, but I'd like to get a couple of the other non-fix
patches in if possile ;)