mbox series

[v2,0/5] hw/nvme: fix namespace identifiers

Message ID 20220429083336.2201286-1-its@irrelevant.dk
Headers show
Series hw/nvme: fix namespace identifiers | expand

Message

Klaus Jensen April 29, 2022, 8:33 a.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

The namespace identifiers reported by the controller is kind of a mess.
See [1,2].

This series should fix this for both the `-device nvme,drive=...` and
`-device nvme-ns,...` cases.

  [1]: https://lore.kernel.org/linux-nvme/20220224192845.1097602-1-hch@lst.de/
  [2]: https://lore.kernel.org/linux-nvme/20220413044905.376785-1-hch@lst.de/

Changes since v1:
 - Revert auto-generation of eui64 (Christoph)
   User should set it explicitly.

Klaus Jensen (5):
  hw/nvme: enforce common serial per subsystem
  hw/nvme: do not auto-generate eui64
  hw/nvme: do not auto-generate uuid
  hw/nvme: do not report null uuid
  hw/nvme: bump firmware revision

 docs/about/deprecated.rst |  7 +++++++
 hw/core/machine.c         |  4 +++-
 hw/nvme/ctrl.c            | 19 ++++++++-----------
 hw/nvme/ns.c              |  4 ++--
 hw/nvme/nvme.h            |  1 +
 hw/nvme/subsys.c          |  7 +++++++
 6 files changed, 28 insertions(+), 14 deletions(-)

Comments

Klaus Jensen May 12, 2022, 9:27 a.m. UTC | #1
On Apr 29 10:33, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> The namespace identifiers reported by the controller is kind of a mess.
> See [1,2].
> 
> This series should fix this for both the `-device nvme,drive=...` and
> `-device nvme-ns,...` cases.
> 
>   [1]: https://lore.kernel.org/linux-nvme/20220224192845.1097602-1-hch@lst.de/
>   [2]: https://lore.kernel.org/linux-nvme/20220413044905.376785-1-hch@lst.de/
> 
> Changes since v1:
>  - Revert auto-generation of eui64 (Christoph)
>    User should set it explicitly.
> 
> Klaus Jensen (5):
>   hw/nvme: enforce common serial per subsystem
>   hw/nvme: do not auto-generate eui64
>   hw/nvme: do not auto-generate uuid
>   hw/nvme: do not report null uuid
>   hw/nvme: bump firmware revision
> 
>  docs/about/deprecated.rst |  7 +++++++
>  hw/core/machine.c         |  4 +++-
>  hw/nvme/ctrl.c            | 19 ++++++++-----------
>  hw/nvme/ns.c              |  4 ++--
>  hw/nvme/nvme.h            |  1 +
>  hw/nvme/subsys.c          |  7 +++++++
>  6 files changed, 28 insertions(+), 14 deletions(-)
> 
> -- 
> 2.35.1
> 

Thanks for the reviews! Applied to nvme-next.