mbox series

[0/5] ppc/pnv: Introduce GPIO lines to drive the PSIHB device

Message ID 20220323072846.1780212-1-clg@kaod.org
Headers show
Series ppc/pnv: Introduce GPIO lines to drive the PSIHB device | expand

Message

Cédric Le Goater March 23, 2022, 7:28 a.m. UTC 
Hello, 

The PSIHB OCC and LPC interrupts are driven by a complex framework
using Object links and class handlers. Simplify the whole with GPIO
lines.

Thanks,

C.

Cédric Le Goater (5):
  ppc/pnv: Fix PSI IRQ definition
  ppc/pnv: Remove PnvLpcController::psi link
  ppc/pnv: Remove PnvOCC::psi link
  ppc/pnv: Remove PnvPsiClas::irq_set
  ppc/pnv: Remove usless checks in set_irq handlers

 include/hw/ppc/pnv_lpc.h |  8 ++------
 include/hw/ppc/pnv_occ.h |  7 ++-----
 include/hw/ppc/pnv_psi.h |  7 +------
 hw/ppc/pnv.c             | 30 ++++++++++++++++++------------
 hw/ppc/pnv_lpc.c         | 19 ++++---------------
 hw/ppc/pnv_occ.c         | 16 ++++------------
 hw/ppc/pnv_psi.c         | 36 +++++++++++-------------------------
 7 files changed, 42 insertions(+), 81 deletions(-)

Comments

Daniel Henrique Barboza March 24, 2022, 6:02 p.m. UTC | #1 
On 3/23/22 04:28, Cédric Le Goater wrote:
> Hello,
> 
> The PSIHB OCC and LPC interrupts are driven by a complex framework
> using Object links and class handlers. Simplify the whole with GPIO
> lines.


Series LGTM. All patches:


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>




Daniel


> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (5):
>    ppc/pnv: Fix PSI IRQ definition
>    ppc/pnv: Remove PnvLpcController::psi link
>    ppc/pnv: Remove PnvOCC::psi link
>    ppc/pnv: Remove PnvPsiClas::irq_set
>    ppc/pnv: Remove usless checks in set_irq handlers
> 
>   include/hw/ppc/pnv_lpc.h |  8 ++------
>   include/hw/ppc/pnv_occ.h |  7 ++-----
>   include/hw/ppc/pnv_psi.h |  7 +------
>   hw/ppc/pnv.c             | 30 ++++++++++++++++++------------
>   hw/ppc/pnv_lpc.c         | 19 ++++---------------
>   hw/ppc/pnv_occ.c         | 16 ++++------------
>   hw/ppc/pnv_psi.c         | 36 +++++++++++-------------------------
>   7 files changed, 42 insertions(+), 81 deletions(-)
>
Daniel Henrique Barboza April 20, 2022, 7:11 p.m. UTC | #2 
On 3/23/22 04:28, Cédric Le Goater wrote:
> Hello,
> 
> The PSIHB OCC and LPC interrupts are driven by a complex framework
> using Object links and class handlers. Simplify the whole with GPIO
> lines.
> 
> Thanks,

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

> 
> C.
> 
> Cédric Le Goater (5):
>    ppc/pnv: Fix PSI IRQ definition
>    ppc/pnv: Remove PnvLpcController::psi link
>    ppc/pnv: Remove PnvOCC::psi link
>    ppc/pnv: Remove PnvPsiClas::irq_set
>    ppc/pnv: Remove usless checks in set_irq handlers
> 
>   include/hw/ppc/pnv_lpc.h |  8 ++------
>   include/hw/ppc/pnv_occ.h |  7 ++-----
>   include/hw/ppc/pnv_psi.h |  7 +------
>   hw/ppc/pnv.c             | 30 ++++++++++++++++++------------
>   hw/ppc/pnv_lpc.c         | 19 ++++---------------
>   hw/ppc/pnv_occ.c         | 16 ++++------------
>   hw/ppc/pnv_psi.c         | 36 +++++++++++-------------------------
>   7 files changed, 42 insertions(+), 81 deletions(-)
>