mbox series

[for-7.0,0/2] block/vmdk: Fix reopening bs->file

Message ID 20220314162719.65384-1-hreitz@redhat.com
Headers show
Series block/vmdk: Fix reopening bs->file | expand

Message

Hanna Czenczek March 14, 2022, 4:27 p.m. UTC 
Hi,

A couple of months ago I noticed that changing a vmdk node’s file child
through blockdev-reopen would crash qemu.  I started writing a fix at
some point, got distracted, but now here it is.


Hanna Reitz (2):
  block/vmdk: Fix reopening bs->file
  iotests/reopen-file: Test reopening file child

 block/vmdk.c                             | 56 ++++++++++++++-
 tests/qemu-iotests/tests/reopen-file     | 88 ++++++++++++++++++++++++
 tests/qemu-iotests/tests/reopen-file.out |  5 ++
 3 files changed, 148 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/tests/reopen-file
 create mode 100644 tests/qemu-iotests/tests/reopen-file.out

Comments

Kevin Wolf May 3, 2022, 10:20 a.m. UTC | #1 
Am 14.03.2022 um 17:27 hat Hanna Reitz geschrieben:
> Hi,
> 
> A couple of months ago I noticed that changing a vmdk node’s file child
> through blockdev-reopen would crash qemu.  I started writing a fix at
> some point, got distracted, but now here it is.

Thanks, fixed up a merge conflict with 2882ccf86a9 in the test case and
applied to the block branch.

Kevin