From patchwork Tue Sep 28 03:24:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Delevoryas X-Patchwork-Id: 1533678 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.a=rsa-sha256 header.s=facebook header.b=l+K+Dz5o; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HJPzY4TZRz9t2p for ; Tue, 28 Sep 2021 13:25:59 +1000 (AEST) Received: from localhost ([::1]:37070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV3kf-0001Td-Pa for incoming@patchwork.ozlabs.org; Mon, 27 Sep 2021 23:25:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV3ju-0001TV-2T for qemu-devel@nongnu.org; Mon, 27 Sep 2021 23:25:06 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:15134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV3js-0000T6-4V for qemu-devel@nongnu.org; Mon, 27 Sep 2021 23:25:05 -0400 Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18RKsWru021388 for ; Mon, 27 Sep 2021 20:25:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=facebook; bh=IDzwezcqc/k8Z0AVHGYS0kIK4lzk5tYaKvuyBCD7JaM=; b=l+K+Dz5oQr1RyHvnpsEyWgzNsP6moJC57Nc5VlTMDd3+BZmlsXHVh8NI21HszvAN4Kpu wbHO6PUtSaXS5ZyX4CL/Ap7MFRaZa/Aib45GXAwSxdnZdQoStMIhoBgsJWqxx6rSUGeP 5DJrcxAqBOcQbq+nKX9NXpemHN22/+x8Rcs= Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com with ESMTP id 3bbe8swkce-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 27 Sep 2021 20:25:00 -0700 Received: from intmgw002.48.prn1.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:21d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Mon, 27 Sep 2021 20:24:59 -0700 Received: by devvm660.prn0.facebook.com (Postfix, from userid 385188) id EB2CA43602F9; Mon, 27 Sep 2021 20:24:57 -0700 (PDT) From: To: CC: , , , , , , Peter Delevoryas Subject: [PATCH 0/1] hw: aspeed_gpio: Fix pin I/O type declarations Date: Mon, 27 Sep 2021 20:24:55 -0700 Message-ID: <20210928032456.3192603-1-pdel@fb.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-FB-Internal: Safe X-FB-Source: Intern X-Proofpoint-GUID: acOT3loIfnLMq72D6RvMNZzmU1mj04Os X-Proofpoint-ORIG-GUID: acOT3loIfnLMq72D6RvMNZzmU1mj04Os X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-27_07,2021-09-24_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=456 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109280023 X-FB-Internal: deliver Received-SPF: pass client-ip=67.231.145.42; envelope-from=prvs=8905f295c3=pdel@fb.com; helo=mx0a-00082601.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Peter Delevoryas In the Aspeed chips, the GPIO pins are mostly labeled in groups of 8, but some of the groups only have 4 elements. Also, most pins have input and output capabilities, but some are strictly input or strictly output pins. We have some arrays that describe the I/O capabilities of each pin for each chip. A few of the declarations for the AST2500 and AST2600 in aspeed_gpio.c don't seem to match the datasheet, probably because of confusion over the association between big-endian uint32 literals (right-to-left) and the array of group labels (left-to-right). I checked the AST2400 too, but it was correct and didn't need any changes. We might want to consider replacing the u32's with u8's and putting them together into a u32 programmatically, or perhaps implicitly performing a big-endian to little-endian conversion, something to make it easier to read. Peter Delevoryas (1): hw: aspeed_gpio: Fix pin I/O type declarations hw/gpio/aspeed_gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)