From patchwork Fri Sep 3 17:00:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Tomsich X-Patchwork-Id: 1524450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=vrull-eu.20150623.gappssmtp.com header.i=@vrull-eu.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=Zj4/Jen5; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H1PHD4JDvz9sR4 for ; Sat, 4 Sep 2021 03:02:32 +1000 (AEST) Received: from localhost ([::1]:34068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMCaC-0007Jx-C8 for incoming@patchwork.ozlabs.org; Fri, 03 Sep 2021 13:02:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMCYy-0007Gb-7T for qemu-devel@nongnu.org; Fri, 03 Sep 2021 13:01:12 -0400 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:35700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMCYv-0004yK-8k for qemu-devel@nongnu.org; Fri, 03 Sep 2021 13:01:11 -0400 Received: by mail-lf1-x12f.google.com with SMTP id k13so13015312lfv.2 for ; Fri, 03 Sep 2021 10:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j+eo2a3+3myLnHE4B8I++F5ynYQrK1PPLcRLgdMmulw=; b=Zj4/Jen5HC3yz0fzSqNBs+bkgxd/PzGd89EU9c4WlgMJUrzluDP7BluxgL32aNGmBm bGRnkT7wY6Z7rprSosvMUqX07w5MRtLvs+wKlQoiGSCjNHX/MzuqX6k66H2aJ/k8vqAa j7WwFYfmGbXDl/BH68HrZ7H5SCnHXZBECSL7+bGowvwiDplDNi0kfjo5b7XNiETEyrRU RApMmdkyn3szIOBdQ7A72fVyIsadpMDSso0sw4eYxrKlqKVxndxUgf53TzDVwkGmI/O8 x2XEH0xjwDTE2fUJyJOV3n9v3G+6vJG+IdPU6rzLTkZg+oY9zSMwl6Q5QoAT6b1i/6nt zVdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j+eo2a3+3myLnHE4B8I++F5ynYQrK1PPLcRLgdMmulw=; b=HWAvAqZ1NTl4J/9l+PLELUM1HSuMMbvM2DHpCrM+nDVUIVNn1ERbsIG2TyDcPrtfW3 +E2Zx9k0Byo7LS1swFmtAb97CrrFcbDfvUpUX4nRyHTaJAb0Y6vv4jsoQA7LBo2/pOlo /7rFOUsLtxzgYNSNt6pnDVTbaBDaHxKoFV88DMl/PteKEBmz/y+Bi7b29yX1CEPHE6Xx ygNTshFrPQCv6rICfGxZB1b2+5dUlcWE/ZyTGJUVpqMmRRkZ1n1My9IG16J+0s3xXi2a SnlJmqnmbANGspEle/Ffv3zwX1k9CIfRz76uIK6G8kvC/dwx53xlLZzgt6zZq1I3atzz febQ== X-Gm-Message-State: AOAM532+5BkkKe+OoGNlkf32g99DymSXrD79pGnx8xi4R/urzV1II4Z9 99ZLdD3jQNBTwYjmoQoE560H8lWLIcK6dWzrxb8= X-Google-Smtp-Source: ABdhPJwOReYUF/28Ux4ABWeJ7xi8Alsb0M1BPpVXVkEpcqf4Ir4BbhQwT3VTAzeLrVUbePO3LuEF6A== X-Received: by 2002:a05:6512:a8f:: with SMTP id m15mr3377750lfu.635.1630688464961; Fri, 03 Sep 2021 10:01:04 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:3a:1e26::2]) by smtp.gmail.com with ESMTPSA id c3sm628401ljj.77.2021.09.03.10.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 10:01:04 -0700 (PDT) From: Philipp Tomsich To: qemu-devel@nongnu.org Subject: [PATCH v9 00/14] target/riscv: Update QEmu for Zb[abcs] 1.0.0 Date: Fri, 3 Sep 2021 19:00:46 +0200 Message-Id: <20210903170100.2529121-1-philipp.tomsich@vrull.eu> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::12f; envelope-from=philipp.tomsich@vrull.eu; helo=mail-lf1-x12f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Kito Cheng , Alistair Francis , Philipp Tomsich Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The Zb[abcs] extensions have complete public review and are nearing ratifications. These individual extensions are one part of what was previously though of as the "BitManip" (B) extension, leaving the final details of future Zb* extensions open as they will undergo further public discourse. This series updates the earlier support for the B extension by - removing those instructions that are not included in Zb[abcs] - splitting this into 4 separate extensions that can be independently enabled: Zba (addressing), Zbb (basic bit-manip), Zbc (carryless multiplication), Zbs (single-bit operations) - update the to the 1.0.0 version (e.g. w-forms of rev8 and Zbs instructions are not included in Zb[abcs]) For the latest version of the public review speicifcaiton (incorporating some editorial fixes and corrections from the review period), refer to: https://github.com/riscv/riscv-bitmanip/releases/download/1.0.0/bitmanip-1.0.0-31-g2af7256.pdf Changes in v9: - Retested with CF3 and SPEC2017 (size=test only). - Rebased to 8880cc4362. - Update gen_add_uw() to use a temporary instead of messing with arg1 (fixes a regression after rebase on CF3 and SPEC2017). - Rebased to 8880cc4362. - Rebased to 8880cc4362. - Picked up Alistair's Reviewed-by, after patman had failed to catch it for v8. - Rebased to 8880cc4362. - Fixes a whitespace-at-the-end-of-line warning for the rev8 comment in insn32.decode - Rebased to 8880cc4362. Changes in v8: - Optimize orc.b further by reordering the shift/and, updating the comment to reflect that we put the truth-value into the LSB, and putting the (now only) constant in a temporary - Fold the final bitwise-not into the second and, using and andc. Changes in v7: - Free TCG temporary in gen_orc_b(). Changes in v6: - Move gen_clmulh to trans_rvb.c.inc, as per Richard H's request. - Fixed orc.b (now passes SPEC w/ optimized string functions) by adding the missing final negation. Changes in v5: - Introduce gen_clmulh (as suggested by Richard H) and use to simplify trans_clmulh(). Changes in v4: - Drop rewrite of slli.uw (to match formal specification), as it would remove an optimization. - Change orc.b to implementation suggested by Richard Henderson - reorder trans_rev8* functions to be sequential - rename rev8 to rev8_32 in decoder - Renamed RV32 variant to zext_h_32. - Reordered trans_zext_h_{32,64} to be next to each other. Changes in v3: - Split off removal of 'x-b' property and 'ext_b' field into a separate patch to ensure bisectability. - The changes to the Zba instructions (i.e. the REQUIRE_ZBA macro and its use for qualifying the Zba instructions) are moved into a separate commit. - Instead of defining a new decoding format, we treat slli.uw as if it had a 7bit-wide field for shamt (the 7th bit is reserved for RV128) and check for validity of the encoding in C code. - Remove the W-form instructions from Zbs in a separate commit. - Remove shift-one instructions in a separate commit. - The changes to the Zbs instructions (i.e. the REQUIRE_ZBS macro) and its use for qualifying the Zba instructions) are moved into a separate commit. - This adds the Zbc instructions as a spearate commit. - Uses a helper for clmul/clmulr instead of inlining the calculation of the result (addressing a comment from Richard Henderson). - The changes to the Zbb instructions (i.e. use the REQUIRE_ZBB macro) are now in a separate commit. - Moved orc.b and gorc/gorci changes into separate commit. - Using the simpler orc.b implementation suggested by Richard Henderson - Moved the REQUIRE_32BIT macro into a separate commit. - rev8-addition & grevi*-removal moved to a separate commit - Moved zext.h-addition & pack*-removal to a separate commit. - Removing RVB moved into a separate commit at the tail-end of the series. Changes in v2: - Fix missing ';' from last-minute whitespace cleanups. Philipp Tomsich (14): target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties target/riscv: Reassign instructions to the Zba-extension target/riscv: slli.uw is only a valid encoding if shamt first in 64 bits target/riscv: Remove the W-form instructions from Zbs target/riscv: Remove shift-one instructions (proposed Zbo in pre-0.93 draft-B) target/riscv: Reassign instructions to the Zbs-extension target/riscv: Add instructions of the Zbc-extension target/riscv: Reassign instructions to the Zbb-extension target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci target/riscv: Add a REQUIRE_32BIT macro target/riscv: Add rev8 instruction, removing grev/grevi target/riscv: Add zext.h instructions to Zbb, removing pack/packu/packh target/riscv: Remove RVB (replaced by Zb[abcs] disas/riscv: Add Zb[abcs] instructions disas/riscv.c | 157 ++++++++- target/riscv/bitmanip_helper.c | 65 +--- target/riscv/cpu.c | 30 +- target/riscv/cpu.h | 7 +- target/riscv/helper.h | 6 +- target/riscv/insn32.decode | 115 +++---- target/riscv/insn_trans/trans_rvb.c.inc | 421 ++++++++---------------- target/riscv/translate.c | 6 + 8 files changed, 371 insertions(+), 436 deletions(-)