From patchwork Wed Sep 1 22:59:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Delevoryas X-Patchwork-Id: 1523433 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.a=rsa-sha256 header.s=facebook header.b=dw0A+5kF; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H0KL66Xcwz9sRN for ; Thu, 2 Sep 2021 09:01:18 +1000 (AEST) Received: from localhost ([::1]:59398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLZEJ-0007y7-Mx for incoming@patchwork.ozlabs.org; Wed, 01 Sep 2021 19:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLZD3-0007KT-IY for qemu-devel@nongnu.org; Wed, 01 Sep 2021 18:59:57 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:15890 helo=mx0a-00082601.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLZD0-0001jS-EH for qemu-devel@nongnu.org; Wed, 01 Sep 2021 18:59:57 -0400 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.43/8.16.0.43) with SMTP id 181Mw535003151 for ; Wed, 1 Sep 2021 15:59:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=vLpQSiv1KX3TInMV87Lqn+ph2VhFme0+494mZrhJA1A=; b=dw0A+5kFeWr9bD4Fp3DFODbPgFHzNSaUyJPkCrzkl2oIYea/JE+EKjnfVzeMkzWCwkKl gv0f5WdeGsntKsrxjM46y3bRpv+rdeIsAuDHQUD7/lDiXn1OCg17GOMxMIaydEpwFUaD 9EyXxOdUf1D7Oz07sLRKZgradVRoMHC9VzQ= Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net with ESMTP id 3atdyh4nb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 01 Sep 2021 15:59:52 -0700 Received: from intmgw002.46.prn1.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 1 Sep 2021 15:59:51 -0700 Received: by devvm660.prn0.facebook.com (Postfix, from userid 385188) id 744C317DA286; Wed, 1 Sep 2021 15:59:47 -0700 (PDT) From: To: CC: , , , , , , , , Peter Delevoryas Subject: [PATCH 0/1] hw/arm/aspeed: Add Fuji machine type Date: Wed, 1 Sep 2021 15:59:45 -0700 Message-ID: <20210901225946.500125-1-pdel@fb.com> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe X-FB-Source: Intern X-Proofpoint-GUID: 2zaa-1h6_duz_P3a9ebzpOdQRYjG5VMg X-Proofpoint-ORIG-GUID: 2zaa-1h6_duz_P3a9ebzpOdQRYjG5VMg X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-09-01_05:2021-09-01, 2021-09-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109010135 X-FB-Internal: deliver Received-SPF: pass client-ip=67.231.153.30; envelope-from=prvs=8878769573=pdel@fb.com; helo=mx0a-00082601.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Peter Delevoryas Adding a new Aspeed AST2600 machine type, uses MAC3 for ethernet1 and UART1 for the serial console, which is different than the existing ast2600-evb. Otherwise though, my usage so far hasn't required a different set of hardware strap registers or anything, so I just inherited the rest of the configuration from the ast2600-evb. If preferred, I can eliminate the inheritance and just declare Fuji completely independently. I included more info in the commit message, but just for convenience, here's the DTS link and a link to an image I'm providing for the acceptance test. https://github.com/facebook/openbmc-uboot/blob/openbmc/helium/v2019.04/arch/arm/dts/aspeed-bmc-facebook-fuji.dts https://github.com/peterdelevoryas/openbmc/releases/download/fuji-v0.1-alpha/fuji.mtd I'm not sure exactly what the requirements are on the image url provided, or the requirements of the image itself. The existing OpenBMC acceptance tests mostly use images from the Linux Foundation repository's releases, e.g. https://github.com/openbmc/openbmc/releases/download/2.9.0/obmc-phosphor-image-romulus.static.mtd Although, I do see one image from a regular user's repo: https://github.com/hskinnemoen/openbmc/releases/download/20200711-gsj-qemu-0/obmc-phosphor-image-gsj.static.mtd.gz So maybe it's not that unreasonable? I also might be able to organize a release link on the official Facebook OpenBMC Github. As far as the actual requirements of the acceptance test, I didn't use the existing "do_test_arm_aspeed" because Fuji was sufficiently different (different U-Boot version, kernel address, CPU, SPI control register, doesn't use systemd), but I could try unifying them if there's interest or suggestions on how to do so. By the way, Fuji takes a long time to boot on my Macbook: (19/38) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_ast2600_fuji_openbmc: PASS (85.13 s) The next longest boot time is <20 seconds: 17/38) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_ast2500_romulus_openbmc_v2_9_0: PASS (17.46 s) Not sure if that's a problem for the CIT infra time or not. Thanks, Peter Peter Delevoryas (1): hw/arm/aspeed: Add Fuji machine type hw/arm/aspeed.c | 14 ++++++++++++++ tests/acceptance/boot_linux_console.py | 25 +++++++++++++++++++++++++ 2 files changed, 39 insertions(+)