mbox series

[v3,0/2] hw/nvme: namespace parameter for EUI-64

Message ID 20210614201901.17871-1-xypron.glpk@gmx.de
Headers show
Series hw/nvme: namespace parameter for EUI-64 | expand

Message

Heinrich Schuchardt June 14, 2021, 8:18 p.m. UTC 
The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
paths. Add a new namespace property "eui64", that provides the user the
option to specify the EUI-64.

v3:
	use 52-54-00-00-00-00-00-00 as starting values for generating
	EUI-64s

Heinrich Schuchardt (2):
  hw/nvme: namespace parameter for EUI-64
  hw/nvme: default for namespace EUI-64

 docs/system/nvme.rst |  6 +++++
 hw/core/machine.c    |  1 +
 hw/nvme/ctrl.c       | 58 ++++++++++++++++++++++++++------------------
 hw/nvme/ns.c         | 11 +++++++++
 hw/nvme/nvme.h       |  3 +++
 5 files changed, 56 insertions(+), 23 deletions(-)

--
2.30.2

Comments

Klaus Jensen June 16, 2021, 10:22 a.m. UTC | #1 
On Jun 14 22:18, Heinrich Schuchardt wrote:
>The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
>paths. Add a new namespace property "eui64", that provides the user the
>option to specify the EUI-64.
>
>v3:
>	use 52-54-00-00-00-00-00-00 as starting values for generating
>	EUI-64s
>
>Heinrich Schuchardt (2):
>  hw/nvme: namespace parameter for EUI-64
>  hw/nvme: default for namespace EUI-64
>
> docs/system/nvme.rst |  6 +++++
> hw/core/machine.c    |  1 +
> hw/nvme/ctrl.c       | 58 ++++++++++++++++++++++++++------------------
> hw/nvme/ns.c         | 11 +++++++++
> hw/nvme/nvme.h       |  3 +++
> 5 files changed, 56 insertions(+), 23 deletions(-)
>
>--
>2.30.2
>

LGTM.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Klaus Jensen June 28, 2021, 5:06 p.m. UTC | #2 
On Jun 14 22:18, Heinrich Schuchardt wrote:
>The EUI-64 field is the only identifier for NVMe namespaces in UEFI device
>paths. Add a new namespace property "eui64", that provides the user the
>option to specify the EUI-64.
>
>v3:
>	use 52-54-00-00-00-00-00-00 as starting values for generating
>	EUI-64s
>
>Heinrich Schuchardt (2):
>  hw/nvme: namespace parameter for EUI-64
>  hw/nvme: default for namespace EUI-64
>
> docs/system/nvme.rst |  6 +++++
> hw/core/machine.c    |  1 +
> hw/nvme/ctrl.c       | 58 ++++++++++++++++++++++++++------------------
> hw/nvme/ns.c         | 11 +++++++++
> hw/nvme/nvme.h       |  3 +++
> 5 files changed, 56 insertions(+), 23 deletions(-)
>
>--
>2.30.2
>

Applied to nvme-next. Thanks!