From patchwork Thu Apr 22 13:58:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Jensen X-Patchwork-Id: 1469229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=irrelevant.dk header.i=@irrelevant.dk header.a=rsa-sha256 header.s=fm2 header.b=cl6XhA7b; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=JUaVP9gB; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FQzZc3vsKz9sV5 for ; Fri, 23 Apr 2021 00:00:07 +1000 (AEST) Received: from localhost ([::1]:48566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZZsD-0004qq-Cm for incoming@patchwork.ozlabs.org; Thu, 22 Apr 2021 10:00:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZZqv-0004mV-02; Thu, 22 Apr 2021 09:58:45 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:47213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZZqs-0007Wy-Jj; Thu, 22 Apr 2021 09:58:44 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6B04D135F; Thu, 22 Apr 2021 09:58:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 22 Apr 2021 09:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:content-type:mime-version :content-transfer-encoding; s=fm2; bh=4dJXjhp3TsgwSUQDlmLqT9g8z6 iZYZqG3l0s2JmLyeg=; b=cl6XhA7bzdVprcDR4xt4zqs3MoKB1dnIkkS09l0nGK B5kVK4z03Vu7hr9kShcr5i1+LKJVw40aGHa8a8h6/pN/YOSgtzC2xQYhcTeqPVkQ qlZRqi8FwbamVrqdFwD4J5X5ORIgTKt63HEdxd3e1PGpIiF96beJdcOYisIyELHr PbtR/jcMlD+3pSOxIHu6l9qCcpS1xt1aJyvkGtRqzSpvAKBiZNadANMlfybPUYOf MjW3YK7V8xnMSQIrRCkrHvwrzvQUsTrKR2tlKf0E6gOJex5VYKfktZpFwLg2iHgM dgGUTLHPMe3/HbF4BgnuBp44qJvF0gxLDhInHXY6RlRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4dJXjh p3TsgwSUQDlmLqT9g8z6iZYZqG3l0s2JmLyeg=; b=JUaVP9gBnURDGoE/HEe9Z2 k7pPh4MyVvHdo4BB9umAAArnEJGsUDrLUf4DPxQ2dqziKbkyzvr209Zuan7C/dPA fmZ7NmvHA1aCpf0rCHDyj6tVskmNB1ABY0YEW6BZUsaAaYPHYKM/LHOFbEbkH84S kyIB44mvnP5FmseLtngE3/CkQLXLWoMmtesbdnzUHtDthDRu287BRopSHCyH5Rhq sxx2f+aHzesggneMqVs3pnkKl46Nbdw8aOduj5lpis7LaiB3nvQtGVYmhxQ0n+Aj YvO7gda/zcPP4siTvhHN6hPk69ILAi3i9SjjStxXtOyUz9Dhz2ihZ2wvMQsm9CmQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddutddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffotggggfesthhqredtredtjeenucfhrhhomhepmfhlrghushcu lfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvg hrnhephfegveekiefgkeevvdetjeejkeekudfgvdehieejfffgkeffvdevlefftedvgefh necukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id A649A108005F; Thu, 22 Apr 2021 09:58:36 -0400 (EDT) From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Subject: [PATCH for-6.0? 0/1] hw/block/nvme: fix msix uninit Date: Thu, 22 Apr 2021 15:58:33 +0200 Message-Id: <20210422135834.406688-1-its@irrelevant.dk> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Received-SPF: pass client-ip=64.147.123.19; envelope-from=its@irrelevant.dk; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Klaus Jensen , Keith Busch Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Klaus Jensen Hi Peter, The commit message on the patch describes the issue. This is a QEMU crashing bug in -rc4 that I introduced early in the cycle and never found in time. Lack of testing device hotplugging is the cause for that. I'm not sure what to say other than I'm terribly sorry for introducing this and if this means an -rc5 needs to be rolled, then I'm even more sorry. I think an acceptance test could have caught this, and I am already working on an acceptance test suite for the nvme device, so I'll add something that test this as well. But, well, it doesn't help now. Klaus Jensen (1): hw/block/nvme: fix invalid msix exclusive uninit hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)