From patchwork Tue Apr 13 08:07:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "wangyanan (Y)" X-Patchwork-Id: 1465590 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FKJCL0klvz9sVw for ; Tue, 13 Apr 2021 18:08:46 +1000 (AEST) Received: from localhost ([::1]:60560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWE6G-0004K8-5B for incoming@patchwork.ozlabs.org; Tue, 13 Apr 2021 04:08:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWE5l-00047l-QJ; Tue, 13 Apr 2021 04:08:13 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:5031) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWE5h-0006Qf-Eh; Tue, 13 Apr 2021 04:08:13 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FKJ8H2BXBzlXcD; Tue, 13 Apr 2021 16:06:07 +0800 (CST) Received: from DESKTOP-TMVL5KK.china.huawei.com (10.174.187.128) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Tue, 13 Apr 2021 16:07:48 +0800 From: Yanan Wang To: , Subject: [RFC PATCH v2 0/6] hw/arm/virt: Introduce cpu topology support Date: Tue, 13 Apr 2021 16:07:39 +0800 Message-ID: <20210413080745.33004-1-wangyanan55@huawei.com> X-Mailer: git-send-email 2.8.4.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.187.128] X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.32; envelope-from=wangyanan55@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , "Michael S . Tsirkin" , wanghaibin.wang@huawei.com, Yanan Wang , Shannon Zhao , Alistair Francis , prime.zeng@hisilicon.com, yangyicong@huawei.com, yuzenghui@huawei.com, Igor Mammedov , zhukeqian1@huawei.com, Jiajie Li , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, This series is a new version of [0] recently posted by Ying Fang to introduce cpu topology support for ARM platform. I have taken over his work about this now, thanks for his contribution. Description: An accurate cpu topology may help improve the cpu scheduler's decision making when dealing with multi-core system. So cpu topology description is helpful to provide guest with the right view. Dario Faggioli's talk in [1] also shows the virtual topology could have impact on scheduling performace. Thus this patch series introduces cpu topology support for ARM platform. This series originally comes from Andrew Jones's patches [2], but with some re-arrangement. Thanks for Andrew's contribution. In this series, both fdt and ACPI PPTT table are introduced to present cpu topology to the guest. And a new function virt_smp_parse() not like the default smp_parse() is introduced, which prefers cores over sockets. [0] https://patchwork.kernel.org/project/qemu-devel/cover/20210225085627.2263-1-fangying1@huawei.com/ [1] https://kvmforum2020.sched.com/event/eE1y/virtual-topology-for-virtual-machines-friend-or-foe-dario-faggioli-suse [2] https://github.com/rhdrjones/qemu/commit/ecfc1565f22187d2c715a99bbcd35cf3a7e428fa Test results: After applying this patch series, launch a guest with virt-6.0 and cpu topology configured with: -smp 96,sockets=2,clusters=6,cores=4,threads=2, VM's cpu topology description shows as below. Architecture: aarch64 Byte Order: Little Endian CPU(s): 96 On-line CPU(s) list: 0-95 Thread(s) per core: 2 Core(s) per socket: 24 Socket(s): 2 NUMA node(s): 1 Vendor ID: 0x48 Model: 0 Stepping: 0x1 BogoMIPS: 200.00 NUMA node0 CPU(s): 0-95 --- Changelogs: v1->v2: - Address Andrew Jones's comments - Address Michael S. Tsirkin's comments - Pick up one more patch(patch#6) of Andrew Jones - Rebased on v6.0.0-rc2 release --- Andrew Jones (3): device_tree: Add qemu_fdt_add_path hw/arm/virt: DT: Add cpu-map hw/arm/virt: Replace smp_parse with one that prefers cores Yanan Wang (2): hw/acpi/aml-build: Add processor hierarchy node structure hw/arm/virt-acpi-build: Add PPTT table Ying Fang (1): hw/arm/virt-acpi-build: Distinguish possible and present cpus hw/acpi/aml-build.c | 27 ++++++++ hw/arm/virt-acpi-build.c | 77 ++++++++++++++++++++-- hw/arm/virt.c | 120 ++++++++++++++++++++++++++++++++++- include/hw/acpi/aml-build.h | 4 ++ include/hw/arm/virt.h | 1 + include/sysemu/device_tree.h | 1 + softmmu/device_tree.c | 45 ++++++++++++- 7 files changed, 268 insertions(+), 7 deletions(-)