| Message ID | 20210210160937.1100-1-minwoo.im.dev@gmail.com |
|---|---|
| Headers | show |
| Series | hw/block/nvme: support namespace attachment | expand |
On Feb 11 01:09, Minwoo Im wrote: > Hello, > > This series supports namespace attachment: attach and detach. This is > the second version series with a fix a bug on choosing a controller to > attach for a namespace in the attach command handler. > > Since V1: > - Fix to take 'ctrl' which is given from the command rather than 'n'. > (Klaus) > - Add a [7/7] patch to support CNS 12h Identify command (Namespace > Attached Controller list). > Good stuff Minwoo! For the lot, Tested-by: Klaus Jensen <k.jensen@samsung.com> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
On 21-02-11 01:09:30, Minwoo Im wrote: > Hello, > > This series supports namespace attachment: attach and detach. This is > the second version series with a fix a bug on choosing a controller to > attach for a namespace in the attach command handler. Keith, Could you please have a look at this series and give some comments :) ?
Hello, This series supports namespace attachment: attach and detach. This is the second version series with a fix a bug on choosing a controller to attach for a namespace in the attach command handler. Since V1: - Fix to take 'ctrl' which is given from the command rather than 'n'. (Klaus) - Add a [7/7] patch to support CNS 12h Identify command (Namespace Attached Controller list). This series has been tested with the following: (!CONFIG_NVME_MULTIPATH) -device nvme-subsys,id=subsys0 \ -device nvme,serial=foo,id=nvme0,subsys=subsys0 \ -device nvme,serial=bar,id=nvme1,subsys=subsys0 \ -device nvme-ns,id=ns1,drive=drv0,nsid=1,subsys=subsys0,zoned=false \ -device nvme-ns,id=ns2,drive=drv1,nsid=2,subsys=subsys0,zoned=true \ -device nvme-ns,id=ns3,drive=drv2,nsid=3,subsys=subsys0,detached=true,zoned=false \ -device nvme-ns,id=ns4,drive=drv3,nsid=4,subsys=subsys0,detached=true,zoned=true \ root@vm:~/work# nvme list Node SN Model Namespace Usage Format FW Rev --------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- -------- /dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 root@vm:~/work# nvme attach-ns /dev/nvme0 --namespace-id=3 --controllers=0,1 attach-ns: Success, nsid:3 root@vm:~/work# echo 1 > /sys/class/nvme/nvme0/rescan_controller root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller root@vm:~/work# nvme list Node SN Model Namespace Usage Format FW Rev --------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- -------- /dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n3 foo QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0 root@vm:~/work# nvme detach-ns /dev/nvme0 --namespace-id=3 --controllers=0 detach-ns: Success, nsid:3 root@vm:~/work# echo 1 > /sys/class/nvme/nvme0/rescan_controller root@vm:~/work# nvme list Node SN Model Namespace Usage Format FW Rev --------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- -------- /dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0 root@vm:~/work# nvme detach-ns /dev/nvme0 --namespace-id=1 --controllers=1 detach-ns: Success, nsid:1 root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller root@vm:~/work# nvme list Node SN Model Namespace Usage Format FW Rev --------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- -------- /dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0 root@vm:~/work# nvme attach-ns /dev/nvme0 --namespace-id=1 --controllers=1 attach-ns: Success, nsid:1 root@vm:~/work# echo 1 > /sys/class/nvme/nvme1/rescan_controller root@vm:~/work# nvme list Node SN Model Namespace Usage Format FW Rev --------------------- -------------------- ---------------------------------------- --------- -------------------------- ---------------- -------- /dev/nvme0n1 foo QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme0n2 foo QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n1 bar QEMU NVMe Ctrl 1 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n2 bar QEMU NVMe Ctrl 2 268.44 MB / 268.44 MB 512 B + 0 B 1.0 /dev/nvme1n3 bar QEMU NVMe Ctrl 3 268.44 MB / 268.44 MB 512 B + 0 B 1.0 Minwoo Im (7): hw/block/nvme: support namespace detach hw/block/nvme: fix namespaces array to 1-based hw/block/nvme: fix allocated namespace list to 256 hw/block/nvme: support allocated namespace type hw/block/nvme: refactor nvme_select_ns_iocs hw/block/nvme: support namespace attachment command hw/block/nvme: support Identify NS Attached Controller List hw/block/nvme-ns.c | 1 + hw/block/nvme-ns.h | 1 + hw/block/nvme-subsys.h | 28 ++++- hw/block/nvme.c | 241 +++++++++++++++++++++++++++++++++++------ hw/block/nvme.h | 33 ++++++ hw/block/trace-events | 3 + include/block/nvme.h | 6 + 7 files changed, 278 insertions(+), 35 deletions(-)