mbox series

[v2,0/2] s390x: pv: Diag318 fixes

Message ID 20201022103135.126033-1-frankja@linux.ibm.com
Headers show
Series s390x: pv: Diag318 fixes | expand

Message

Janosch Frank Oct. 22, 2020, 10:31 a.m. UTC
Here are two fixes for the diag318 support that fix crashes when
booting PV guests.

We're working on extending our testing to catch problems like these
earlier.


Branch:
https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes

CI:
https://gitlab.com/frankja/qemu/-/pipelines/206174979


V2:
	* Moved fencing nto cpu model functions
	* Added rev-by and acks


Janosch Frank (2):
  s390x: pv: Remove sclp boundary checks
  s390x: pv: Fix diag318 PV fencing

 hw/s390x/sclp.c             | 5 -----
 target/s390x/cpu_features.c | 5 +++++
 target/s390x/cpu_features.h | 4 ++++
 target/s390x/cpu_models.c   | 4 ++++
 target/s390x/kvm.c          | 3 +--
 5 files changed, 14 insertions(+), 7 deletions(-)

Comments

Collin Walling Oct. 22, 2020, 12:50 p.m. UTC | #1
On 10/22/20 6:31 AM, Janosch Frank wrote:
> Here are two fixes for the diag318 support that fix crashes when
> booting PV guests.
> 
> We're working on extending our testing to catch problems like these
> earlier.
> 
> 
> Branch:
> https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes
> 
> CI:
> https://gitlab.com/frankja/qemu/-/pipelines/206174979
> 
> 
> V2:
> 	* Moved fencing nto cpu model functions
> 	* Added rev-by and acks
> 
> 
> Janosch Frank (2):
>   s390x: pv: Remove sclp boundary checks
>   s390x: pv: Fix diag318 PV fencing
> 
>  hw/s390x/sclp.c             | 5 -----
>  target/s390x/cpu_features.c | 5 +++++
>  target/s390x/cpu_features.h | 4 ++++
>  target/s390x/cpu_models.c   | 4 ++++
>  target/s390x/kvm.c          | 3 +--
>  5 files changed, 14 insertions(+), 7 deletions(-)
> 

Thanks for correcting this. You've certainly received plenty of reviews
and ack's, but since this touches code I worked on:

Reviewed-by: Collin Walling <walling@linux.ibm.com>
Cornelia Huck Oct. 22, 2020, 2:06 p.m. UTC | #2
On Thu, 22 Oct 2020 06:31:33 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:

> Here are two fixes for the diag318 support that fix crashes when
> booting PV guests.
> 
> We're working on extending our testing to catch problems like these
> earlier.
> 
> 
> Branch:
> https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes
> 
> CI:
> https://gitlab.com/frankja/qemu/-/pipelines/206174979
> 
> 
> V2:
> 	* Moved fencing nto cpu model functions
> 	* Added rev-by and acks
> 
> 
> Janosch Frank (2):
>   s390x: pv: Remove sclp boundary checks
>   s390x: pv: Fix diag318 PV fencing
> 
>  hw/s390x/sclp.c             | 5 -----
>  target/s390x/cpu_features.c | 5 +++++
>  target/s390x/cpu_features.h | 4 ++++
>  target/s390x/cpu_models.c   | 4 ++++
>  target/s390x/kvm.c          | 3 +--
>  5 files changed, 14 insertions(+), 7 deletions(-)
> 

Thanks, applied.