Message ID | 20190927062302.110144-1-ysato@users.sourceforge.jp |
---|---|
Headers | show |
Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190927062302.110144-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190927062302.110144-1-ysato@users.sourceforge.jp Subject: [PATCH v25 00/22] Add RX archtecture support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 24f4d54 qapi/machine.json: Add RX cpu. 7e3e17f BootLinuxConsoleTest: Test the RX-Virt machine f538fda Add rx-softmmu 19f514a hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 5affaad hw/rx: Honor -accel qtest 67d2351 hw/rx: RX Target hardware definition 40c88de hw/char: RX62N serial communication interface (SCI) f8431df hw/timer: RX62N internal timer modules 61a6575 hw/intc: RX62N interrupt controller (ICUa) b85f52d target/rx: Dump bytes for each insn during disassembly c102045 target/rx: Collect all bytes during disassembly f3a06c1 target/rx: Emit all disassembly in one prt() 05337bc target/rx: Use prt_ldmi for XCHG_mr disassembly 75895d5 target/rx: Replace operand with prt_ldmi in disassembler df09e83 target/rx: Disassemble rx_index_addr into a string 6887bf3 target/rx: RX disassembler 74e5bd0 target/rx: CPU definition 218b3d5 target/rx: TCG helper 08e90ec target/rx: TCG translation cff8b93 hw/registerfields.h: Add 8bit and 16bit register macros d88c506 qemu/bitops.h: Add extract8 and extract16 a243be5 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit a243be54034c (MAINTAINERS: Add RX) 2/22 Checking commit d88c5062c822 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit cff8b93d1631 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 08e90ec1e2ff (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 218b3d519342 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 74e5bd0dacd9 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 6887bf307e62 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit df09e8393b92 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 75895d54bad7 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 05337bccb7bf (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit f3a06c13caa6 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit c102045097dc (target/rx: Collect all bytes during disassembly) 13/22 Checking commit b85f52d3b01d (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 61a65750d4a8 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit f8431dfbfd31 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 40c88deed08d (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 67d235169cd2 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 5affaad35b6e (hw/rx: Honor -accel qtest) 19/22 Checking commit 19f514a11b89 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit f538fda2b988 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 7e3e17fec46a (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 24f4d547b80e (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190927062302.110144-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190927062302.110144-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190927062302.110144-1-ysato@users.sourceforge.jp Subject: [PATCH v25 00/22] Add RX archtecture support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 1a74ffc qapi/machine.json: Add RX cpu. c173e68 BootLinuxConsoleTest: Test the RX-Virt machine b4e9a7a Add rx-softmmu 5bdc07e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 2496aa4 hw/rx: Honor -accel qtest b97a84d hw/rx: RX Target hardware definition f806e27 hw/char: RX62N serial communication interface (SCI) bd59212 hw/timer: RX62N internal timer modules cb22efa hw/intc: RX62N interrupt controller (ICUa) ae43531 target/rx: Dump bytes for each insn during disassembly 26dd1a2 target/rx: Collect all bytes during disassembly 18aeea2 target/rx: Emit all disassembly in one prt() 17d9d21 target/rx: Use prt_ldmi for XCHG_mr disassembly 2882571 target/rx: Replace operand with prt_ldmi in disassembler bf3b3f2 target/rx: Disassemble rx_index_addr into a string 73102ce target/rx: RX disassembler 90cb197 target/rx: CPU definition 5c00dbb target/rx: TCG helper 2b15272 target/rx: TCG translation 15f28f1 hw/registerfields.h: Add 8bit and 16bit register macros fa571c7 qemu/bitops.h: Add extract8 and extract16 15bf923 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 15bf92348a56 (MAINTAINERS: Add RX) 2/22 Checking commit fa571c7ef6af (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 15f28f1299de (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 2b1527203652 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 5c00dbb5e309 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 90cb19738c00 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 73102ce10f6a (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit bf3b3f236e0b (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 2882571a240d (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 17d9d217fe49 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 18aeea285a8b (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 26dd1a2ced54 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit ae43531ca84d (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit cb22efa8a743 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit bd592129660e (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit f806e2744e16 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit b97a84d22e8e (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 2496aa433eca (hw/rx: Honor -accel qtest) 19/22 Checking commit 5bdc07e394ef (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit b4e9a7ab9c9e (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit c173e68e70b7 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 1a74ffc35710 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190927062302.110144-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190927062302.110144-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190927062302.110144-1-ysato@users.sourceforge.jp Subject: [PATCH v25 00/22] Add RX archtecture support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' dadff51 qapi/machine.json: Add RX cpu. ebb6621 BootLinuxConsoleTest: Test the RX-Virt machine f81a4dd Add rx-softmmu 91354fd hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 6703279 hw/rx: Honor -accel qtest 86d0724 hw/rx: RX Target hardware definition f85dbca hw/char: RX62N serial communication interface (SCI) 0aac3dc hw/timer: RX62N internal timer modules 189c157 hw/intc: RX62N interrupt controller (ICUa) f4e110a target/rx: Dump bytes for each insn during disassembly 68f9b3c target/rx: Collect all bytes during disassembly c99e307 target/rx: Emit all disassembly in one prt() afb3c6f target/rx: Use prt_ldmi for XCHG_mr disassembly a2ff9b7 target/rx: Replace operand with prt_ldmi in disassembler 2753df2 target/rx: Disassemble rx_index_addr into a string 6c571d3 target/rx: RX disassembler 149fc98 target/rx: CPU definition 1c56e9d target/rx: TCG helper 33ec1bb target/rx: TCG translation 6dcb4ce hw/registerfields.h: Add 8bit and 16bit register macros 15439bc qemu/bitops.h: Add extract8 and extract16 6e3543e MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 6e3543eb958d (MAINTAINERS: Add RX) 2/22 Checking commit 15439bc03d71 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 6dcb4ce925f7 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 33ec1bbabfae (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 1c56e9df0bda (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 149fc989a0b3 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 6c571d3b6a2f (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 2753df288343 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit a2ff9b7af426 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit afb3c6f62e73 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit c99e3071a323 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 68f9b3cbfd59 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit f4e110a34345 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 189c15760991 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 0aac3dc5034f (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit f85dbcaf07af (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 86d072406a77 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 670327948f3e (hw/rx: Honor -accel qtest) 19/22 Checking commit 91354fdc5435 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit f81a4dd43a15 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit ebb6621df590 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit dadff5195e22 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190927062302.110144-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 9/27/19 8:22 AM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. This series looks ready to get merged. Note to the maintainer merging it, various Signed-off-by are misplaced and the Message-Id tags should be removed. Regards, Phil.