Message ID | 20190912060701.4642-1-ysato@users.sourceforge.jp |
---|---|
Headers | show |
Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190912060701.4642-1-ysato@users.sourceforge.jp -> patchew/20190912060701.4642-1-ysato@users.sourceforge.jp Switched to a new branch 'test' c7211ec qapi/machine.json: Add RX cpu. 0a60bc1 BootLinuxConsoleTest: Test the RX-Virt machine 21ccd2b Add rx-softmmu 53b5a3e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 100e307 hw/rx: Honor -accel qtest 4737268 hw/rx: RX Target hardware definition 6d1d3f2 hw/char: RX62N serial communication interface (SCI) 96aa2bf hw/timer: RX62N internal timer modules 54ced3e hw/intc: RX62N interrupt controller (ICUa) 3200a28 target/rx: Dump bytes for each insn during disassembly a254a82 target/rx: Collect all bytes during disassembly 5f7675e target/rx: Emit all disassembly in one prt() 04b3639 target/rx: Use prt_ldmi for XCHG_mr disassembly b58c020 target/rx: Replace operand with prt_ldmi in disassembler 9217628 target/rx: Disassemble rx_index_addr into a string e4f57d2 target/rx: RX disassembler 702f27d target/rx: CPU definition 8abda61 target/rx: TCG helper ba2df21 target/rx: TCG translation 9201c38 hw/registerfields.h: Add 8bit and 16bit register macros a1dbe53 qemu/bitops.h: Add extract8 and extract16 7b0a56f MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 7b0a56f73866 (MAINTAINERS: Add RX) 2/22 Checking commit a1dbe53d2434 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 9201c38b0287 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit ba2df2186230 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 8abda6115755 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 702f27d78dde (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit e4f57d2f27c6 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 9217628e8446 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit b58c020a513e (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 04b36390113a (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 5f7675ee892f (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit a254a827a9c5 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 3200a284e4a4 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 54ced3e375a8 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 96aa2bf733b4 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 6d1d3f22147c (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 4737268c2023 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 100e307f42ee (hw/rx: Honor -accel qtest) 19/22 Checking commit 53b5a3ea7549 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 21ccd2b57887 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 0a60bc15b465 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit c7211ec79d66 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190911155125.11932-1-eric.auger@redhat.com -> patchew/20190911155125.11932-1-eric.auger@redhat.com - [tag update] patchew/20190912060701.4642-1-ysato@users.sourceforge.jp -> patchew/20190912060701.4642-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 8840cbe qapi/machine.json: Add RX cpu. 4771d28 BootLinuxConsoleTest: Test the RX-Virt machine 0ec329e Add rx-softmmu bbc35e0 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 1101341 hw/rx: Honor -accel qtest a74f685 hw/rx: RX Target hardware definition d8a6c3f hw/char: RX62N serial communication interface (SCI) 19db804 hw/timer: RX62N internal timer modules d62c0fc hw/intc: RX62N interrupt controller (ICUa) fb0a977 target/rx: Dump bytes for each insn during disassembly 5f7434e target/rx: Collect all bytes during disassembly 85a2cc5 target/rx: Emit all disassembly in one prt() 522142f target/rx: Use prt_ldmi for XCHG_mr disassembly 1def58b target/rx: Replace operand with prt_ldmi in disassembler c655e3d target/rx: Disassemble rx_index_addr into a string 96bdcb6 target/rx: RX disassembler 64e57e5 target/rx: CPU definition de36389 target/rx: TCG helper 0663825 target/rx: TCG translation 36d9ad4 hw/registerfields.h: Add 8bit and 16bit register macros f1d9a7f qemu/bitops.h: Add extract8 and extract16 a4c45e2 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit a4c45e218ea4 (MAINTAINERS: Add RX) 2/22 Checking commit f1d9a7fda4d6 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 36d9ad4d18a6 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 066382540c53 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit de3638959b10 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 64e57e51cdfe (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 96bdcb65077f (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit c655e3d74d62 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 1def58b9354e (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 522142f319b1 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 85a2cc54ba82 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 5f7434eb5757 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit fb0a97747b43 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit d62c0fcfec86 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 19db80403fae (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit d8a6c3f3d21b (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit a74f68504808 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 110134180d8b (hw/rx: Honor -accel qtest) 19/22 Checking commit bbc35e031774 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 0ec329eeeee1 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 4771d283f8a5 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 8840cbe6b3ab (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 672cebc qapi/machine.json: Add RX cpu. 5470489 BootLinuxConsoleTest: Test the RX-Virt machine 7c0507a Add rx-softmmu 2f5604b hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 35359c6 hw/rx: Honor -accel qtest 4e38d1e hw/rx: RX Target hardware definition 5eed65b hw/char: RX62N serial communication interface (SCI) 70855a7 hw/timer: RX62N internal timer modules 9fdcd72 hw/intc: RX62N interrupt controller (ICUa) 2e4ae69 target/rx: Dump bytes for each insn during disassembly 25ff366 target/rx: Collect all bytes during disassembly 8ec9dc5 target/rx: Emit all disassembly in one prt() be71e73 target/rx: Use prt_ldmi for XCHG_mr disassembly aa2175d target/rx: Replace operand with prt_ldmi in disassembler 48ed0fb target/rx: Disassemble rx_index_addr into a string d4bbb21 target/rx: RX disassembler cc17d1a target/rx: CPU definition 27b404b target/rx: TCG helper 4d35681 target/rx: TCG translation 6c2f3d2 hw/registerfields.h: Add 8bit and 16bit register macros bd8a862 qemu/bitops.h: Add extract8 and extract16 2ab4d1d MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 2ab4d1de3b6b (MAINTAINERS: Add RX) 2/22 Checking commit bd8a8623b650 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 6c2f3d225fa5 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 4d356815dd13 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 27b404b9078d (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit cc17d1accf57 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit d4bbb21de8d1 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 48ed0fb6bc35 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit aa2175df5901 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit be71e734f793 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 8ec9dc58c13f (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 25ff366929de (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 2e4ae6986d66 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 9fdcd721382e (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 70855a767490 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 5eed65b22dee (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 4e38d1ec8a27 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 35359c66753f (hw/rx: Honor -accel qtest) 19/22 Checking commit 2f5604b4ac6c (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 7c0507a16ffd (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 5470489924c3 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 672cebcb0d1f (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190912060701.4642-1-ysato@users.sourceforge.jp -> patchew/20190912060701.4642-1-ysato@users.sourceforge.jp Switched to a new branch 'test' 4839961 qapi/machine.json: Add RX cpu. ee1a34c BootLinuxConsoleTest: Test the RX-Virt machine 4bce111 Add rx-softmmu dd0ced9 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core c96b527 hw/rx: Honor -accel qtest edda463 hw/rx: RX Target hardware definition c0a3cae hw/char: RX62N serial communication interface (SCI) fc2fa4e hw/timer: RX62N internal timer modules df2c149 hw/intc: RX62N interrupt controller (ICUa) c3fa177 target/rx: Dump bytes for each insn during disassembly 9fee305 target/rx: Collect all bytes during disassembly 2ce3519 target/rx: Emit all disassembly in one prt() 60ad535 target/rx: Use prt_ldmi for XCHG_mr disassembly 4f15796 target/rx: Replace operand with prt_ldmi in disassembler 54f46ef target/rx: Disassemble rx_index_addr into a string b0f939a target/rx: RX disassembler 3343ef5 target/rx: CPU definition 20e5daa target/rx: TCG helper d345ff0 target/rx: TCG translation a6c73ed hw/registerfields.h: Add 8bit and 16bit register macros 624d286 qemu/bitops.h: Add extract8 and extract16 7a7544c MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 7a7544c80606 (MAINTAINERS: Add RX) 2/22 Checking commit 624d286dbc3b (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit a6c73edab979 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit d345ff0914d4 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 20e5daaba751 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 3343ef5d08c6 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit b0f939a431d1 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 54f46ef1d86a (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 4f157967ac8c (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 60ad5358dfcf (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 2ce3519386d5 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 9fee3055f6b2 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit c3fa177cd274 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit df2c14900c44 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit fc2fa4e6ee7a (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit c0a3cae6bf5a (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit edda463ad0aa (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit c96b527d5cc1 (hw/rx: Honor -accel qtest) 19/22 Checking commit dd0ced9a2709 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 4bce11113551 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit ee1a34c691b4 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 4839961c0c48 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 854b969 qapi/machine.json: Add RX cpu. 40265e4 BootLinuxConsoleTest: Test the RX-Virt machine a426c56 Add rx-softmmu bf7b8b6 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core e33fc18 hw/rx: Honor -accel qtest c1f8515 hw/rx: RX Target hardware definition ff330e1 hw/char: RX62N serial communication interface (SCI) d9b6ec7 hw/timer: RX62N internal timer modules 61b5881 hw/intc: RX62N interrupt controller (ICUa) 449d7d2 target/rx: Dump bytes for each insn during disassembly 2324075 target/rx: Collect all bytes during disassembly 9d9e64f target/rx: Emit all disassembly in one prt() bd10603 target/rx: Use prt_ldmi for XCHG_mr disassembly 621d97e target/rx: Replace operand with prt_ldmi in disassembler faf812b target/rx: Disassemble rx_index_addr into a string 8836e1a target/rx: RX disassembler 9484d60 target/rx: CPU definition 280801b target/rx: TCG helper e60db75 target/rx: TCG translation 2c8d76b hw/registerfields.h: Add 8bit and 16bit register macros 18cb0d7 qemu/bitops.h: Add extract8 and extract16 4441ef6 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 4441ef69b003 (MAINTAINERS: Add RX) 2/22 Checking commit 18cb0d7779c4 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 2c8d76b1623d (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit e60db75852e0 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 280801b8d545 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 9484d60bcbeb (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 8836e1a85647 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit faf812b3f51b (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 621d97ea9533 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit bd1060338c1b (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 9d9e64f6c956 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 23240751bf85 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 449d7d244352 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 61b5881909fe (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit d9b6ec7b8832 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit ff330e15b104 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit c1f851529a0f (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit e33fc1839e70 (hw/rx: Honor -accel qtest) 19/22 Checking commit bf7b8b6d98d1 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit a426c56f9cfe (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 40265e40369a (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 854b969dc208 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190912060701.4642-1-ysato@users.sourceforge.jp -> patchew/20190912060701.4642-1-ysato@users.sourceforge.jp Switched to a new branch 'test' b344509 qapi/machine.json: Add RX cpu. dbc4316 BootLinuxConsoleTest: Test the RX-Virt machine a73dba4 Add rx-softmmu 9e326f2 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 0e20757 hw/rx: Honor -accel qtest b8ef978 hw/rx: RX Target hardware definition a6e9525 hw/char: RX62N serial communication interface (SCI) 523f6ae hw/timer: RX62N internal timer modules dd7c03a hw/intc: RX62N interrupt controller (ICUa) 034ef9c target/rx: Dump bytes for each insn during disassembly 4a9f231 target/rx: Collect all bytes during disassembly 52ea55b target/rx: Emit all disassembly in one prt() c6a6fa3 target/rx: Use prt_ldmi for XCHG_mr disassembly 9d2d4c2 target/rx: Replace operand with prt_ldmi in disassembler 9409eea target/rx: Disassemble rx_index_addr into a string 24a6ce3 target/rx: RX disassembler 4324951 target/rx: CPU definition e013cf2 target/rx: TCG helper 2f5906e target/rx: TCG translation bd2b801 hw/registerfields.h: Add 8bit and 16bit register macros ffecfbc qemu/bitops.h: Add extract8 and extract16 08c4e97 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 08c4e975d29f (MAINTAINERS: Add RX) 2/22 Checking commit ffecfbc89a8c (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit bd2b8012f2e5 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 2f5906ec35fa (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit e013cf2e29f7 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 432495109747 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 588 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 24a6ce386bc6 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 9409eeafa61d (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 9d2d4c2a3f48 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit c6a6fa3f837f (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 52ea55be5ba4 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 4a9f231d6170 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 034ef9cc868c (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit dd7c03aa119a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 523f6ae3c8eb (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit a6e952569108 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 401 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit b8ef9788960c (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 480 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 0e207577f922 (hw/rx: Honor -accel qtest) 19/22 Checking commit 9e326f205701 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit a73dba432bb2 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 59 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit dbc431623329 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit b344509cdbc8 (qapi/machine.json: Add RX cpu.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com