Message ID | 20190909155813.27760-1-laurent@vivier.eu |
---|---|
Headers | show |
Series | hw/m68k: add Apple Machintosh Quadra 800 machine | expand |
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.27760-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190906113534.10907-1-thuth@redhat.com -> patchew/20190906113534.10907-1-thuth@redhat.com - [tag update] patchew/20190906113920.11271-1-thuth@redhat.com -> patchew/20190906113920.11271-1-thuth@redhat.com - [tag update] patchew/20190906152624.14784-1-thuth@redhat.com -> patchew/20190906152624.14784-1-thuth@redhat.com * [new tag] patchew/20190909155813.27760-1-laurent@vivier.eu -> patchew/20190909155813.27760-1-laurent@vivier.eu Switched to a new branch 'test' 0d8a805 hw/m68k: define Macintosh Quadra 800 2e809f8 hw/m68k: add a dummy SWIM floppy controller 9db1a83 hw/m68k: add Nubus support for macfb video card 9d82148 hw/m68k: add Nubus support abe34f5 hw/m68k: add macfb video card 355e9ab hw/m68k: implement ADB bus support for via 1d18ba6 hw/m68k: add via support fbb1ecf dp8393x: manage big endian bus d60e6a9 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit d60e6a94ac0b (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit fbb1ecfe661f (dp8393x: manage big endian bus) 3/9 Checking commit 1d18ba67a8ff (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #387: FILE: hw/misc/mac_via.c:344: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 814 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 355e9ab8413e (hw/m68k: implement ADB bus support for via) 5/9 Checking commit abe34f53667b (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 504 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 9d821480d8d9 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 9db1a839919c (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 2e809f800609 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 510 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 0d8a80538968 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 539 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190909155813.27760-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.27760-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190909155813.27760-1-laurent@vivier.eu -> patchew/20190909155813.27760-1-laurent@vivier.eu Switched to a new branch 'test' c2d6100 hw/m68k: define Macintosh Quadra 800 faa8087 hw/m68k: add a dummy SWIM floppy controller b107670 hw/m68k: add Nubus support for macfb video card 074d549 hw/m68k: add Nubus support e286de1 hw/m68k: add macfb video card 113a594 hw/m68k: implement ADB bus support for via 579567e hw/m68k: add via support dcd3348 dp8393x: manage big endian bus 173e471 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 173e4715350e (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit dcd334895d20 (dp8393x: manage big endian bus) 3/9 Checking commit 579567e8e64f (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #387: FILE: hw/misc/mac_via.c:344: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 814 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 113a5948138a (hw/m68k: implement ADB bus support for via) 5/9 Checking commit e286de13043d (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 504 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 074d549a6e03 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit b107670bf36a (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit faa8087e7199 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 510 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit c2d6100612f7 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 539 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190909155813.27760-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.27760-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190909155813.27760-1-laurent@vivier.eu -> patchew/20190909155813.27760-1-laurent@vivier.eu Switched to a new branch 'test' a20a341 hw/m68k: define Macintosh Quadra 800 8685d1d hw/m68k: add a dummy SWIM floppy controller 49fd148 hw/m68k: add Nubus support for macfb video card 0b80050 hw/m68k: add Nubus support 7a65c7d hw/m68k: add macfb video card 0bc554d hw/m68k: implement ADB bus support for via 7b79e17 hw/m68k: add via support 085d45e dp8393x: manage big endian bus 3f9b63e esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 3f9b63e16821 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit 085d45ea3778 (dp8393x: manage big endian bus) 3/9 Checking commit 7b79e179e50a (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #387: FILE: hw/misc/mac_via.c:344: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 814 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 0bc554d357f0 (hw/m68k: implement ADB bus support for via) 5/9 Checking commit 7a65c7dd3399 (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 504 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 0b8005090759 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 49fd148f8fb3 (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 8685d1dd8843 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 510 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit a20a341157b7 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 539 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190909155813.27760-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.27760-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3825476 hw/m68k: define Macintosh Quadra 800 114a77d hw/m68k: add a dummy SWIM floppy controller d84838f hw/m68k: add Nubus support for macfb video card 2aab199 hw/m68k: add Nubus support 0a3fcc1 hw/m68k: add macfb video card 0f6aae6 hw/m68k: implement ADB bus support for via 6254996 hw/m68k: add via support 4b96a1e dp8393x: manage big endian bus 80774ea esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 80774ead22c0 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit 4b96a1e36bb1 (dp8393x: manage big endian bus) 3/9 Checking commit 625499666ea0 (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #387: FILE: hw/misc/mac_via.c:344: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 814 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 0f6aae654fdc (hw/m68k: implement ADB bus support for via) 5/9 Checking commit 0a3fcc15c079 (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 504 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 2aab199032d6 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit d84838f24a5e (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 114a77d1bfc8 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 510 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 382547623d98 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 539 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190909155813.27760-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190909155813.27760-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v9 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190909155813.27760-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' cf83360 hw/m68k: define Macintosh Quadra 800 71c320f hw/m68k: add a dummy SWIM floppy controller b05e213 hw/m68k: add Nubus support for macfb video card 08872a1 hw/m68k: add Nubus support cb97e9d hw/m68k: add macfb video card dba185b hw/m68k: implement ADB bus support for via 6afa5ce hw/m68k: add via support bb86a96 dp8393x: manage big endian bus 9748f16 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 9748f16f724c (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit bb86a967e965 (dp8393x: manage big endian bus) 3/9 Checking commit 6afa5cebce7e (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #387: FILE: hw/misc/mac_via.c:344: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 814 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit dba185b57340 (hw/m68k: implement ADB bus support for via) 5/9 Checking commit cb97e9d367cf (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 504 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 08872a17deea (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit b05e213d7499 (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 71c320fb3e01 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 510 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit cf833602d89e (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #96: new file mode 100644 total: 0 errors, 1 warnings, 539 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190909155813.27760-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com