From patchwork Thu Nov 15 22:01:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bandan Das X-Patchwork-Id: 998557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42wwMX1c6Jz9s1x for ; Fri, 16 Nov 2018 09:02:30 +1100 (AEDT) Received: from localhost ([::1]:40952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPiV-0002zM-RE for incoming@patchwork.ozlabs.org; Thu, 15 Nov 2018 17:02:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPhz-0002z3-TS for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPhu-0000HX-HQ for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51228) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPht-0000Eo-6z for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:50 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B85D43001E72 for ; Thu, 15 Nov 2018 22:01:45 +0000 (UTC) Received: from gigantic.usersys.redhat.com (dhcp-17-169.bos.redhat.com [10.18.17.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5927819747; Thu, 15 Nov 2018 22:01:45 +0000 (UTC) From: Bandan Das To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 17:01:30 -0500 Message-Id: <20181115220132.6531-1-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 15 Nov 2018 22:01:45 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 0/2] Break down the MTP write operation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" For larger files, not only do we keep reallocating to increase the mtp buffer size, the write also happens in one go. This does two things: Write to file upto a certain data size we have received so far and second, reuse the buffer again instead of reallocating to a larger buffer size. Tested with different file sizes on a Linux guest. Bandan Das (2): usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ usb-mtp: breakup MTP write into smaller chunks hw/usb/dev-mtp.c | 153 +++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 99 insertions(+), 54 deletions(-)