From patchwork Wed Jul 4 12:49:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 939301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41LLSs4xwtz9s1B for ; Wed, 4 Jul 2018 22:50:53 +1000 (AEST) Received: from localhost ([::1]:46913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fahFD-0007zw-Ah for incoming@patchwork.ozlabs.org; Wed, 04 Jul 2018 08:50:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fahDy-0007Sj-Pc for qemu-devel@nongnu.org; Wed, 04 Jul 2018 08:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fahDx-0000UH-RO for qemu-devel@nongnu.org; Wed, 04 Jul 2018 08:49:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40768 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fahDr-0000RW-BR; Wed, 04 Jul 2018 08:49:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0013A402242D; Wed, 4 Jul 2018 12:49:25 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7EC02156889; Wed, 4 Jul 2018 12:49:24 +0000 (UTC) From: Andrew Jones To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Date: Wed, 4 Jul 2018 14:49:17 +0200 Message-Id: <20180704124923.32483-1-drjones@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 04 Jul 2018 12:49:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 04 Jul 2018 12:49:26 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'drjones@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [RFC PATCH 0/6] hw/arm/virt: Introduce cpu topology support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wei@redhat.com, peter.maydell@linaro.org, eric.auger@redhat.com, imammedo@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This series provides support for booting mach-virt machines with non-flat cpu topology, i.e. enabling the extended options of the '-smp' command line parameter (sockets,cores,threads). Both DT and ACPI description generators are added. We only apply the new feature to 3.1 and later machine types, as the change is guest visible, even when no command line change is made. This is because the basic '-smp ' parameter makes the assumption that refers to the number of sockets, but when no topology description is provided, Linux will use the MPIDR to guess. Neither the MPIDR exposed to the guest when running with KVM nor TCG currently provides socket information, leaving Linux to assume all processing elements are cores in the same socket. For example, before this series '-smp 4' would show up in the guest as CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 and after it shows up as CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 4 It's not expected that this should be a problem, but it's worth considering. The only way to avoid the silent change is for QEMU to provide boards a way to override the default '-smp' parsing function. Otherwise, if a user wants to avoid a guest visible change, but still use a 3.1 or later mach-virt machine type, then they must ensure the command line specifies a single socket, e.g. '-smp sockets=1,cores=4' Thanks, drew Andrew Jones (6): hw/arm/virt: Add virt-3.1 machine type device_tree: add qemu_fdt_add_path hw/arm/virt: DT: add cpu-map hw/arm/virt-acpi-build: distinguish possible and present cpus virt-acpi-build: add PPTT table hw/arm/virt: cpu topology: don't allow threads device_tree.c | 24 +++++++++++++ hw/acpi/aml-build.c | 50 ++++++++++++++++++++++++++ hw/arm/virt-acpi-build.c | 25 ++++++++++--- hw/arm/virt.c | 69 +++++++++++++++++++++++++++++++++--- include/hw/acpi/aml-build.h | 2 ++ include/hw/arm/virt.h | 1 + include/sysemu/device_tree.h | 1 + 7 files changed, 162 insertions(+), 10 deletions(-)