Message ID | 20180411185651.21351-1-laurent@vivier.eu |
---|---|
Headers | show |
Series | linux-user: move arch specific parts from main.c to arch directories | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180411185651.21351-1-laurent@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v2 00/19] linux-user: move arch specific parts from main.c to arch directories === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180329032149.44685-1-aik@ozlabs.ru -> patchew/20180329032149.44685-1-aik@ozlabs.ru * [new tag] patchew/20180411185651.21351-1-laurent@vivier.eu -> patchew/20180411185651.21351-1-laurent@vivier.eu Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Switched to a new branch 'test' ce56cf4ddf linux-user: move xtensa cpu loop to xtensa directory fbea8496c0 linux-user: move hppa cpu loop to hppa directory d6052fec98 linux-user: move riscv cpu loop to riscv directory 18c64ee772 linux-user: move tilegx cpu loop to tilegx directory bb73857610 linux-user: move s390x cpu loop to s390x directory dd5bdbd5a2 linux-user: move alpha cpu loop to alpha directory 6fd30276b4 linux-user: move m68k cpu loop to m68k directory 154b70b43b linux-user: move microblaze cpu loop to microblaze directory 3c976b0a5b linux-user: move cris cpu loop to cris directory 168d198956 linux-user: move sh4 cpu loop to sh4 directory 3727af28c4 linux-user: move openrisc cpu loop to openrisc directory 022b6bfbfe linux-user: move nios2 cpu loop to nios2 directory a74c1bdc87 linux-user: move mips/mips64 cpu loop to mips directory bdba9924f0 linux-user: move ppc/ppc64 cpu loop to ppc directory f574990761 linux-user: move sparc/sparc64 cpu loop to sparc directory ba06f492ed linux-user: move arm cpu loop to arm directory e972942232 linux-user: move aarch64 cpu loop to aarch64 directory 3b0cea493a linux-user: move i386/x86_64 cpu loop to i386 directory 99606788a5 linux-user: create a dummy per arch cpu_loop.c === OUTPUT BEGIN === Checking PATCH 1/19: linux-user: create a dummy per arch cpu_loop.c... Checking PATCH 2/19: linux-user: move i386/x86_64 cpu loop to i386 directory... ERROR: space required before the open parenthesis '(' #92: FILE: linux-user/i386/cpu_loop.c:91: + for(;;) { ERROR: space required before the open parenthesis '(' #98: FILE: linux-user/i386/cpu_loop.c:97: + switch(trapnr) { ERROR: braces {} are necessary for all arms of this statement #161: FILE: linux-user/i386/cpu_loop.c:160: + if (!(env->error_code & 1)) [...] + else [...] ERROR: that open brace { should be on the previous line #233: FILE: linux-user/i386/cpu_loop.c:232: + if (sig) + { WARNING: line over 80 characters #247: FILE: linux-user/i386/cpu_loop.c:246: + EXCP_DUMP(env, "qemu: 0x%08lx: unhandled CPU exception 0x%x - aborting\n", ERROR: spaces required around that '|' (ctx:VxV) #307: FILE: linux-user/i386/cpu_loop.c:306: + PROT_READ|PROT_WRITE, ^ ERROR: spaces required around that '|' (ctx:VxV) #308: FILE: linux-user/i386/cpu_loop.c:307: + MAP_ANONYMOUS|MAP_PRIVATE, -1, 0); ^ ERROR: spaces required around that '|' (ctx:VxV) #336: FILE: linux-user/i386/cpu_loop.c:335: + PROT_READ|PROT_WRITE, ^ ERROR: spaces required around that '|' (ctx:VxV) #337: FILE: linux-user/i386/cpu_loop.c:336: + MAP_ANONYMOUS|MAP_PRIVATE, -1, 0); ^ total: 8 errors, 1 warnings, 720 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/19: linux-user: move aarch64 cpu loop to aarch64 directory... WARNING: line over 80 characters #141: FILE: linux-user/aarch64/cpu_loop.c:142: + EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr); total: 0 errors, 1 warnings, 289 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/19: linux-user: move arm cpu loop to arm directory... ERROR: braces {} are necessary for all arms of this statement #172: FILE: linux-user/arm/cpu_loop.c:171: + if (get_user_u32(val, addr)) [...] ERROR: space required before the open parenthesis '(' #217: FILE: linux-user/arm/cpu_loop.c:216: + for(;;) { ERROR: space required before the open parenthesis '(' #223: FILE: linux-user/arm/cpu_loop.c:222: + switch(trapnr) { ERROR: spaces required around that '=' (ctx:VxV) #245: FILE: linux-user/arm/cpu_loop.c:244: + int arm_fpe=0; ^ ERROR: suspect code indent for conditional statements (20, 22) #248: FILE: linux-user/arm/cpu_loop.c:247: + if (-rc & float_flag_invalid) + arm_fpe |= BIT_IOC; ERROR: braces {} are necessary for all arms of this statement #248: FILE: linux-user/arm/cpu_loop.c:247: + if (-rc & float_flag_invalid) [...] ERROR: suspect code indent for conditional statements (20, 22) #250: FILE: linux-user/arm/cpu_loop.c:249: + if (-rc & float_flag_divbyzero) + arm_fpe |= BIT_DZC; ERROR: braces {} are necessary for all arms of this statement #250: FILE: linux-user/arm/cpu_loop.c:249: + if (-rc & float_flag_divbyzero) [...] ERROR: suspect code indent for conditional statements (20, 22) #252: FILE: linux-user/arm/cpu_loop.c:251: + if (-rc & float_flag_overflow) + arm_fpe |= BIT_OFC; ERROR: braces {} are necessary for all arms of this statement #252: FILE: linux-user/arm/cpu_loop.c:251: + if (-rc & float_flag_overflow) [...] ERROR: suspect code indent for conditional statements (20, 22) #254: FILE: linux-user/arm/cpu_loop.c:253: + if (-rc & float_flag_underflow) + arm_fpe |= BIT_UFC; ERROR: braces {} are necessary for all arms of this statement #254: FILE: linux-user/arm/cpu_loop.c:253: + if (-rc & float_flag_underflow) [...] ERROR: suspect code indent for conditional statements (20, 22) #256: FILE: linux-user/arm/cpu_loop.c:255: + if (-rc & float_flag_inexact) + arm_fpe |= BIT_IXC; ERROR: braces {} are necessary for all arms of this statement #256: FILE: linux-user/arm/cpu_loop.c:255: + if (-rc & float_flag_inexact) [...] ERROR: do not use C99 // comments #260: FILE: linux-user/arm/cpu_loop.c:259: + //printf("fpsr 0x%x, arm_fpe 0x%x\n",fpsr,arm_fpe); ERROR: trailing statements should be on next line #267: FILE: linux-user/arm/cpu_loop.c:266: + if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES; ERROR: braces {} are necessary for all arms of this statement #267: FILE: linux-user/arm/cpu_loop.c:266: + if (arm_fpe & BIT_IXC) info.si_code = TARGET_FPE_FLTRES; [...] ERROR: trailing statements should be on next line #268: FILE: linux-user/arm/cpu_loop.c:267: + if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND; ERROR: braces {} are necessary for all arms of this statement #268: FILE: linux-user/arm/cpu_loop.c:267: + if (arm_fpe & BIT_UFC) info.si_code = TARGET_FPE_FLTUND; [...] ERROR: trailing statements should be on next line #269: FILE: linux-user/arm/cpu_loop.c:268: + if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF; ERROR: braces {} are necessary for all arms of this statement #269: FILE: linux-user/arm/cpu_loop.c:268: + if (arm_fpe & BIT_OFC) info.si_code = TARGET_FPE_FLTOVF; [...] ERROR: trailing statements should be on next line #270: FILE: linux-user/arm/cpu_loop.c:269: + if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV; ERROR: braces {} are necessary for all arms of this statement #270: FILE: linux-user/arm/cpu_loop.c:269: + if (arm_fpe & BIT_DZC) info.si_code = TARGET_FPE_FLTDIV; [...] ERROR: trailing statements should be on next line #271: FILE: linux-user/arm/cpu_loop.c:270: + if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV; ERROR: braces {} are necessary for all arms of this statement #271: FILE: linux-user/arm/cpu_loop.c:270: + if (arm_fpe & BIT_IOC) info.si_code = TARGET_FPE_FLTINV; [...] ERROR: suspect code indent for conditional statements (20, 22) #280: FILE: linux-user/arm/cpu_loop.c:279: + if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC)) + fpsr |= BIT_IXC; ERROR: braces {} are necessary for all arms of this statement #280: FILE: linux-user/arm/cpu_loop.c:279: + if ((!(fpsr & BIT_IXE)) && (arm_fpe & BIT_IXC)) [...] ERROR: suspect code indent for conditional statements (20, 22) #282: FILE: linux-user/arm/cpu_loop.c:281: + if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC)) + fpsr |= BIT_UFC; ERROR: braces {} are necessary for all arms of this statement #282: FILE: linux-user/arm/cpu_loop.c:281: + if ((!(fpsr & BIT_UFE)) && (arm_fpe & BIT_UFC)) [...] ERROR: suspect code indent for conditional statements (20, 22) #284: FILE: linux-user/arm/cpu_loop.c:283: + if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC)) + fpsr |= BIT_OFC; ERROR: braces {} are necessary for all arms of this statement #284: FILE: linux-user/arm/cpu_loop.c:283: + if ((!(fpsr & BIT_OFE)) && (arm_fpe & BIT_OFC)) [...] ERROR: suspect code indent for conditional statements (20, 22) #286: FILE: linux-user/arm/cpu_loop.c:285: + if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC)) + fpsr |= BIT_DZC; ERROR: braces {} are necessary for all arms of this statement #286: FILE: linux-user/arm/cpu_loop.c:285: + if ((!(fpsr & BIT_DZE)) && (arm_fpe & BIT_DZC)) [...] ERROR: suspect code indent for conditional statements (20, 22) #288: FILE: linux-user/arm/cpu_loop.c:287: + if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC)) + fpsr |= BIT_IOC; ERROR: braces {} are necessary for all arms of this statement #288: FILE: linux-user/arm/cpu_loop.c:287: + if ((!(fpsr & BIT_IOE)) && (arm_fpe & BIT_IOC)) [...] ERROR: spaces required around that '=' (ctx:VxV) #290: FILE: linux-user/arm/cpu_loop.c:289: + ts->fpa.fpsr=fpsr; ^ ERROR: space prohibited between function name and open parenthesis '(' #330: FILE: linux-user/arm/cpu_loop.c:329: + env->regs[0] = do_arm_semihosting (env); ERROR: space prohibited after that open parenthesis '(' #339: FILE: linux-user/arm/cpu_loop.c:338: + if ( n > ARM_NR_BASE) { ERROR: that open brace { should be on the previous line #402: FILE: linux-user/arm/cpu_loop.c:401: + if (sig) + { ERROR: suspect code indent for conditional statements (12, 14) #412: FILE: linux-user/arm/cpu_loop.c:411: + if (do_kernel_trap(env)) + goto error; ERROR: braces {} are necessary for all arms of this statement #412: FILE: linux-user/arm/cpu_loop.c:411: + if (do_kernel_trap(env)) [...] WARNING: line over 80 characters #423: FILE: linux-user/arm/cpu_loop.c:422: + EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr); ERROR: space required before the open parenthesis '(' #439: FILE: linux-user/arm/cpu_loop.c:438: + for(i = 0; i < 16; i++) { total: 42 errors, 1 warnings, 889 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/19: linux-user: move sparc/sparc64 cpu loop to sparc directory... ERROR: do not use C99 // comments #333: FILE: linux-user/sparc/cpu_loop.c:26: +//#define DEBUG_WIN ERROR: braces {} are necessary for all arms of this statement #342: FILE: linux-user/sparc/cpu_loop.c:35: + if (index < 8 && env->cwp == env->nwindows - 1) [...] ERROR: braces {} are necessary for all arms of this statement #355: FILE: linux-user/sparc/cpu_loop.c:48: + if (sp_ptr & 3) [...] ERROR: space required before the open parenthesis '(' #362: FILE: linux-user/sparc/cpu_loop.c:55: + for(i = 0; i < 16; i++) { ERROR: braces {} are necessary for all arms of this statement #401: FILE: linux-user/sparc/cpu_loop.c:94: + if (sp_ptr & 3) [...] ERROR: space required before the open parenthesis '(' #408: FILE: linux-user/sparc/cpu_loop.c:101: + for(i = 0; i < 16; i++) { ERROR: braces {} are necessary for all arms of this statement #415: FILE: linux-user/sparc/cpu_loop.c:108: + if (env->cleanwin < env->nwindows - 1) [...] ERROR: space required before the open parenthesis '(' #428: FILE: linux-user/sparc/cpu_loop.c:121: + for(;;) { ERROR: braces {} are necessary for all arms of this statement #432: FILE: linux-user/sparc/cpu_loop.c:125: + if (env->wim & (1 << cwp1)) [...] ERROR: braces {} are necessary for all arms of this statement #435: FILE: linux-user/sparc/cpu_loop.c:128: + if (env->canrestore == 0) [...] ERROR: space prohibited between function name and open parenthesis '(' #453: FILE: linux-user/sparc/cpu_loop.c:146: +void cpu_loop (CPUSPARCState *env) ERROR: space prohibited between function name and open parenthesis '(' #479: FILE: linux-user/sparc/cpu_loop.c:172: + ret = do_syscall (env, env->gregs[1], ERROR: braces {} are necessary for all arms of this statement #547: FILE: linux-user/sparc/cpu_loop.c:240: + if (trapnr == TT_DFAULT) [...] + else [...] ERROR: that open brace { should be on the previous line #582: FILE: linux-user/sparc/cpu_loop.c:275: + if (sig) + { ERROR: space prohibited between function name and open parenthesis '(' #595: FILE: linux-user/sparc/cpu_loop.c:288: + printf ("Unhandled trap: 0x%x\n", trapnr); ERROR: space prohibited between function name and open parenthesis '(' #599: FILE: linux-user/sparc/cpu_loop.c:292: + process_pending_signals (env); ERROR: space required before the open parenthesis '(' #609: FILE: linux-user/sparc/cpu_loop.c:302: + for(i = 0; i < 8; i++) ERROR: braces {} are necessary for all arms of this statement #609: FILE: linux-user/sparc/cpu_loop.c:302: + for(i = 0; i < 8; i++) [...] ERROR: space required before the open parenthesis '(' #611: FILE: linux-user/sparc/cpu_loop.c:304: + for(i = 0; i < 8; i++) ERROR: braces {} are necessary for all arms of this statement #611: FILE: linux-user/sparc/cpu_loop.c:304: + for(i = 0; i < 8; i++) [...] total: 20 errors, 0 warnings, 597 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/19: linux-user: move ppc/ppc64 cpu loop to ppc directory... ERROR: space prohibited between function name and open parenthesis '(' #626: FILE: linux-user/ppc/cpu_loop.c:50: +__attribute__ (( alias ("cpu_ppc_load_tbu") )); ERROR: space prohibited after that open parenthesis '(' #626: FILE: linux-user/ppc/cpu_loop.c:50: +__attribute__ (( alias ("cpu_ppc_load_tbu") )); ERROR: space prohibited before that close parenthesis ')' #626: FILE: linux-user/ppc/cpu_loop.c:50: +__attribute__ (( alias ("cpu_ppc_load_tbu") )); ERROR: space prohibited between function name and open parenthesis '(' #634: FILE: linux-user/ppc/cpu_loop.c:58: +int ppc_dcr_read (ppc_dcr_t *dcr_env, int dcrn, uint32_t *valp) ERROR: space prohibited between function name and open parenthesis '(' #639: FILE: linux-user/ppc/cpu_loop.c:63: +int ppc_dcr_write (ppc_dcr_t *dcr_env, int dcrn, uint32_t val) ERROR: trailing statements should be on next line #666: FILE: linux-user/ppc/cpu_loop.c:90: + case 1: segv = get_user_u8(val, addr); break; ERROR: trailing statements should be on next line #667: FILE: linux-user/ppc/cpu_loop.c:91: + case 2: segv = get_user_u16(val, addr); break; ERROR: trailing statements should be on next line #668: FILE: linux-user/ppc/cpu_loop.c:92: + case 4: segv = get_user_u32(val, addr); break; ERROR: trailing statements should be on next line #670: FILE: linux-user/ppc/cpu_loop.c:94: + case 8: segv = get_user_u64(val, addr); break; ERROR: trailing statements should be on next line #679: FILE: linux-user/ppc/cpu_loop.c:103: + default: abort(); ERROR: trailing statements should be on next line #684: FILE: linux-user/ppc/cpu_loop.c:108: + case 1: segv = put_user_u8(val, addr); break; ERROR: trailing statements should be on next line #685: FILE: linux-user/ppc/cpu_loop.c:109: + case 2: segv = put_user_u16(val, addr); break; ERROR: trailing statements should be on next line #686: FILE: linux-user/ppc/cpu_loop.c:110: + case 4: segv = put_user_u32(val, addr); break; ERROR: trailing statements should be on next line #688: FILE: linux-user/ppc/cpu_loop.c:112: + case 8: segv = put_user_u64(val, addr); break; ERROR: spaces required around that '+' (ctx:VxV) #693: FILE: linux-user/ppc/cpu_loop.c:117: + val = env->gpr[reg+1]; ^ ERROR: spaces required around that '+' (ctx:VxV) #695: FILE: linux-user/ppc/cpu_loop.c:119: + val2 = env->gpr[reg+1]; ^ ERROR: trailing statements should be on next line #705: FILE: linux-user/ppc/cpu_loop.c:129: + default: abort(); ERROR: space required before the open parenthesis '(' #730: FILE: linux-user/ppc/cpu_loop.c:154: + for(;;) { ERROR: space required before the open parenthesis '(' #736: FILE: linux-user/ppc/cpu_loop.c:160: + switch(trapnr) { ERROR: space required before the open parenthesis '(' #1152: FILE: linux-user/ppc/cpu_loop.c:576: + for(i = 0; i < 32; i++) { total: 20 errors, 0 warnings, 1131 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/19: linux-user: move mips/mips64 cpu loop to mips directory... ERROR: Macros with complex values should be enclosed in parenthesis #775: FILE: linux-user/mips/cpu_loop.c:26: +# define MIPS_SYS(name, args) args, ERROR: space required before the open parenthesis '(' #1234: FILE: linux-user/mips/cpu_loop.c:485: + for(;;) { ERROR: space required before the open parenthesis '(' #1240: FILE: linux-user/mips/cpu_loop.c:491: + switch(trapnr) { ERROR: do not use assignment in if condition #1257: FILE: linux-user/mips/cpu_loop.c:508: + if ((ret = get_user_ual(arg8, sp_reg + 28)) != 0) { ERROR: do not use assignment in if condition #1261: FILE: linux-user/mips/cpu_loop.c:512: + if ((ret = get_user_ual(arg7, sp_reg + 24)) != 0) { ERROR: do not use assignment in if condition #1265: FILE: linux-user/mips/cpu_loop.c:516: + if ((ret = get_user_ual(arg6, sp_reg + 20)) != 0) { ERROR: do not use assignment in if condition #1269: FILE: linux-user/mips/cpu_loop.c:520: + if ((ret = get_user_ual(arg5, sp_reg + 16)) != 0) { ERROR: that open brace { should be on the previous line #1333: FILE: linux-user/mips/cpu_loop.c:584: + if (sig) + { WARNING: line over 80 characters #1463: FILE: linux-user/mips/cpu_loop.c:714: + EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr); ERROR: space required before the open parenthesis '(' #1477: FILE: linux-user/mips/cpu_loop.c:728: + for(i = 0; i < 32; i++) { total: 9 errors, 1 warnings, 1478 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 8/19: linux-user: move nios2 cpu loop to nios2 directory... Checking PATCH 9/19: linux-user: move openrisc cpu loop to openrisc directory... Checking PATCH 10/19: linux-user: move sh4 cpu loop to sh4 directory... ERROR: space prohibited between function name and open parenthesis '(' #193: FILE: linux-user/sh4/cpu_loop.c:87: + printf ("Unhandled trap: 0x%x\n", trapnr); ERROR: space prohibited between function name and open parenthesis '(' #197: FILE: linux-user/sh4/cpu_loop.c:91: + process_pending_signals (env); ERROR: space required before the open parenthesis '(' #213: FILE: linux-user/sh4/cpu_loop.c:107: + for(i = 0; i < 16; i++) { total: 3 errors, 0 warnings, 193 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/19: linux-user: move cris cpu loop to cris directory... ERROR: trailing whitespace #27: FILE: linux-user/cris/cpu_loop.c:29: + $ ERROR: trailing whitespace #49: FILE: linux-user/cris/cpu_loop.c:51: + ret = do_syscall(env, $ ERROR: trailing whitespace #50: FILE: linux-user/cris/cpu_loop.c:52: + env->regs[9], $ ERROR: trailing whitespace #51: FILE: linux-user/cris/cpu_loop.c:53: + env->regs[10], $ ERROR: trailing whitespace #52: FILE: linux-user/cris/cpu_loop.c:54: + env->regs[11], $ ERROR: trailing whitespace #53: FILE: linux-user/cris/cpu_loop.c:55: + env->regs[12], $ ERROR: trailing whitespace #54: FILE: linux-user/cris/cpu_loop.c:56: + env->regs[13], $ ERROR: trailing whitespace #55: FILE: linux-user/cris/cpu_loop.c:57: + env->pregs[7], $ ERROR: that open brace { should be on the previous line #69: FILE: linux-user/cris/cpu_loop.c:71: + if (sig) + { ERROR: space prohibited between function name and open parenthesis '(' #82: FILE: linux-user/cris/cpu_loop.c:84: + printf ("Unhandled trap: 0x%x\n", trapnr); ERROR: space prohibited between function name and open parenthesis '(' #86: FILE: linux-user/cris/cpu_loop.c:88: + process_pending_signals (env); total: 11 errors, 0 warnings, 197 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/19: linux-user: move microblaze cpu loop to microblaze directory... ERROR: trailing whitespace #200: FILE: linux-user/microblaze/cpu_loop.c:29: + $ ERROR: trailing whitespace #225: FILE: linux-user/microblaze/cpu_loop.c:54: + ret = do_syscall(env, $ ERROR: trailing whitespace #226: FILE: linux-user/microblaze/cpu_loop.c:55: + env->regs[12], $ ERROR: trailing whitespace #227: FILE: linux-user/microblaze/cpu_loop.c:56: + env->regs[5], $ ERROR: trailing whitespace #228: FILE: linux-user/microblaze/cpu_loop.c:57: + env->regs[6], $ ERROR: trailing whitespace #229: FILE: linux-user/microblaze/cpu_loop.c:58: + env->regs[7], $ ERROR: trailing whitespace #230: FILE: linux-user/microblaze/cpu_loop.c:59: + env->regs[8], $ ERROR: trailing whitespace #231: FILE: linux-user/microblaze/cpu_loop.c:60: + env->regs[9], $ ERROR: switch and case should be at the same indent #258: FILE: linux-user/microblaze/cpu_loop.c:87: + switch (env->sregs[SR_ESR] & 31) { + case ESR_EC_DIVZERO: [...] + case ESR_EC_FPU: [...] + default: ERROR: space prohibited between function name and open parenthesis '(' #279: FILE: linux-user/microblaze/cpu_loop.c:108: + printf ("Unhandled hw-exception: 0x%x\n", ERROR: that open brace { should be on the previous line #291: FILE: linux-user/microblaze/cpu_loop.c:120: + if (sig) + { ERROR: space prohibited between function name and open parenthesis '(' #304: FILE: linux-user/microblaze/cpu_loop.c:133: + printf ("Unhandled trap: 0x%x\n", trapnr); ERROR: space prohibited between function name and open parenthesis '(' #308: FILE: linux-user/microblaze/cpu_loop.c:137: + process_pending_signals (env); total: 13 errors, 0 warnings, 323 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/19: linux-user: move m68k cpu loop to m68k directory... ERROR: space required before the open parenthesis '(' #30: FILE: linux-user/m68k/cpu_loop.c:32: + for(;;) { ERROR: space required before the open parenthesis '(' #36: FILE: linux-user/m68k/cpu_loop.c:38: + switch(trapnr) { ERROR: that open brace { should be on the previous line #118: FILE: linux-user/m68k/cpu_loop.c:120: + if (sig) + { WARNING: line over 80 characters #131: FILE: linux-user/m68k/cpu_loop.c:133: + EXCP_DUMP(env, "qemu: unhandled CPU exception 0x%x - aborting\n", trapnr); total: 3 errors, 1 warnings, 318 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/19: linux-user: move alpha cpu loop to alpha directory... ERROR: space prohibited between function name and open parenthesis '(' #201: FILE: linux-user/alpha/cpu_loop.c:199: + printf ("Unhandled trap: 0x%x\n", trapnr); ERROR: space prohibited between function name and open parenthesis '(' #205: FILE: linux-user/alpha/cpu_loop.c:203: + process_pending_signals (env); ERROR: space required before the open parenthesis '(' #222: FILE: linux-user/alpha/cpu_loop.c:220: + for(i = 0; i < 28; i++) { total: 3 errors, 0 warnings, 421 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/19: linux-user: move s390x cpu loop to s390x directory... ERROR: space prohibited between function name and open parenthesis '(' #316: FILE: linux-user/s390x/cpu_loop.c:153: + process_pending_signals (env); total: 1 errors, 0 warnings, 303 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 16/19: linux-user: move tilegx cpu loop to tilegx directory... Checking PATCH 17/19: linux-user: move riscv cpu loop to riscv directory... Checking PATCH 18/19: linux-user: move hppa cpu loop to hppa directory... Checking PATCH 19/19: linux-user: move xtensa cpu loop to xtensa directory... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com