From patchwork Fri Jan 5 13:32:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murilo Opsfelder Araujo X-Patchwork-Id: 856045 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zClyG2H2gz9ryr for ; Sat, 6 Jan 2018 00:34:30 +1100 (AEDT) Received: from localhost ([::1]:40267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXS8i-0003Qc-77 for incoming@patchwork.ozlabs.org; Fri, 05 Jan 2018 08:34:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXS7w-0003Np-1c for qemu-devel@nongnu.org; Fri, 05 Jan 2018 08:33:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXS7r-0004wY-3d for qemu-devel@nongnu.org; Fri, 05 Jan 2018 08:33:40 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45642 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eXS7q-0004vb-Ub for qemu-devel@nongnu.org; Fri, 05 Jan 2018 08:33:35 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w05DSbAN081328 for ; Fri, 5 Jan 2018 08:33:33 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0b-001b2d01.pphosted.com with ESMTP id 2fa8da4r9r-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 05 Jan 2018 08:33:32 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Jan 2018 08:33:32 -0500 Received: from b01cxnp22033.gho.pok.ibm.com (9.57.198.23) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 5 Jan 2018 08:33:29 -0500 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w05DXTBG38797504; Fri, 5 Jan 2018 13:33:29 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0776DAE04E; Fri, 5 Jan 2018 08:34:38 -0500 (EST) Received: from kermit-br-ibm-com.ibmmodules.com (unknown [9.80.206.62]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id E59ADAE034; Fri, 5 Jan 2018 08:34:35 -0500 (EST) From: Murilo Opsfelder Araujo To: qemu-devel@nongnu.org Date: Fri, 5 Jan 2018 11:32:40 -0200 X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18010513-0040-0000-0000-000003DBF3D6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008323; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000244; SDB=6.00970607; UDB=6.00491595; IPR=6.00750577; BA=6.00005765; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018889; XFM=3.00000015; UTC=2018-01-05 13:33:31 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010513-0041-0000-0000-000007D14A14 Message-Id: <20180105133241.14141-1-muriloo@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-01-05_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801050190 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH 0/1] qemu/nbd: fix segmentation fault when .desc is not null-terminated X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, R Nageswara Sastry , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini , Murilo Opsfelder Araujo Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hello, QEMU community. The following patch is to fix a segmentation fault when nbd_runtime_opts.desc is not null-terminated. This issue emerged when building QEMU with --enable-gcov, as described by https://bugs.launchpad.net/qemu/+bug/1727259. To reproduce on ppc64le, run the following commands on QEMU git tree: mkdir build mkdir -p tests/qemu-iotests/scratch cd build ../configure --target-list=ppc64-softmmu --enable-gcov make -j$(nproc) ./qemu-img create -f qcow2 -o compat=1.1 ./tests/qemu-iotests/scratch/t.qcow2 64M ./qemu-io --cache writeback -f qcow2 -c "write -P 0xa 0x1000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-io --cache writeback -f qcow2 -c "write -P 0xb 0x2000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-img snapshot -c sn1 ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-io --cache writeback -f qcow2 -c "write -P 0xc 0x1000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-io --cache writeback -f qcow2 -c "write -P 0xd 0x2000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-img check -f qcow2 ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-io --cache writeback -f qcow2 -c "read -P 0xc 0x1000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 ./qemu-io --cache writeback -f qcow2 -c "read -P 0xd 0x2000 0x1000" ./tests/qemu-iotests/scratch/t.qcow2 # run in background, wait some seconds until it starts ./qemu-nbd -v -t -k ${PWD}/tests/qemu-iotests/scratch/test_qemu_nbd_socket ./tests/qemu-iotests/scratch/t.qcow2 -l sn1 & sleep 5 # this will cause qemu-io to segfault ./qemu-io --cache writeback -f qcow2 -f raw --cache=writeback -r -c "read -P 0xa 0x1000 0x1000" nbd:unix:${PWD}/tests/qemu-iotests/scratch/test_qemu_nbd_socket # kill qemu-nbd kill $(pidof qemu-nbd) Cheers Murilo Murilo Opsfelder Araujo (1): block/nbd: fix segmentation fault when .desc is not null-terminated block/nbd.c | 1 + 1 file changed, 1 insertion(+)