Message ID | 20171218040852.13478.19208.stgit@gimli.home |
---|---|
Headers | show |
Series | vfio/pci: MSI-X MMIO relocation | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171218040852.13478.19208.stgit@gimli.home Subject: [Qemu-devel] [RFC/RFT PATCH 0/5] vfio/pci: MSI-X MMIO relocation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3a11d5cf58 vfio/pci: Allow relocating MSI-X MMIO 2b0d6c16be qapi: Create DEFINE_PROP_OFF_AUTO_PCIBAR e4576d74be vfio/pci: Emulate BARs 51a4ffc4de vfio/pci: Add base BAR MemoryRegion b98cf31ab0 vfio/pci: Fixup VFIOMSIXInfo comment === OUTPUT BEGIN === Checking PATCH 1/5: vfio/pci: Fixup VFIOMSIXInfo comment... Checking PATCH 2/5: vfio/pci: Add base BAR MemoryRegion... ERROR: suspect code indent for conditional statements (8, 11) #143: FILE: hw/vfio/pci.c:1604: + if (bar->size) { + object_unparent(OBJECT(bar->mr)); total: 1 errors, 0 warnings, 141 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/5: vfio/pci: Emulate BARs... Checking PATCH 4/5: qapi: Create DEFINE_PROP_OFF_AUTO_PCIBAR... Checking PATCH 5/5: vfio/pci: Allow relocating MSI-X MMIO... ERROR: braces {} are necessary for all arms of this statement #67: FILE: hw/vfio/pci.c:1385: + if (vdev->bars[i].size > (UINT32_MAX / 2)) [...] ERROR: suspect code indent for conditional statements (12, 14) #84: FILE: hw/vfio/pci.c:1402: + if (vdev->bars[i].mem64) { + i++; total: 2 errors, 0 warnings, 147 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org