From patchwork Tue Sep 26 18:33:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 818773 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y1qNf4JKRz9t3h for ; Wed, 27 Sep 2017 04:34:10 +1000 (AEST) Received: from localhost ([::1]:50665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwugK-0004O7-Js for incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 14:34:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwufd-0004Ld-IC for qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwufa-0003Qx-Fj for qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57684) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dwufa-0003Qk-A9 for qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:33:22 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BA942F944D; Tue, 26 Sep 2017 18:33:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5BA942F944D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=david@redhat.com Received: from t460s.redhat.com (ovpn-117-152.ams2.redhat.com [10.36.117.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9419614C5; Tue, 26 Sep 2017 18:33:19 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Tue, 26 Sep 2017 20:33:12 +0200 Message-Id: <20170926183318.12995-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 26 Sep 2017 18:33:21 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v1 0/6] s390x/tcg: fix some accesses using low address X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , thuth@redhat.com, cohuck@redhat.com, Alexander Graf , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Conny reported that a guest Linux currently spits out: "The s390-virtio transport is deprecated. Please switch to a modern host providing virtio-ccw." This is strange, because we have no legacy virtio transport in QEMU :) Main problem is, that a page is tested for acccess, and the test does not fail. All memory access variants like stb_phys() will never fail. On invalid memory, they simply do nothing. Linux uses lura for this check. Let's introduce a _real MMU that handles prefixing and can later be used for things like low address protection. The other BUG is that a check for invalid memory is wrong. Therefore, Patch 1 alone makes the guest crash when trying to initialize the virtio transport. Crazy stuff. David Hildenbrand (6): s390x/tcg: fix checking for invalid memory check s390x/tcg: add MMU for real addresses s390x/tcg: make lura(g) use the new _real mmu. s390x/tcg: make stora(g) use the new _real mmu s390x/tcg: make testblock use the new _real mmu s390x/tcg: make idte/ipte use the new _real mmu target/s390x/cpu.h | 4 +++- target/s390x/excp_helper.c | 29 +++++++++++++++++++---------- target/s390x/internal.h | 2 ++ target/s390x/mem_helper.c | 36 +++++++++++------------------------- target/s390x/mmu_helper.c | 19 +++++++++++++++++++ target/s390x/translate.c | 4 ---- 6 files changed, 54 insertions(+), 40 deletions(-) Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth