| Message ID | 1688135108-316997-1-git-send-email-steven.sistare@oracle.com |
|---|---|
| Headers | show |
| Series | migration file URI | expand |
Tested-by: Michael Galaxy <mgalaxy@akamai.com> Reviewed-by: Michael Galaxy <mgalaxy@akamai.com> On 6/30/23 09:25, Steve Sistare wrote: > Add the migration URI "file:filename[,offset=offset]". > > Fabiano Rosas has submitted the unit tests in the series > migration: Test the new "file:" migration > > Steve Sistare (2): > migration: file URI > migration: file URI offset > > migration/file.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++ > migration/file.h | 14 +++++++ > migration/meson.build | 1 + > migration/migration.c | 5 +++ > migration/trace-events | 4 ++ > qemu-options.hx | 7 +++- > 6 files changed, 133 insertions(+), 1 deletion(-) > create mode 100644 migration/file.c > create mode 100644 migration/file.h >
Hello, this series is all reviewed, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, can it be merged? Thanks, Claudio On 6/30/23 16:25, Steve Sistare wrote: > Add the migration URI "file:filename[,offset=offset]". > > Fabiano Rosas has submitted the unit tests in the series > migration: Test the new "file:" migration > > Steve Sistare (2): > migration: file URI > migration: file URI offset > > migration/file.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++ > migration/file.h | 14 +++++++ > migration/meson.build | 1 + > migration/migration.c | 5 +++ > migration/trace-events | 4 ++ > qemu-options.hx | 7 +++- > 6 files changed, 133 insertions(+), 1 deletion(-) > create mode 100644 migration/file.c > create mode 100644 migration/file.h >
Hi Claudio, On 22/8/23 14:00, Claudio Fontana wrote: > Hello, > > this series is all reviewed, > > and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore > when migrating to disk, can it be merged? $ ./scripts/get_maintainer.pl -f migration/meson.build Juan Quintela <quintela@redhat.com> (maintainer:Migration) Peter Xu <peterx@redhat.com> (reviewer:Migration) Leonardo Bras <leobras@redhat.com> (reviewer:Migration) qemu-devel@nongnu.org (open list:All patches CC here) One maintainer, one single point of failure. When the maintainer is busy or offline (vacations?) then everybody is stuck. This is usually solved by adding co-maintainers. Juan, would you accept having co-maintainers helping you dealing with the merge process? I'm not volunteering, but this can be a good opportunity to make a formal request to the community. Regards, Phil.
On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 22/8/23 14:00, Claudio Fontana wrote: >> Hello, >> >> this series is all reviewed, >> >> and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore >> when migrating to disk, can it be merged? > > $ ./scripts/get_maintainer.pl -f migration/meson.build > Juan Quintela <quintela@redhat.com> (maintainer:Migration) > Peter Xu <peterx@redhat.com> (reviewer:Migration) > Leonardo Bras <leobras@redhat.com> (reviewer:Migration) > qemu-devel@nongnu.org (open list:All patches CC here) > > One maintainer, one single point of failure. When the > maintainer is busy or offline (vacations?) then everybody > is stuck. > > This is usually solved by adding co-maintainers. > > Juan, would you accept having co-maintainers helping you > dealing with the merge process? I'm not volunteering, but > this can be a good opportunity to make a formal request to > the community. > > Regards, > > Phil. > Thanks Philippe, I would like to highlight to the QEMU community here how important this is for SUSE, to see progress for all the series in the migration area that are currently still waiting and competing for attention. The specific features and improvements we are developing or helping to review are a priority for us, and we are concerned about the rate of progress with the existing governance processes. Fabiano is investing a lot of his attention to this area, with features, bugfixes and reviews, but of course it is up to the community as a whole to address the issue so that reviewed work is merged. My attempt here is to make sure that it is recognized as a problem, so it can be hopefully be addressed by the community in a timely fashion, and we can all benefit from the already developed and reviewed work that is pending. Thanks! CLaudio
On 8/30/23 15:09, Claudio Fontana wrote: > On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: >> Hi Claudio, >> >> On 22/8/23 14:00, Claudio Fontana wrote: >>> Hello, >>> >>> this series is all reviewed, >>> >>> and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore >>> when migrating to disk, can it be merged? >> >> $ ./scripts/get_maintainer.pl -f migration/meson.build >> Juan Quintela <quintela@redhat.com> (maintainer:Migration) >> Peter Xu <peterx@redhat.com> (reviewer:Migration) >> Leonardo Bras <leobras@redhat.com> (reviewer:Migration) >> qemu-devel@nongnu.org (open list:All patches CC here) >> >> One maintainer, one single point of failure. When the >> maintainer is busy or offline (vacations?) then everybody >> is stuck. >> >> This is usually solved by adding co-maintainers. >> >> Juan, would you accept having co-maintainers helping you >> dealing with the merge process? I'm not volunteering, but >> this can be a good opportunity to make a formal request to >> the community. >> >> Regards, >> >> Phil. >> > > Thanks Philippe, > > I would like to highlight to the QEMU community here how important this is for SUSE, > > to see progress for all the series in the migration area that are currently still waiting and competing for attention. > > The specific features and improvements we are developing or helping to review are a priority for us, > and we are concerned about the rate of progress with the existing governance processes. > > Fabiano is investing a lot of his attention to this area, with features, bugfixes and reviews, > but of course it is up to the community as a whole to address the issue so that reviewed work is merged. > > My attempt here is to make sure that it is recognized as a problem, so it can be hopefully be addressed by the community in a timely fashion, > and we can all benefit from the already developed and reviewed work that is pending. > > Thanks! > > CLaudio > > Hi Juan, any comments? Would additional help for co-maintenance of live migration help? How can we make things proceed? From our (SUSE) side we are willing to help as much as we can, and all options are open, whatever it takes to get the multiple series currently waiting to flow again. Thanks, Claudio
On 9/13/23 15:00, Claudio Fontana wrote: > On 8/30/23 15:09, Claudio Fontana wrote: >> On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: >>> Hi Claudio, >>> >>> On 22/8/23 14:00, Claudio Fontana wrote: >>>> Hello, >>>> >>>> this series is all reviewed, >>>> >>>> and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore >>>> when migrating to disk, can it be merged? >>> >>> $ ./scripts/get_maintainer.pl -f migration/meson.build >>> Juan Quintela <quintela@redhat.com> (maintainer:Migration) >>> Peter Xu <peterx@redhat.com> (reviewer:Migration) >>> Leonardo Bras <leobras@redhat.com> (reviewer:Migration) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> One maintainer, one single point of failure. When the >>> maintainer is busy or offline (vacations?) then everybody >>> is stuck. >>> >>> This is usually solved by adding co-maintainers. >>> >>> Juan, would you accept having co-maintainers helping you >>> dealing with the merge process? I'm not volunteering, but >>> this can be a good opportunity to make a formal request to >>> the community. >>> >>> Regards, >>> >>> Phil. >>> >> >> Thanks Philippe, >> >> I would like to highlight to the QEMU community here how important this is for SUSE, >> >> to see progress for all the series in the migration area that are currently still waiting and competing for attention. >> >> The specific features and improvements we are developing or helping to review are a priority for us, >> and we are concerned about the rate of progress with the existing governance processes. >> >> Fabiano is investing a lot of his attention to this area, with features, bugfixes and reviews, >> but of course it is up to the community as a whole to address the issue so that reviewed work is merged. >> >> My attempt here is to make sure that it is recognized as a problem, so it can be hopefully be addressed by the community in a timely fashion, >> and we can all benefit from the already developed and reviewed work that is pending. >> >> Thanks! >> >> CLaudio >> >> > > Hi Juan, any comments? Would additional help for co-maintenance of live migration help? > How can we make things proceed? > > From our (SUSE) side we are willing to help as much as we can, and all options are open, > whatever it takes to get the multiple series currently waiting to flow again. > > Thanks, > > Claudio Hi any news here? We continue to see the migration area of QEMU as basically blocked; there are a number of reviewed series out and little progress in merging them, as well as a number of improvements not posted to the list at all due to the situation being completely bottlenecked. Would a co-maintenance of migration/ from Fabiano be an option? Should we organize a call to discuss this if the mailing list does not suffice to discuss this topic? Thank you, Claudio
On Wed, Sep 27, 2023 at 03:14:29PM +0200, Claudio Fontana wrote: > On 9/13/23 15:00, Claudio Fontana wrote: > > On 8/30/23 15:09, Claudio Fontana wrote: > >> On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: > >>> Hi Claudio, > >>> > >>> On 22/8/23 14:00, Claudio Fontana wrote: > >>>> Hello, > >>>> > >>>> this series is all reviewed, > >>>> > >>>> and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore > >>>> when migrating to disk, can it be merged? > >>> > >>> $ ./scripts/get_maintainer.pl -f migration/meson.build > >>> Juan Quintela <quintela@redhat.com> (maintainer:Migration) > >>> Peter Xu <peterx@redhat.com> (reviewer:Migration) > >>> Leonardo Bras <leobras@redhat.com> (reviewer:Migration) > >>> qemu-devel@nongnu.org (open list:All patches CC here) > >>> > >>> One maintainer, one single point of failure. When the > >>> maintainer is busy or offline (vacations?) then everybody > >>> is stuck. > >>> > >>> This is usually solved by adding co-maintainers. > >>> > >>> Juan, would you accept having co-maintainers helping you > >>> dealing with the merge process? I'm not volunteering, but > >>> this can be a good opportunity to make a formal request to > >>> the community. > >>> > >>> Regards, > >>> > >>> Phil. > >>> > >> > >> Thanks Philippe, > >> > >> I would like to highlight to the QEMU community here how important this is for SUSE, > >> > >> to see progress for all the series in the migration area that are currently still waiting and competing for attention. > >> > >> The specific features and improvements we are developing or helping to review are a priority for us, > >> and we are concerned about the rate of progress with the existing governance processes. > >> > >> Fabiano is investing a lot of his attention to this area, with features, bugfixes and reviews, > >> but of course it is up to the community as a whole to address the issue so that reviewed work is merged. > >> > >> My attempt here is to make sure that it is recognized as a problem, so it can be hopefully be addressed by the community in a timely fashion, > >> and we can all benefit from the already developed and reviewed work that is pending. > >> > >> Thanks! > >> > >> CLaudio > >> > >> > > > > Hi Juan, any comments? Would additional help for co-maintenance of live migration help? > > How can we make things proceed? > > > > From our (SUSE) side we are willing to help as much as we can, and all options are open, > > whatever it takes to get the multiple series currently waiting to flow again. > > > > Thanks, > > > > Claudio > > Hi any news here? > > We continue to see the migration area of QEMU as basically blocked; > > there are a number of reviewed series out and little progress in merging them, > as well as a number of improvements not posted to the list at all due to the situation being completely bottlenecked. > > Would a co-maintenance of migration/ from Fabiano be an option? > > Should we organize a call to discuss this if the mailing list does not suffice to discuss this topic? Yes we can. Juan will be back next Monday. Before he left, he told me that he's preparing the pull. If next week there's still no pull from migration side then I suppose someone should start to pick up patches and send PR. I would volunteer myself already; I should have already perpared a pull a long time ago if I got ack from Juan. If Fabiano would like to that'll also be nice. I don't know how that works without delegation from the current (solo) maintainer, though, for either of us to become a maintainer. Before that, Fabiano can already propose a patch as at least a Reviewer without the need of any delegation from anyone, as he already did lots of work in that regard, assume he'll keep doing so to support the migration subsystem. I hope Juan will start to figure things out next week. Thanks,
On Wed, Sep 27, 2023 at 03:14:29PM +0200, Claudio Fontana wrote: > On 9/13/23 15:00, Claudio Fontana wrote: > > On 8/30/23 15:09, Claudio Fontana wrote: > >> On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: > >>> Hi Claudio, > >>> > >>> On 22/8/23 14:00, Claudio Fontana wrote: > >>>> Hello, > >>>> > >>>> this series is all reviewed, > >>>> > >>>> and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore > >>>> when migrating to disk, can it be merged? > >>> > >>> $ ./scripts/get_maintainer.pl -f migration/meson.build > >>> Juan Quintela <quintela@redhat.com> (maintainer:Migration) > >>> Peter Xu <peterx@redhat.com> (reviewer:Migration) > >>> Leonardo Bras <leobras@redhat.com> (reviewer:Migration) > >>> qemu-devel@nongnu.org (open list:All patches CC here) > >>> > >>> One maintainer, one single point of failure. When the > >>> maintainer is busy or offline (vacations?) then everybody > >>> is stuck. > >>> > >>> This is usually solved by adding co-maintainers. > >>> > >>> Juan, would you accept having co-maintainers helping you > >>> dealing with the merge process? I'm not volunteering, but > >>> this can be a good opportunity to make a formal request to > >>> the community. > >> > >> I would like to highlight to the QEMU community here how important this is for SUSE, > >> > >> to see progress for all the series in the migration area that are currently still waiting and competing for attention. > >> > >> The specific features and improvements we are developing or helping to review are a priority for us, > >> and we are concerned about the rate of progress with the existing governance processes. > >> > >> Fabiano is investing a lot of his attention to this area, with features, bugfixes and reviews, > >> but of course it is up to the community as a whole to address the issue so that reviewed work is merged. > >> > >> My attempt here is to make sure that it is recognized as a problem, so it can be hopefully be addressed by the community in a timely fashion, > >> and we can all benefit from the already developed and reviewed work that is pending. > >> > > > > Hi Juan, any comments? Would additional help for co-maintenance of live migration help? > > How can we make things proceed? > > > > From our (SUSE) side we are willing to help as much as we can, and all options are open, > > whatever it takes to get the multiple series currently waiting to flow again. > > > > Thanks, > > > > Claudio > > Hi any news here? > > We continue to see the migration area of QEMU as basically blocked; > > there are a number of reviewed series out and little progress in merging them, > as well as a number of improvements not posted to the list at all due to the situation being completely bottlenecked. > > Would a co-maintenance of migration/ from Fabiano be an option? > > Should we organize a call to discuss this if the mailing list does not suffice to discuss this topic? FWIW, in response to your previous mail, I had suggested to Peter Xu in private that he would make a good candidate of co-maintainer for migration, given he is already a nominated reviewer and has been actively reviewing migration patches for a long while. Migration did have 2 maintainers until earlier in this year when David Gilbert moved on to other things, and I think we can all see that this has had an unfortunate impact on productivity in the migration subsystem that needs to be solved. With regards, Daniel
On Wed, Sep 27, 2023 at 09:56:44AM -0400, Peter Xu wrote: > Juan will be back next Monday. Before he left, he told me that he's > preparing the pull. > > If next week there's still no pull from migration side then I suppose > someone should start to pick up patches and send PR. I would volunteer > myself already; I should have already perpared a pull a long time ago if I > got ack from Juan. If Fabiano would like to that'll also be nice. I don't > know how that works without delegation from the current (solo) maintainer, > though, for either of us to become a maintainer. Even if not actively sending a PR, a possible starting point that could be done today, would be for someone to put up a gitlab.com branch that contains all the outstanding patch series that are considered ready to merge and validate a CI pipeline. That would both serve as a base for further work, and might be useful to Juan in assembling the next pull request. > Before that, Fabiano can already propose a patch as at least a Reviewer > without the need of any delegation from anyone, as he already did lots of > work in that regard, assume he'll keep doing so to support the migration > subsystem. Yes, anyone is free to self-propose themselves as reviewers. With regards, Daniel
On Wed, Sep 27, 2023 at 03:36:16PM +0100, Daniel P. Berrangé wrote: > Even if not actively sending a PR, a possible starting point that could > be done today, would be for someone to put up a gitlab.com branch that > contains all the outstanding patch series that are considered ready > to merge and validate a CI pipeline. That would both serve as a base for > further work, and might be useful to Juan in assembling the next pull > request. Right. Though that'll be slightly conter-productive if Juan already has a branch that contains everything for a pull covering patches until two weeks ago. I think before he left he has that on hand, maybe also tested a bit over the branch. I actually talked to him on taking that branch over for this time if he's busy, but unfortunately that conversation discontinued.. Having another branch has the risk that we'll have two base branches, if Juan's branch will be sent out as the final pull next week and get merged. But I do agree things need to be done if the pull doesn't come next week. Thanks,