| Message ID | 1549638368-530182-1-git-send-email-andrey.shinkevich@virtuozzo.com |
|---|---|
| Headers | show |
| Series | qcow2: Add list of bitmaps to ImageInfoSpecificQCow2 | expand |
On 2/8/19 9:06 AM, Andrey Shinkevich wrote: > v14: > The test 242 was amended to be safer against changes in the bitmap allocation > algorithm because the bitmap directory is reallocated on VM shutdown. > Unfortunately, an empty line at the end of the benchmark file 242.out persists. Easy solution: in 242, add an extra log("Test complete") or similar after the output that produces the blank line, then 242.out will no longer have a trailing blank line.
On 08/02/2019 18:25, Eric Blake wrote: > On 2/8/19 9:06 AM, Andrey Shinkevich wrote: >> v14: >> The test 242 was amended to be safer against changes in the bitmap allocation >> algorithm because the bitmap directory is reallocated on VM shutdown. >> Unfortunately, an empty line at the end of the benchmark file 242.out persists. > > Easy solution: in 242, add an extra log("Test complete") or similar > after the output that produces the blank line, then 242.out will no > longer have a trailing blank line. > Thank you, Eric. It is going to be version 15.
08.02.2019 18:25, Eric Blake wrote: > On 2/8/19 9:06 AM, Andrey Shinkevich wrote: >> v14: >> The test 242 was amended to be safer against changes in the bitmap allocation >> algorithm because the bitmap directory is reallocated on VM shutdown. >> Unfortunately, an empty line at the end of the benchmark file 242.out persists. > > Easy solution: in 242, add an extra log("Test complete") or similar > after the output that produces the blank line, then 242.out will no > longer have a trailing blank line. > with this fixed: Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
On 2/8/19 9:37 AM, Andrey Shinkevich wrote: > > > On 08/02/2019 18:25, Eric Blake wrote: >> On 2/8/19 9:06 AM, Andrey Shinkevich wrote: >>> v14: >>> The test 242 was amended to be safer against changes in the bitmap allocation >>> algorithm because the bitmap directory is reallocated on VM shutdown. >>> Unfortunately, an empty line at the end of the benchmark file 242.out persists. >> >> Easy solution: in 242, add an extra log("Test complete") or similar >> after the output that produces the blank line, then 242.out will no >> longer have a trailing blank line. >> > Thank you, Eric. It is going to be version 15. If that's the only change, then no need to post v15; you can check what I'm preparing to include in Monday's pull request: https://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/nbd
On 08/02/2019 18:53, Eric Blake wrote: > On 2/8/19 9:37 AM, Andrey Shinkevich wrote: >> >> >> On 08/02/2019 18:25, Eric Blake wrote: >>> On 2/8/19 9:06 AM, Andrey Shinkevich wrote: >>>> v14: >>>> The test 242 was amended to be safer against changes in the bitmap allocation >>>> algorithm because the bitmap directory is reallocated on VM shutdown. >>>> Unfortunately, an empty line at the end of the benchmark file 242.out persists. >>> >>> Easy solution: in 242, add an extra log("Test complete") or similar >>> after the output that produces the blank line, then 242.out will no >>> longer have a trailing blank line. >>> >> Thank you, Eric. It is going to be version 15. > > If that's the only change, then no need to post v15; you can check what > I'm preparing to include in Monday's pull request: > > https://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/nbd > Thank you again. With those minor amendments (+spaces) and a couple of the significant "Reviewed-by", the version 15 has been prepared. May I send it or you are OK with the version 14?
On 08/02/2019 18:53, Eric Blake wrote: > On 2/8/19 9:37 AM, Andrey Shinkevich wrote: >> >> >> On 08/02/2019 18:25, Eric Blake wrote: >>> On 2/8/19 9:06 AM, Andrey Shinkevich wrote: >>>> v14: >>>> The test 242 was amended to be safer against changes in the bitmap allocation >>>> algorithm because the bitmap directory is reallocated on VM shutdown. >>>> Unfortunately, an empty line at the end of the benchmark file 242.out persists. >>> >>> Easy solution: in 242, add an extra log("Test complete") or similar >>> after the output that produces the blank line, then 242.out will no >>> longer have a trailing blank line. >>> >> Thank you, Eric. It is going to be version 15. > > If that's the only change, then no need to post v15; you can check what > I'm preparing to include in Monday's pull request: > > https://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/nbd > I followed the link above and saw, thank you. The only difference with my version #15 is that I added the spaces around '*' in the chunk assignment. That's it!