From patchwork Wed Jan 16 18:31:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Xu X-Patchwork-Id: 1026085 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43fwrf6lk1z9sD4 for ; Thu, 17 Jan 2019 05:36:02 +1100 (AEDT) Received: from localhost ([127.0.0.1]:44423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjq2i-0005a8-Ov for incoming@patchwork.ozlabs.org; Wed, 16 Jan 2019 13:36:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjpyY-0002vL-5D for qemu-devel@nongnu.org; Wed, 16 Jan 2019 13:31:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjpyX-00073C-0K for qemu-devel@nongnu.org; Wed, 16 Jan 2019 13:31:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gjpyW-0006v9-Ml for qemu-devel@nongnu.org; Wed, 16 Jan 2019 13:31:40 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14303C07456A; Wed, 16 Jan 2019 18:31:27 +0000 (UTC) Received: from dell-per430-12.lab.eng.pek2.redhat.com (dell-per430-12.lab.eng.pek2.redhat.com [10.73.196.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79E935C1B4; Wed, 16 Jan 2019 18:31:24 +0000 (UTC) From: wexu@redhat.com To: wexu@redhat.com, tiwei.bie@intel.com, qemu-devel@nongnu.org Date: Wed, 16 Jan 2019 13:31:05 -0500 Message-Id: <1547663480-547-1-git-send-email-wexu@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 16 Jan 2019 18:31:27 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 00/15] packed ring virtio-net backends support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, maxime.coquelin@redhat.com, jfreiman@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Xu v1->v2: - fix patchew complaint - only set/get last_avail_idx/wrap_counter for vhost migration(Maxime) - replace 'out_num' and 'in_num' with 'elem_entries'in packed_pop()(Maxime) - set last used idx/wrap_counter to last avail ones when flushing(Maxime) - replace '*host_has_feature()' with '*vdev_has_feature()' for ioctl(Maxime) - replace going through indirect descriptors with desc.len/sizeof(desc)(btw) - add new subsection for packed ring(Jason) rfc v3 -> v1 - migration support for both userspace and vhost-net, need tweak vhost ioctl() to make it work(the code is pasted in the commit message of vhost migration patch #13). Note: the high 32-bit guest feature bit is saved as a subsection for virtio devices which makes packed ring feature bit check unusable when loading the saved per-queue variables(this is done before loading subsection which is the last action for device during migration), so I save and load all the things generally for now, any idea to fix this? - Fixed comments from Jason for rfc v3 sorted by patch #, two comments I didn't take were(from patch) listed here: 09: - introduce new API(virtqueue_fill_n()). - Didn't take it since userspace backend does not support batching, so only one element is popped and current API should be enough. 06 & 07: Refactor split and packed pop()/get_avail_bytes(). - the duplicated code interwined with split/packed ring specific things and it might make it unclear, so I only extracted the few common parts out side rcu and keep the others separate. The other revised comments: 02: - reuse current 'avail/used' for 'driver/device' in VRingMemoryRegionCache. - remove event_idx since shadow_avail_idx works. 03: - move size recalculation to a separate patch. - keep 'avail/used' in current calculation function name. - initialize 'desc' memory region as 'false' for 1.0('true' for 1.1) 04: - delete 'event_idx' 05: - rename 'wc' to wrap_counter. 06: - converge common part outside rcu section for 1.0/1.1. - move memory barrier for the first 'desc' in between checking flag and read other fields. - remove unnecessary memory barriers for indirect descriptors. - no need to destroy indirect memory cache since it is generally done before return from the function. - remove redundant maximum chained descriptors limitation check. - there are some differences(desc name, wrap idx/counter, flags) between split and packed rings, so keep them separate for now. - amend the comment when recording index and wrap counter for a kick from guest. 07: - calculate fields in descriptor instead of read it when filling. - put memory barrier correctly before filling the flags in descriptor. - replace full memory barrier with a write barrier in fill. - shift to read descriptor flags and descriptor necessarily and separately in packed_pop(). - correct memory barrier in packed_pop() as in packed_fill(). 08: - reuse 'shadow_avail_idx' instead of adding a new 'event_idx'. - use the compact and verified vring_packed_need_event() version for vhost net/user. 12: - remove the odd cherry-pick comment. - used bit '15' for wrap_counters. rfc v2->v3 - addressed performance issue - fixed feedback from v2 rfc v1->v2 - sync to tiwei's v5 - reuse memory cache function with 1.0 - dropped detach patch and notification helper(04 & 05 in v1) - guest virtio-net driver unload/reload support - event suppression support(not tested) - addressed feedback from v1 Wei Xu (15): virtio: introduce packed ring definitions virtio: redefine structure & memory cache for packed ring virtio: expand offset calculation for packed ring virtio: add memory region init for packed ring virtio: init wrap counter for packed ring virtio: init and desc empty check for packed ring virtio: get avail bytes check for packed ring virtio: fill/flush/pop for packed ring virtio: event suppression support for packed ring virtio-net: fill head desc after done all in a chain virtio: add userspace migration for packed ring virtio: add vhost-net migration for packed ring virtio: packed ring feature bit for userspace backend vhost: enable packed ring virtio: enable packed ring via a new command line hw/net/vhost_net.c | 2 + hw/net/virtio-net.c | 11 +- hw/virtio/virtio.c | 774 +++++++++++++++++++++++-- include/hw/virtio/virtio.h | 4 +- include/standard-headers/linux/virtio_config.h | 15 + include/standard-headers/linux/virtio_ring.h | 43 ++ 6 files changed, 800 insertions(+), 49 deletions(-)