From patchwork Mon Apr 16 16:56:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Collin Walling X-Patchwork-Id: 898782 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Pvgz3Nvtz9s0t for ; Tue, 17 Apr 2018 02:57:34 +1000 (AEST) Received: from localhost ([::1]:58302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f87Rc-0005Gw-0f for incoming@patchwork.ozlabs.org; Mon, 16 Apr 2018 12:57:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f87Qk-0005BR-3w for qemu-devel@nongnu.org; Mon, 16 Apr 2018 12:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f87Qg-0001Fr-2W for qemu-devel@nongnu.org; Mon, 16 Apr 2018 12:56:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51466) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f87Qf-0001FO-RE for qemu-devel@nongnu.org; Mon, 16 Apr 2018 12:56:34 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3GGnsmQ093534 for ; Mon, 16 Apr 2018 12:56:32 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hcxyfje32-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 16 Apr 2018 12:56:32 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Apr 2018 10:56:31 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Apr 2018 10:56:29 -0600 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3GGuRXS13566268; Mon, 16 Apr 2018 09:56:27 -0700 Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A606AC603E; Mon, 16 Apr 2018 10:56:27 -0600 (MDT) Received: from collin-ThinkPad-W541.pok.ibm.com (unknown [9.56.58.57]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 2E896C603C; Mon, 16 Apr 2018 10:56:27 -0600 (MDT) From: Collin Walling To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, cohuck@redhat.com, thuth@redhat.com, borntraeger@de.ibm.com Date: Mon, 16 Apr 2018 12:56:06 -0400 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 18041616-0016-0000-0000-0000088C5344 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008864; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01018816; UDB=6.00519711; IPR=6.00798057; MB=3.00020601; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-16 16:56:31 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041616-0017-0000-0000-00003E4833AE Message-Id: <1523897770-30155-1-git-send-email-walling@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-16_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804160151 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frankja@linux.ibm.com, gor@linux.ibm.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Change Log: v3 - added r-b's - added check around memset v2 - added r-b's - s/zipl_println/zipl_print_entry - prints entry and returns entry number - while loop now handles valid_entries These patches fix the following: - The QEMU zIPL boot menu does not allow accurate selection of non-sequential entries. - The QEMU zIPL boot menu does not have all the capabilities of the real zIPL menu (such as commandline args). We should print a different banner to reflect this. - The loadparm array in main.c can end up being not null terminated when converted to an integer via atoui. - A loadparm set to an empty string does not allow a boot menu. Collin Walling (4): pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES pc-bios/s390-ccw: fix loadparm initialization and int conversion pc-bios/s390-ccw: fix non-sequential boot entries (eckd) pc-bios/s390-ccw: fix non-sequential boot entries (enum) hw/s390x/ipl.c | 4 ++++ pc-bios/s390-ccw/bootmap.c | 16 +++++++------ pc-bios/s390-ccw/bootmap.h | 2 -- pc-bios/s390-ccw/main.c | 14 +++++------ pc-bios/s390-ccw/menu.c | 58 +++++++++++++++++++++++++++++++-------------- pc-bios/s390-ccw/s390-ccw.h | 4 +++- 6 files changed, 63 insertions(+), 35 deletions(-)