mbox series

[v2,0/4] Small fixes for s390x QEMU boot menu

Message ID 1523657288-6587-1-git-send-email-walling@linux.ibm.com
Headers show
Series Small fixes for s390x QEMU boot menu | expand

Message

Collin Walling April 13, 2018, 10:08 p.m. UTC 
Change Log:

    v2

        - added r-b's
        - s/zipl_println/zipl_print_entry
            - prints entry and returns entry number
        - while loop now handles valid_entries

These patches fix the following:

    - The QEMU zIPL boot menu does not allow accurate selection of
        non-sequential entries.

    - The QEMU zIPL boot menu does not have all the capabilities of the
        real zIPL menu (such as commandline args). We should print a different
        banner to reflect this.

    - The loadparm array in main.c can end up being not null terminated when
        converted to an integer via atoui.

    - A loadparm set to an empty string does not allow a boot menu.


Collin Walling (4):
  pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
  pc-bios/s390-ccw: fix loadparm initialization and int conversion
  pc-bios/s390-ccw: fix non-sequential boot entries (eckd)
  pc-bios/s390-ccw: fix non-sequential boot entries (enum)

 hw/s390x/ipl.c              |  2 ++
 pc-bios/s390-ccw/bootmap.c  | 16 +++++++------
 pc-bios/s390-ccw/bootmap.h  |  2 --
 pc-bios/s390-ccw/main.c     | 14 +++++------
 pc-bios/s390-ccw/menu.c     | 58 +++++++++++++++++++++++++++++++--------------
 pc-bios/s390-ccw/s390-ccw.h |  4 +++-
 6 files changed, 61 insertions(+), 35 deletions(-)

Comments

Janosch Frank April 16, 2018, 8:43 a.m. UTC | #1 
On 14.04.2018 00:08, Collin Walling wrote:
> Change Log:
> 
>     v2
> 
>         - added r-b's
>         - s/zipl_println/zipl_print_entry
>             - prints entry and returns entry number
>         - while loop now handles valid_entries

Series reviewed-by: Janosch Frank <frankja@linux.ibm.com>

> 
> These patches fix the following:
> 
>     - The QEMU zIPL boot menu does not allow accurate selection of
>         non-sequential entries.
> 
>     - The QEMU zIPL boot menu does not have all the capabilities of the
>         real zIPL menu (such as commandline args). We should print a different
>         banner to reflect this.
> 
>     - The loadparm array in main.c can end up being not null terminated when
>         converted to an integer via atoui.
> 
>     - A loadparm set to an empty string does not allow a boot menu.
> 
> 
> Collin Walling (4):
>   pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
>   pc-bios/s390-ccw: fix loadparm initialization and int conversion
>   pc-bios/s390-ccw: fix non-sequential boot entries (eckd)
>   pc-bios/s390-ccw: fix non-sequential boot entries (enum)
> 
>  hw/s390x/ipl.c              |  2 ++
>  pc-bios/s390-ccw/bootmap.c  | 16 +++++++------
>  pc-bios/s390-ccw/bootmap.h  |  2 --
>  pc-bios/s390-ccw/main.c     | 14 +++++------
>  pc-bios/s390-ccw/menu.c     | 58 +++++++++++++++++++++++++++++++--------------
>  pc-bios/s390-ccw/s390-ccw.h |  4 +++-
>  6 files changed, 61 insertions(+), 35 deletions(-)
>