From patchwork Mon Nov 4 11:03:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Huettner X-Patchwork-Id: 2006163 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr; dkim=fail reason="signature verification failed" (2048-bit key) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XhpWj72wmz1xxN for ; Mon, 4 Nov 2024 22:04:33 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E661F4059D; Mon, 4 Nov 2024 11:04:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ZQiWkM__EYk9; Mon, 4 Nov 2024 11:04:29 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1ADA7405B8 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr; dkim=fail reason="signature verification failed" (2048-bit key) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1ADA7405B8; Mon, 4 Nov 2024 11:04:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EFE45C08A6; Mon, 4 Nov 2024 11:04:28 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1E26CC08A6 for ; Mon, 4 Nov 2024 11:04:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9EB718103B for ; Mon, 4 Nov 2024 11:04:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TvUEjJiWAwfK for ; Mon, 4 Nov 2024 11:04:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2613::609; helo=eur05-vi1-obe.outbound.protection.outlook.com; envelope-from=felix.huettner@stackit.cloud; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 471B981026 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=stackit.cloud DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 471B981026 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr; dkim=pass (2048-bit key) header.d=stackit.cloud header.i=@stackit.cloud header.a=rsa-sha256 header.s=selector1 header.b=ltevSNpr Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20609.outbound.protection.outlook.com [IPv6:2a01:111:f403:2613::609]) by smtp1.osuosl.org (Postfix) with ESMTPS id 471B981026 for ; Mon, 4 Nov 2024 11:04:12 +0000 (UTC) ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=F4gFfYVhLiT//okHsSDDZM1YyThnfaFYEsksMeZZ3t+qtOAGfBhVYZxFh04A+cry8O1HeDwo3ajAD5ltV1gsij9q6aYFGCZjLWRvvuhmtLORYJlD/hWFLzogWdd55T7EeoFjj0CsZp/O+HDNznmERhfQGLuRhphK8lBk0UlL0JOro6Hvym3XKqMBcpZ8NLt982ISrZS2oUnHss/WmL+JXpZtPMbbEzEY0l4sPpYCFrJyJnNNf5KghFYjyi1F9vGgcYGD9GkhKTjq6kkE8ZuAVisrHV1l9cW40a9rB7dRbqQ473PkaVx6xESEyXpY0Vkq1/LJ9PS1BG2qJbZR5F1PJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAkfVrD6b+mr/QfAKXhHzALbl3j96iVKj8yUcfweE3E=; b=o+5V+3Y4FITOiMT/t4XR0qHda8+30lctT16rimCM+NfmpFgJqtPL85FKCOjz6vbDzk6ZrgdREYQUE2xTy/RVhDaW2s9J/z6DMtdpLyzeyw0/3+P/7yBYKSrKJvdzkFvN/2FyXZYLNmeCiN3VVK5tNv9RRocRhgGVN4IEsvZQBL6/pAJ8e8HrIrfpWYbiRWSVJ2eMJpXkjm4n128/tSkzUCg90JfNI15XUqlc3bUkZeXoZrwDQ3a6OzY2ZFJAf2ZPR+fXXu2mt+dbOn4PXyw01ksz65cXSOlnB/Vvw4kBcOdbkVPsmZVKmD5kwR99bXh/qz5Q4GVRgbpjbot5kEtycw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=fail (sender ip is 52.169.0.179) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=stackit.cloud; dmarc=pass (p=reject sp=none pct=100) action=none header.from=stackit.cloud; dkim=pass (signature was verified) header.d=stackit.cloud; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=stackit.cloud] dkim=[1,1,header.d=stackit.cloud] dmarc=[1,1,header.from=stackit.cloud]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackit.cloud; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAkfVrD6b+mr/QfAKXhHzALbl3j96iVKj8yUcfweE3E=; b=ltevSNprCX0/3dQFOBPLxO8Za5s0Zh5IhfBMSzX0JTy5laZUko+MF4/CLQ5TQN0ct8D//Y7WgoGAEv6DVUyLS+sK7Iw+2twrtjnoH8oONIwnIDHFDBgzCxhVY0KArKEMKSlLCwZcY3PFlEQxT+bGYOdvrWtUyJBw6PCCW8NWwjNqctbH0RMzYmWHfuT0sCe9NbTSCgnXWcstjHx+uCAgbQDTvyr9yncdFqpQMjgUvmwIK1K7cAD6jnwvUeVQPA5mJazfv9hSFtwchLuZLtrENXp6CQr+tTrpu1yar1ueXFdfTR+UbWNRzADZvJWXeuF7O1/l14B5leNyabL1FqxMkQ== Received: from AS9PR05CA0337.eurprd05.prod.outlook.com (2603:10a6:20b:490::9) by GVXPR10MB8664.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:1de::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.17; Mon, 4 Nov 2024 11:04:06 +0000 Received: from AMS0EPF00000195.eurprd05.prod.outlook.com (2603:10a6:20b:490:cafe::c6) by AS9PR05CA0337.outlook.office365.com (2603:10a6:20b:490::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.30 via Frontend Transport; Mon, 4 Nov 2024 11:04:06 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 52.169.0.179) smtp.mailfrom=stackit.cloud; dkim=pass (signature was verified) header.d=stackit.cloud;dmarc=pass action=none header.from=stackit.cloud; Received-SPF: Fail (protection.outlook.com: domain of stackit.cloud does not designate 52.169.0.179 as permitted sender) receiver=protection.outlook.com; client-ip=52.169.0.179; helo=eu2.smtp.exclaimer.net; Received: from eu2.smtp.exclaimer.net (52.169.0.179) by AMS0EPF00000195.mail.protection.outlook.com (10.167.16.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.17 via Frontend Transport; Mon, 4 Nov 2024 11:04:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (104.47.18.108) by eu2.smtp.exclaimer.net (52.169.0.179) with Exclaimer Signature Manager ESMTP Proxy eu2.smtp.exclaimer.net (tlsversion=TLS12, tlscipher=TLS_DIFFIEHELLMAN_WITH_AES256_NONE); Mon, 4 Nov 2024 11:04:06 +0000 X-ExclaimerHostedSignatures-MessageProcessed: true X-ExclaimerProxyLatency: 57316839 X-ExclaimerImprintLatency: 42783443 X-ExclaimerImprintAction: bdf01cf027fe42468a356e75ce1fc997 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T7lEnJv4GTm6UAXjVxuDEkt1jCC3XhgGWTZQFG7rss8fwGGopDFwZEhSME1jrOJmcMRrlZej0h0NMgGYUVFDGcVBQPZ/tAVJ7hnH82wEQUzAXJI+L2pD18ZVAAxrGcbz+qP5FBEVAeTQytMtmDD//NmWRL9/sfoB+OF/r89Oi0N3SQzAHeXGVHbeNoQnTV/6Oi1IxA2vOa+90jckTEkUZuUDTn9U7HbefOcnP6o01BKY5ufmNvfVInAR9qULLObmgFXlfHtVNRK9PqzHqoMK7ql/fiE6bDz674EY0LumI2iMyWG/CPb2ICPInNr2edn88Ovo2jgYalvm7OszqxFDDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAkfVrD6b+mr/QfAKXhHzALbl3j96iVKj8yUcfweE3E=; b=Gwt4XR6XeAO7rIafqnkL4ZdsZoZJ+WD2TM9VzXiEF1wlu/TZvzcgMFL3cfecDsSUSuCwaDaeMEGlXZNp22dcNOBSdj5hXDSAWVlphNx53+w3VWpHQB2Viidu3zspvBlYdNYEatiLyRcKnXAjZCTJgANthpp2QI2RosZjZLnj6Zx0idSX1Qmiqnxrs8bBKfNjWUclRX608e22Z8Z9NNRvccC68oA7i9C2LPm9Q2zFTBBmcpzFgjncIXi72wuY4t5O2KnKAIDJhZsWhD+vz+ItSDspboe7eFW2RpgdwbsOSNmYleYxEUjCbzdD79tw7SCCzZcsKXKgl9gnuMwpuYpwqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stackit.cloud; dmarc=pass action=none header.from=stackit.cloud; dkim=pass header.d=stackit.cloud; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackit.cloud; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAkfVrD6b+mr/QfAKXhHzALbl3j96iVKj8yUcfweE3E=; b=ltevSNprCX0/3dQFOBPLxO8Za5s0Zh5IhfBMSzX0JTy5laZUko+MF4/CLQ5TQN0ct8D//Y7WgoGAEv6DVUyLS+sK7Iw+2twrtjnoH8oONIwnIDHFDBgzCxhVY0KArKEMKSlLCwZcY3PFlEQxT+bGYOdvrWtUyJBw6PCCW8NWwjNqctbH0RMzYmWHfuT0sCe9NbTSCgnXWcstjHx+uCAgbQDTvyr9yncdFqpQMjgUvmwIK1K7cAD6jnwvUeVQPA5mJazfv9hSFtwchLuZLtrENXp6CQr+tTrpu1yar1ueXFdfTR+UbWNRzADZvJWXeuF7O1/l14B5leNyabL1FqxMkQ== Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=stackit.cloud; Received: from PAVPR10MB6914.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:30d::9) by PAVPR10MB6861.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:321::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.15; Mon, 4 Nov 2024 11:03:59 +0000 Received: from PAVPR10MB6914.EURPRD10.PROD.OUTLOOK.COM ([fe80::f00d:feeb:e45e:54f8]) by PAVPR10MB6914.EURPRD10.PROD.OUTLOOK.COM ([fe80::f00d:feeb:e45e:54f8%7]) with mapi id 15.20.8137.013; Mon, 4 Nov 2024 11:03:59 +0000 Date: Mon, 4 Nov 2024 12:03:51 +0100 To: dev@openvswitch.org Message-ID: <7cefd4f392baa4fdbfaf3130ef2c08c8e71c9c58.1730713432.git.felix.huettner@stackit.cloud> Mail-Followup-To: dev@openvswitch.org References: Content-Disposition: inline In-Reply-To: X-please-dont-add-a-signature: thanks X-ClientProxiedBy: FR3P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::15) To PAVPR10MB6914.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:30d::9) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAVPR10MB6914:EE_|PAVPR10MB6861:EE_|AMS0EPF00000195:EE_|GVXPR10MB8664:EE_ X-MS-Office365-Filtering-Correlation-Id: 4867279b-4e01-4944-fe0d-08dcfcc066cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info-Original: vWuwYplpKIKU36JMkxBBnX2ExFeipYmsnCqiSQMkA04jwPm6bvQu56NAosXpd6Kgd/k3dRnZ6/hz8bdcq+z3T48RrJClElTs2Jcdcgpo88WBXU0k7pLEocESuECT0lSzcsfLzqM72MNl7pLjMousKAZZLsT55KV24/8n1+9GSEGE++WdLJaIurv0cqU3ymnYu0ZY8Y4+Ck27rPe4XQMoVUSNV6PNoS2G8jHJS5sqTNz9hbofJA0Ds3zMrmju7vgM3DGcpKYD1UnygfQkl3Vbi91mekBpxbtEIWgsdY1vDDW/lchIqOeNj/JbQxWdC+eyIQqmqyrkf6duOQVbXV8VzRzGXpWo6jIbcCopnGoGSU5CvrdVQRi4D8uHSu6GMM8NCsollBMphS7aTrU1h3fM2yHnq6cihvLDdyAMo3EVyWurD6GaIUI24erJohFccCN2vLbppIQjz/X5qd4fiF91yOIQQ3ck+y9ZV+p8iO6GTLD0FSiSII9k3RAlLRO5M5zZ7WQNLBiYfQKdCa8wQGwYiSr4z0RjIUkrlBrqS+RTGJrhGxe5sz0pNSkp5+DqYdR3wu3v7Szd2ibKVeAR75QcueikcLr7U36nchTFfGtcdY0uu//ScoHQBO+JpXBGdD2KK9VdeJSR/LA7JK7kVsg1uelMS4VZIVVY0/Pzi9cLs3zxA5M4tzRUxRFIl1hoc215UA8pjfMCzclb725Hd2bNjRzl8XU4DqTrdMN4IK+OnEZdSrGNcwUTKUgzDhs+jGEMBoXrueNign9hFuv5v/KkcCmaj7Ev7O/KzZCvABiuHqCNSxV/uJnLKBOiSt96fRyp7IV+PpKFH0hHncR3ATvJXd6LF4e7q4RSd1/PhnSfuYTreG0anHdSwAy4z7I5ZN8JCwPcOZ5dWS8t9WVM0jcKd+wnmiN3JS2IcGpNeQXlFe/5Iq2Tuf2JrqvhuXT38ZSWP6DDSxgSpWIoqarP8q5d0n4OaWzSi24Zjygk3tSS/3KmkF4wR0NdaVVp114rMJ+tdpwKKhkqhSr/8cp1Ct/NW7d7sI0gVJEzSseKTsKnwupzO5+Wnt427sm6FMkEHft+UNiM5Q9y4BQoLbWgf8v8gTwRPZcbZ+2gVBkeSdt6Igk0SYYsl4DzFiGK1OhTR1ACjyAbHkXun95oaRMj/ssk4+ZZRgvRCu+cNl/+Cy7j3RKgXnM3J5zq9DsebswLvdBkMXmrDgTjTxtukUasm+h57hQTB1GIBGxjMyw+/KXd4uAF07k0zxg95xqV8SO7TBdiD9RNhuKrKpTkNSywenvi9hhnGjjuUkPEgrSK3JmisPQ/hpREWbwhMjtM3Qq6bhAE X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAVPR10MB6914.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR10MB6861 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000195.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 23a11fc3-6837-42f5-9213-08dcfcc06265 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|82310400026|1800799024|35042699022|14060799003; X-Microsoft-Antispam-Message-Info: Ef9wQQPvxzTWczZIirObO+mNTXEX7sREVk0tQsh3/dFS5DyGHzUKMlpYMEruahMLIqmtdkwK/TCGHYQz7EmlIEAJz11lg074G0LggPAz/89gjSzvLa157zKou1BqTeYCNcuVRS5+eVyo0WnTMR1PFB80+ZOsOg4Qe4BBZVLjOjAw1LSmW1mQEKU1ZJ80tIKJPmsz0BhUS5BqJ7f9NxEbwHrfv9sM0K2TlzC9E/qG1Zvrt4Bdp2Vkw54Sv6tnjYTdb4Q08d5YukvKWmmV1q0S7OYtYhi/kKXVw+ovn5OLdQ/qS0DDOmuu7O+lfl5sVo9w5vsU50Bjb1z/IiBu6Etk4uTl/KAyuZvq+MU1pqHBIevMMB8hpTlwkdl1Fohnx6CY5EDgXzv2blMG7eM7NkhPC0tInNDA2AnZRXQbd+wwSUF5vu7l10i3d7pnqIT3CTB51ELMF7LHY67YjTP/y03MdAI79f6Y52yvtKIt+CgNbM4aSKBOZU5gAboe70o6hQ7nhzTNdTRm2dYVhvAAit7ypRldvNsWOT+IaLjSa8z+KkOC83gX55Xu911yeMoN9oUBW1vvhePPd617eNL+RogTW2dKCiWqGkDQ1j7j+F5QFuqvajeDbf+imMhT6Z6/DvYLavgGzm0jbvc/Tft3MnOJDfbjjoffvpio7tnt/PaBd7scQqj4IeyyE3ep4sCYLMthqWgwTEizM4qR0dZQrjhLtSUvhFIi4pPOZ6s1ibveJVjTOlL++z6kCGY4B0TVB5ffmgtg3WA7ZFS5vzrLQCn6JvQhg+C4GcIRh2wsJc0zDfOglEMyLeBSztccFsZ28BgT5vYJQVTqXg36X/6YX7D0Rqn6mIWvDn+0eAVMVIDM6W62w2MxfCGP8KfDu3ewoKtNUOm4Gse/6vkAWHl2XkwpfzDW2CRnh0TnjektvK3dxJ4wgJuBlEKNbOC0pzLk5aCourbEaSkIVox5iKgNCGkajqnb/VPbsdZBT6xnGp581XAqMr48esMrsbCvoJZqzUEFfN6HfFjyQ0NgKzNB3GUpgVoANcbvBFt5krdZUeLAi9fLSUWItP93IDuT8FJRGRMiLtCSvc3EJ0NMZDDCauo6a5CSEHQNKCAYljs05wXbLlI6bt9OsFttY4/ivtA9LimPKmpMZ2VYqv1bOry6FK78D6Eq5IS2SCX9l4jSwKqWU1iPULx7X/f9GXMEtHplGkl0I6Oy91VwkmrB5IMms52TQbON9NhiLLMjlL88xj9ckBTWV7nnamZNJbMVnCXup5lDPqO4AX7n0B03oCo9a3JhZn07sJf45ZqUO85jcnLrID3LXyMN2ajDflNlMBY74fVwhs+GCtj27Vj3kjV0U5r52XBSnVLa4j6W9KNpRRfE9TkEOK1b8zohFlWhFCK6PV7YNfbkibU7y99mp22lUVYCZw== X-Forefront-Antispam-Report: CIP:52.169.0.179; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:eu2.smtp.exclaimer.net; PTR:eu2.smtp.exclaimer.net; CAT:NONE; SFS:(13230040)(376014)(36860700013)(82310400026)(1800799024)(35042699022)(14060799003); DIR:OUT; SFP:1101; X-OriginatorOrg: stackit.cloud X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2024 11:04:01.6992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4867279b-4e01-4944-fe0d-08dcfcc066cc X-MS-Exchange-CrossTenant-Id: d04f4717-5a6e-4b98-b3f9-6918e0385f4c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d04f4717-5a6e-4b98-b3f9-6918e0385f4c; Ip=[52.169.0.179]; Helo=[eu2.smtp.exclaimer.net] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000195.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB8664 Subject: [ovs-dev] [PATCH ovn v2 04/32] northd: Store outport of parsed_route. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Felix Huettner via dev From: Felix Huettner Reply-To: Felix Huettner Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" We already determine the outport of a parsed_route in parsed_routes_add. However we previously ignored it and recalculated it later on. Now we just store it for later usage. Signed-off-by: Felix Huettner --- v1->v2: * fix memory leak * fix incorrect comparison of struct parsed_route lib/ovn-util.h | 15 +++++++++ northd/northd.c | 85 +++++++++++++++++++++++++------------------------ northd/northd.h | 2 ++ 3 files changed, 61 insertions(+), 41 deletions(-) diff --git a/lib/ovn-util.h b/lib/ovn-util.h index 7b98b9b9a..2e2f31a36 100644 --- a/lib/ovn-util.h +++ b/lib/ovn-util.h @@ -484,4 +484,19 @@ void ovn_exit_args_finish(struct ovn_exit_args *exit_args); bool ovn_update_swconn_at(struct rconn *swconn, const char *target, int probe_interval, const char *where); +/* Return true if both strings are either NULL or equal to each other */ +static inline bool +streq(const char *s1, const char *s2) +{ + if (s1) { + if (s2 && !strcmp(s1, s2)) { + return true; + } + } else if (!s2) { + return true; + } + return false; +} + + #endif /* OVN_UTIL_H */ diff --git a/northd/northd.c b/northd/northd.c index 8ba7b8c33..b208a3617 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -11066,12 +11066,29 @@ parsed_route_lookup(struct hmap *routes, size_t hash, continue; } + if (pr->out_port != new_pr->out_port) { + continue; + } + + if (!streq(pr->lrp_addr_s, new_pr->lrp_addr_s)) { + continue; + } + return pr; } return NULL; } +static void +parsed_route_free(struct parsed_route *pr) { + if (pr->lrp_addr_s) { + free(pr->lrp_addr_s); + } + + free(pr); +} + static void parsed_routes_add(struct ovn_datapath *od, const struct hmap *lr_ports, const struct nbrec_logical_router_static_route *route, @@ -11125,10 +11142,12 @@ parsed_routes_add(struct ovn_datapath *od, const struct hmap *lr_ports, } /* Verify that ip_prefix and nexthop are on the same network. */ + const char *lrp_addr_s = NULL; + struct ovn_port *out_port = NULL; if (!is_discard_route && !find_static_route_outport(od, lr_ports, route, IN6_IS_ADDR_V4MAPPED(&prefix), - NULL, NULL)) { + &lrp_addr_s, &out_port)) { return; } @@ -11175,6 +11194,10 @@ parsed_routes_add(struct ovn_datapath *od, const struct hmap *lr_ports, "ecmp_symmetric_reply", false); new_pr->is_discard_route = is_discard_route; + if (!is_discard_route) { + new_pr->lrp_addr_s = xstrdup(lrp_addr_s); + } + new_pr->out_port = out_port; size_t hash = uuid_hash(&od->key); struct parsed_route *pr = parsed_route_lookup(routes, hash, new_pr); @@ -11182,7 +11205,7 @@ parsed_routes_add(struct ovn_datapath *od, const struct hmap *lr_ports, hmap_insert(routes, &new_pr->key_node, hash); } else { pr->stale = false; - free(new_pr); + parsed_route_free(new_pr); } } @@ -11211,7 +11234,7 @@ build_parsed_routes(struct ovn_datapath *od, const struct hmap *lr_ports, } hmap_remove(routes, &pr->key_node); - free(pr); + parsed_route_free(pr); } } @@ -11559,8 +11582,7 @@ add_ecmp_symmetric_reply_flows(struct lflow_table *lflows, static void build_ecmp_route_flow(struct lflow_table *lflows, struct ovn_datapath *od, - const struct hmap *lr_ports, struct ecmp_groups_node *eg, - struct lflow_ref *lflow_ref) + struct ecmp_groups_node *eg, struct lflow_ref *lflow_ref) { bool is_ipv4 = IN6_IS_ADDR_V4MAPPED(&eg->prefix); @@ -11608,20 +11630,14 @@ build_ecmp_route_flow(struct lflow_table *lflows, struct ovn_datapath *od, LIST_FOR_EACH (er, list_node, &eg->route_list) { const struct parsed_route *route_ = er->route; const struct nbrec_logical_router_static_route *route = route_->route; - /* Find the outgoing port. */ - const char *lrp_addr_s = NULL; - struct ovn_port *out_port = NULL; - if (!find_static_route_outport(od, lr_ports, route, is_ipv4, - &lrp_addr_s, &out_port)) { - continue; - } /* Symmetric ECMP reply is only usable on gateway routers. * It is NOT usable on distributed routers with a gateway port. */ if (smap_get(&od->nbr->options, "chassis") && route_->ecmp_symmetric_reply && sset_add(&visited_ports, - out_port->key)) { - add_ecmp_symmetric_reply_flows(lflows, od, lrp_addr_s, out_port, + route_->out_port->key)) { + add_ecmp_symmetric_reply_flows(lflows, od, route_->lrp_addr_s, + route_->out_port, route_, &route_match, lflow_ref); } @@ -11638,9 +11654,9 @@ build_ecmp_route_flow(struct lflow_table *lflows, struct ovn_datapath *od, is_ipv4 ? REG_NEXT_HOP_IPV4 : REG_NEXT_HOP_IPV6, route->nexthop, is_ipv4 ? REG_SRC_IPV4 : REG_SRC_IPV6, - lrp_addr_s, - out_port->lrp_networks.ea_s, - out_port->json_key); + route_->lrp_addr_s, + route_->out_port->lrp_networks.ea_s, + route_->out_port->json_key); ovn_lflow_add_with_hint(lflows, od, S_ROUTER_IN_IP_ROUTING_ECMP, 100, ds_cstr(&match), ds_cstr(&actions), &route->header_, lflow_ref); @@ -11720,35 +11736,22 @@ add_route(struct lflow_table *lflows, struct ovn_datapath *od, static void build_static_route_flow(struct lflow_table *lflows, struct ovn_datapath *od, - const struct hmap *lr_ports, const struct parsed_route *route_, const struct sset *bfd_ports, struct lflow_ref *lflow_ref) { - const char *lrp_addr_s = NULL; - struct ovn_port *out_port = NULL; - const struct nbrec_logical_router_static_route *route = route_->route; - /* Find the outgoing port. */ - if (!route_->is_discard_route) { - if (!find_static_route_outport(od, lr_ports, route, - IN6_IS_ADDR_V4MAPPED(&route_->prefix), - &lrp_addr_s, &out_port)) { - return; - } - } - int ofs = !strcmp(smap_get_def(&route->options, "origin", ""), ROUTE_ORIGIN_CONNECTED) ? ROUTE_PRIO_OFFSET_CONNECTED : ROUTE_PRIO_OFFSET_STATIC; char *prefix_s = build_route_prefix_s(&route_->prefix, route_->plen); - add_route(lflows, route_->is_discard_route ? od : out_port->od, out_port, - lrp_addr_s, prefix_s, route_->plen, route->nexthop, - route_->is_src_route, route_->route_table_id, - bfd_ports, &route->header_, route_->is_discard_route, - ofs, lflow_ref); + add_route(lflows, route_->is_discard_route ? od : route_->out_port->od, + route_->out_port, route_->lrp_addr_s, prefix_s, + route_->plen, route->nexthop, route_->is_src_route, + route_->route_table_id, bfd_ports, &route->header_, + route_->is_discard_route, ofs, lflow_ref); free(prefix_s); } @@ -13523,7 +13526,7 @@ build_ip_routing_flows_for_lrp(struct ovn_port *op, static void build_static_route_flows_for_lrouter( struct ovn_datapath *od, struct lflow_table *lflows, - const struct hmap *lr_ports, struct hmap *parsed_routes, + struct hmap *parsed_routes, struct simap *route_tables, const struct sset *bfd_ports, struct lflow_ref *lflow_ref) { @@ -13572,11 +13575,11 @@ build_static_route_flows_for_lrouter( HMAP_FOR_EACH (group, hmap_node, &ecmp_groups) { /* add a flow in IP_ROUTING, and one flow for each member in * IP_ROUTING_ECMP. */ - build_ecmp_route_flow(lflows, od, lr_ports, group, lflow_ref); + build_ecmp_route_flow(lflows, od, group, lflow_ref); } const struct unique_routes_node *ur; HMAP_FOR_EACH (ur, hmap_node, &unique_routes) { - build_static_route_flow(lflows, od, lr_ports, ur->route, + build_static_route_flow(lflows, od, ur->route, bfd_ports, lflow_ref); } ecmp_groups_destroy(&ecmp_groups); @@ -17062,7 +17065,7 @@ build_lswitch_and_lrouter_iterate_by_lr(struct ovn_datapath *od, lsi->meter_groups, NULL); build_ND_RA_flows_for_lrouter(od, lsi->lflows, NULL); build_ip_routing_pre_flows_for_lrouter(od, lsi->lflows, NULL); - build_static_route_flows_for_lrouter(od, lsi->lflows, lsi->lr_ports, + build_static_route_flows_for_lrouter(od, lsi->lflows, lsi->parsed_routes, lsi->route_tables, lsi->bfd_ports, NULL); build_mcast_lookup_flows_for_lrouter(od, lsi->lflows, &lsi->match, @@ -17653,7 +17656,7 @@ void build_lflows(struct ovsdb_idl_txn *ovnsb_txn, /* Parallel build may result in a suboptimal hash. Resize the * lflow map to a correct size before doing lookups */ lflow_table_expand(lflows); - + stopwatch_start(LFLOWS_TO_SB_STOPWATCH_NAME, time_msec()); lflow_table_sync_to_sb(lflows, ovnsb_txn, input_data->ls_datapaths, input_data->lr_datapaths, @@ -18833,7 +18836,7 @@ static_routes_destroy(struct static_routes_data *data) { struct parsed_route *r; HMAP_FOR_EACH_POP (r, key_node, &data->parsed_routes) { - free(r); + parsed_route_free(r); } hmap_destroy(&data->parsed_routes); diff --git a/northd/northd.h b/northd/northd.h index 8f76d642d..728fa6740 100644 --- a/northd/northd.h +++ b/northd/northd.h @@ -707,6 +707,8 @@ struct parsed_route { bool is_discard_route; const struct nbrec_logical_router *nbr; bool stale; + char *lrp_addr_s; + struct ovn_port *out_port; }; void ovnnb_db_run(struct northd_input *input_data,