From patchwork Mon Nov 25 14:04:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MJ Ponsonby X-Patchwork-Id: 2014937 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=VVXnrmkt; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XxnXB0NLMz1xrk for ; Tue, 26 Nov 2024 01:04:56 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2327081087; Mon, 25 Nov 2024 14:04:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ciTqHbKsPfUW; Mon, 25 Nov 2024 14:04:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 40C8080FBA Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=VVXnrmkt Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 40C8080FBA; Mon, 25 Nov 2024 14:04:53 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D3CB8C08A9; Mon, 25 Nov 2024 14:04:52 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 74BF0C08A8 for ; Mon, 25 Nov 2024 14:04:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 67B4581087 for ; Mon, 25 Nov 2024 14:04:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QpI1A6YhNq54 for ; Mon, 25 Nov 2024 14:04:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.120; helo=smtp-relay-canonical-0.canonical.com; envelope-from=mj.ponsonby@canonical.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4397A80F05 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=canonical.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4397A80F05 Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4397A80F05 for ; Mon, 25 Nov 2024 14:04:49 +0000 (UTC) Received: from FortunateSon.Home (unknown [90.202.5.185]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id CEC303F1C5; Mon, 25 Nov 2024 14:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1732543486; bh=eMUFbhQQ9ftr0Mx/4UoPdC7eVxSfBEKbHHcZE6EG5/A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VVXnrmktdDKrm9qoc9eCtb9AtVEt0n3ay6cPuLHAbYePr7ZAIzCufd/BssOKFGihB Y1nW/ldJ+RdAGsxVgisWs3rGt00OCG/63jVwM/qHkFiNp0eeTHVy9k2ql0WyjjXt/C lGjS7OUeiQiEt0b4U6vZGsB88zBynPuKw96oyzJm8TsNKYJIHQvec8ZTyuqudrS8Py rdH/M0tJsDKT6cgNWeY+eNA9+XT2QkB6Dhqr8e/i+tAD2beMoT6Boc1wvCjfx4amgK 4cwhHWUjARbkUKVkuohS4ohCuKo+02MY9qw9e853aIPDFsZCpJEwxUscShR10zUe8l 35awdm48saiFg== From: MJ Ponsonby To: dev@openvswitch.org Cc: frode.nordhal@canonical.com, MJ Ponsonby Date: Mon, 25 Nov 2024 14:04:44 +0000 Message-ID: <20241125140444.483663-1-mj.ponsonby@canonical.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [ovs-dev] [PATCH ovn] Allow LR to send RAs with only link local Ipv6. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This fixes a bug in OVN that causes ovn-controller to fail when Logical Router Port configures send_periodic=true, but the Logical Router itself doesn't have any globally routable IPv6 networks. This is part of a larger effort to get BGP unnumbered working within OVN. Signed-off-by: MJ Ponsonby --- controller/pinctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index 3fb7e2fd7..b47387210 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c @@ -4171,7 +4171,8 @@ ipv6_ra_update_config(const struct sbrec_port_binding *pb) } const char *prefixes = smap_get(&pb->options, "ipv6_ra_prefixes"); - if (prefixes && !extract_ip_addresses(prefixes, &config->prefixes)) { + if (prefixes && (strcmp(prefixes,"")!=0) && + !extract_ip_addresses(prefixes, &config->prefixes)) { VLOG_WARN("Invalid IPv6 prefixes: %s", prefixes); goto fail; }