| Message ID | 20241118204826.1880713-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovn-detrace: Rephrase man page description. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Mon, Nov 18, 2024 at 9:48 PM Dumitru Ceara <dceara@redhat.com> wrote: > It had a few typos and it was slightly outdated. Nowadays ovn-detrace > displays more than just logical flow and ACL information. > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > utilities/ovn-detrace.1.in | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/utilities/ovn-detrace.1.in b/utilities/ovn-detrace.1.in > index a8d94c93de..c7b44869db 100644 > --- a/utilities/ovn-detrace.1.in > +++ b/utilities/ovn-detrace.1.in > @@ -13,9 +13,11 @@ OVN logical flow information. > . > .SH DESCRIPTION > The \fB\*(PN\fR program reads \fBovs\-appctl ofproto/trace\fR output on > -stdin, looking for flow cookies, and expand each cookie with > corresponding OVN > -logical flows. It expands logical flow further with the north-bound > information > -e.g. the ACL that generated the logical flow, when relevant. > +stdin, looking for flow cookies, and displays for each cookie the > +OVN south-bound records that contributed to its creation. It further > displays > +the related north-bound information when applicable, e.g., > +the ACL that generated the logical flow that gets translated to an > +OpenFlow rule with a given cookie. > .PP > . > .SH "OPTIONS" > -- > 2.46.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 12/10/24 07:07, Ales Musil wrote: > On Mon, Nov 18, 2024 at 9:48 PM Dumitru Ceara <dceara@redhat.com> wrote: > >> It had a few typos and it was slightly outdated. Nowadays ovn-detrace >> displays more than just logical flow and ACL information. >> >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >> --- >> utilities/ovn-detrace.1.in | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/utilities/ovn-detrace.1.in b/utilities/ovn-detrace.1.in >> index a8d94c93de..c7b44869db 100644 >> --- a/utilities/ovn-detrace.1.in >> +++ b/utilities/ovn-detrace.1.in >> @@ -13,9 +13,11 @@ OVN logical flow information. >> . >> .SH DESCRIPTION >> The \fB\*(PN\fR program reads \fBovs\-appctl ofproto/trace\fR output on >> -stdin, looking for flow cookies, and expand each cookie with >> corresponding OVN >> -logical flows. It expands logical flow further with the north-bound >> information >> -e.g. the ACL that generated the logical flow, when relevant. >> +stdin, looking for flow cookies, and displays for each cookie the >> +OVN south-bound records that contributed to its creation. It further >> displays >> +the related north-bound information when applicable, e.g., >> +the ACL that generated the logical flow that gets translated to an >> +OpenFlow rule with a given cookie. >> .PP >> . >> .SH "OPTIONS" >> -- >> 2.46.2 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Thanks Dumitru and Ales, I pushed this to main.
On 12/13/24 7:20 PM, Mark Michelson wrote: > > Thanks Dumitru and Ales, > > I pushed this to main. > Thanks!
diff --git a/utilities/ovn-detrace.1.in b/utilities/ovn-detrace.1.in index a8d94c93de..c7b44869db 100644 --- a/utilities/ovn-detrace.1.in +++ b/utilities/ovn-detrace.1.in @@ -13,9 +13,11 @@ OVN logical flow information. . .SH DESCRIPTION The \fB\*(PN\fR program reads \fBovs\-appctl ofproto/trace\fR output on -stdin, looking for flow cookies, and expand each cookie with corresponding OVN -logical flows. It expands logical flow further with the north-bound information -e.g. the ACL that generated the logical flow, when relevant. +stdin, looking for flow cookies, and displays for each cookie the +OVN south-bound records that contributed to its creation. It further displays +the related north-bound information when applicable, e.g., +the ACL that generated the logical flow that gets translated to an +OpenFlow rule with a given cookie. .PP . .SH "OPTIONS"
It had a few typos and it was slightly outdated. Nowadays ovn-detrace displays more than just logical flow and ACL information. Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- utilities/ovn-detrace.1.in | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)