| Message ID | 20250116075348.17-7-n.rottgardt@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Petr Štetiar |
| Headers | show
Return-Path:
<openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@legolas.ozlabs.org
Authentication-Results: legolas.ozlabs.org;
dkim=pass (2048-bit key;
secure) header.d=lists.infradead.org header.i=@lists.infradead.org
header.a=rsa-sha256 header.s=bombadil.20210309 header.b=i2WamE7A;
dkim-atps=neutral
Authentication-Results: legolas.ozlabs.org;
spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org
(client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;
envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org;
receiver=patchwork.ozlabs.org)
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)
(No client certificate requested)
by legolas.ozlabs.org (Postfix) with ESMTPS id 4YYZtN24t5z1ycn
for <incoming@patchwork.ozlabs.org>; Thu, 16 Jan 2025 18:55:55 +1100 (AEDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.infradead.org; s=bombadil.20210309; h=Sender:
Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:
List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:
Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:
Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
List-Owner; bh=nVNLQpILCuazXJz2zN9MmlTEUU9XkOXMZHSGmPBTsO8=; b=i2WamE7AAaYqe4
dHB4Yrh6u5iV8vFs2Kn7eVhzMRR+pH9eq2EUSsi+gYmhS4TFtl5EMmRy7B/iA/QSDdsWc/L4YINBQ
rNCcQthdjfy/vaNH5SqDwhzL0oJcP/yT6sZLlSGqm2Q2ApmGrEBVLT4OZc2+0iBULNhwPpJZRNqSl
XdT8GN5bIoA31toj6ArZrohvnq0Guz8MUM9ECX8Ad/4WOzjF66E0c0gb6K211lJgsD4bu9DyaGRyO
xbipkZN2KRCqDAfIaEAHTR4t0B6Y6KeMd/Mbvyf9fCoTXnT+XbYfV9964n9Afd9dz3tKWcsN5Kzlg
Jc4iAO2OJ30i3eG+GbFw==;
Received: from localhost ([::1] helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux))
id 1tYKi6-0000000E5eM-3jZY;
Thu, 16 Jan 2025 07:54:38 +0000
Received: from mail-smtp-out-01-pmx.wtnet.de ([84.46.103.117])
by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux))
id 1tYKhz-0000000E5Y0-3CAg
for openwrt-devel@lists.openwrt.org;
Thu, 16 Jan 2025 07:54:34 +0000
Received: from mail-cust-in-03-pmx.wtnet.de (mail-cust-in-03-pmx.wtnet.de
[84.46.103.103])
by mail-smtp-out-01-pmx.wtnet.de (8.15.2/8.15.2/Debian-15~mysql) with ESMTP
id 50G7sFJw009602;
Thu, 16 Jan 2025 08:54:15 +0100
X-WT-Originating-IP: 149.224.67.244
X-WT-Authenticated-As: ellerau@wtnet.de
Received: from viserver1.ham.lan
(149.224.67.244.dynamic-pppoe.dt.ipv4.wtnet.de [149.224.67.244])
(authenticated bits=0)
by mail-cust-in-03-pmx.wtnet.de (8.15.2/8.15.2/Debian-15~mysql) with ESMTPA
id 50G7sE3T029413;
Thu, 16 Jan 2025 08:54:14 +0100
Received: from Dell-7706.muc.lan (unknown [192.168.177.166])
by viserver1.ham.lan (Postfix) with ESMTP id B9E0961DB4;
Thu, 16 Jan 2025 08:54:14 +0100 (CET)
From: Nils Hendrik Rottgardt <n.rottgardt@gmail.com>
To: openwrt-devel@lists.openwrt.org
Cc: Nils Hendrik Rottgardt <n.rottgardt@gmail.com>, mail@david-bauer.net
Subject: [RESEND PATCH usteer v3 6/9] policy: Added error message if nodes has
no rrm number on bss transition
Date: Thu, 16 Jan 2025 08:53:45 +0100
Message-Id: <20250116075348.17-7-n.rottgardt@gmail.com>
X-Mailer: git-send-email 2.39.5
In-Reply-To: <20250116075348.17-1-n.rottgardt@gmail.com>
References: <20250116075348.17-1-n.rottgardt@gmail.com>
MIME-Version: 1.0
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
X-CRM114-CacheID: sfid-20250115_235432_143773_181C22EC
X-CRM114-Status: UNSURE ( 7.81 )
X-CRM114-Notice: Please train this message.
X-Spam-Score: -0.4 (/)
X-Spam-Report: Spam detection software,
running on the system "bombadil.infradead.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: - policy: Sometimes hostapd does not return an rrm nr which
breaks roaming with neighbors. This is shown as an error in the log.
Signed-off-by:
Nils Hendrik Rottgardt --- policy.c | 3 +++ 1 file changed,
3 insertions(+)
Content analysis details: (-0.4 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low
trust
[84.46.103.117 listed in list.dnswl.org]
0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is
CUSTOM_MED
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[84.46.103.117 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[84.46.103.117 listed in
sa-trusted.bondedsender.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail
domains are different
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider
[n.rottgardt(at)gmail.com]
0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom
freemail headers are different
0.9 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[84.46.103.117 listed in
bl.score.senderscore.com]
X-BeenThere: openwrt-devel@lists.openwrt.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org>
List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>,
<mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe>
List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/>
List-Post: <mailto:openwrt-devel@lists.openwrt.org>
List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help>
List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>,
<mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org>
Errors-To:
openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org
|
| Series |
Better handling of unfriendly STAs / IEEE enhancements / MBO
|
expand
|
diff --git a/policy.c b/policy.c index f3150e9..933c529 100644 --- a/policy.c +++ b/policy.c @@ -373,6 +373,9 @@ usteer_roam_trigger_sm(struct usteer_local_node *ln, struct sta_info *si) break; } + if (!candidate->node->rrm_nr) + MSG(FATAL, "Candiates node rrm nr not returned from hostapd. Neighbor list empty!"); + si->roam_transition_request_validity_end = current_time + 10000; validity_period = 10000 / usteer_local_node_get_beacon_interval(ln); /* ~ 10 seconds */ if (si->sta->aggressive) {
- policy: Sometimes hostapd does not return an rrm nr which breaks roaming with neighbors. This is shown as an error in the log. Signed-off-by: Nils Hendrik Rottgardt <n.rottgardt@gmail.com> --- policy.c | 3 +++ 1 file changed, 3 insertions(+)