| Message ID | 20240921210150.11352-1-foss@volatilesystems.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | realtek: add missing PHY handles for GS1900-10HP | expand |
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Stijn Segers <foss@volatilesystems.org> writes: > Fixes the following error in dmesg: > > [ 7.703678] rtl83xx-switch switch@1b000000: Port node 24 misses phy-handle > [ 7.711556] rtl83xx-switch switch@1b000000: Port node 26 misses phy-handle rtl83xx_mdio_probe() is weird. I guess the SoC phy polling makes that necessary. But it should accept sfp ports without phys, because that's what these are. There are pnly 8 internal phys in this switch. > @@ -59,6 +59,7 @@ > port@24 { > reg = <24>; > label = "lan9"; > + phy-handle = "<&phy24>"; > phy-mode = "1000base-x"; > managed = "in-band-status"; > sfp = <&sfp0>; This does not describe any hardware. It just works around a driver bug. Bjørn
Hi Bjorn, Op zondag 22 september 2024 om 18:29:50 +02:00:00 schreef Bjørn Mork <bjorn@mork.no>: > Stijn Segers <foss@volatilesystems.org> writes: > >> Fixes the following error in dmesg: >> >> [ 7.703678] rtl83xx-switch switch@1b000000: Port node 24 >> misses phy-handle >> [ 7.711556] rtl83xx-switch switch@1b000000: Port node 26 >> misses phy-handle > > rtl83xx_mdio_probe() is weird. I guess the SoC phy polling makes that > necessary. But it should accept sfp ports without phys, because that's > what these are. There are pnly 8 internal phys in this switch. > >> @@ -59,6 +59,7 @@ >> port@24 { >> reg = <24>; >> label = "lan9"; >> + phy-handle = "<&phy24>"; >> phy-mode = "1000base-x"; >> managed = "in-band-status"; >> sfp = <&sfp0>; > > This does not describe any hardware. It just works around a driver > bug. So what do you suggest? Leave it as-is? I can't recall seeing this error with 5.15. Stijn > > > Bjørn
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Stijn Segers <foss@volatilesystems.org> writes: > So what do you suggest? Leave it as-is? Either that or remove the bogus error message from the driver. This is not an error. If any cleanup should be done in the GS1900-10HP dts, then removing those two bogus internal phys would be the correct thing to do. > I can't recall seeing this > error with 5.15. It was there for me: [ 0.000000] Linux version 5.15.158 (bjorn@canardo) (mips-openwrt-linux-musl-gcc (OpenWrt GCC 13.2.0 r26302-4f87a4d84f3d) 13.2.0, GNU ld (GNU Binutils) 2.42) #0 Mon May 13 08:15:17 2024 [ 0.000000] RTL838X model is 83806800 [ 0.000000] SoC Type: RTL8380 [ 0.000000] printk: bootconsole [early0] enabled [ 0.000000] CPU0 revision is: 00019070 (MIPS 4KEc) [ 0.000000] MIPS: machine is ZyXEL GS1900-10HP Switch [ 0.000000] earlycon: ns16550a0 at MMIO 0x18002000 (options '115200n8') [ 0.000000] printk: bootconsole [ns16550a0] enabled ... [ 3.885337] Realtek RTL8218B (internal) rtl838x slave mii-0:08: Detected internal RTL8218B [ 3.894752] Firmware loaded. Size 1184, magic: 83808380 [ 4.199898] sfp sfp-p9: module OEM GLC-T rev B sn M0312A804 dc 130823 [ 4.310319] sfp sfp-p10: module Tsuhan THMPRS-3511-10A rev A sn F19021506991 dc 190409 [ 6.713738] Realtek RTL8380 SERDES rtl838x slave mii-0:18: Detected internal RTL8380 SERDES [ 6.723249] Firmware loaded. Size 1184, magic: 83808380 [ 6.729162] SDS power down value: 3 [ 6.757270] PLL control register: f [ 6.761319] SDS power down value now: 3f [ 6.765729] Configuration of SERDES done [ 6.797530] rtl83xx-switch switch@1b000000: Port node 24 misses phy-handle [ 6.805417] rtl83xx-switch switch@1b000000: Port node 26 misses phy-handle [ 6.817852] In rtl83xx_vlan_setup Bjørn
diff --git a/target/linux/realtek/dts/rtl8380_zyxel_gs1900-10hp.dts b/target/linux/realtek/dts/rtl8380_zyxel_gs1900-10hp.dts index 190a77b7ff..f8125fec86 100644 --- a/target/linux/realtek/dts/rtl8380_zyxel_gs1900-10hp.dts +++ b/target/linux/realtek/dts/rtl8380_zyxel_gs1900-10hp.dts @@ -59,6 +59,7 @@ port@24 { reg = <24>; label = "lan9"; + phy-handle = "<&phy24>"; phy-mode = "1000base-x"; managed = "in-band-status"; sfp = <&sfp0>; @@ -67,6 +68,7 @@ port@26 { reg = <26>; label = "lan10"; + phy-handle = "<&phy26>"; phy-mode = "1000base-x"; managed = "in-band-status"; sfp = <&sfp1>;
Fixes the following error in dmesg: [ 7.703678] rtl83xx-switch switch@1b000000: Port node 24 misses phy-handle [ 7.711556] rtl83xx-switch switch@1b000000: Port node 26 misses phy-handle Signed-off-by: Stijn Segers <foss@volatilesystems.org> --- target/linux/realtek/dts/rtl8380_zyxel_gs1900-10hp.dts | 2 ++ 1 file changed, 2 insertions(+)