mbox series

[0/2] Fix the installation of linux kernel module packages from a feed

Message ID mailman.115094.1726741692.1280.openwrt-devel@lists.openwrt.org
Headers show
Series Fix the installation of linux kernel module packages from a feed | expand

Message

Thomas Richard Sept. 19, 2024, 10:27 a.m. UTC 
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
I found an issue with linux kernel module packages, when the target is
installed from a feed.

When you install a target (./scripts/feeds install <target>), the linux
kernel package is scanned (automatically done by the script) before the
installation of the target.
The linux kernel package automatically includes module packages defined in
target directories [1]. To find available targets it searches directories
in target/linux/ and target/linux/feeds [2].
But when it is scanned, the target doesn't exist yet, so the module.mk
defined in the target directory is not parsed, consequently the packages
don't exist.

To fix this issue, I delete the packageinfo file of the linux kernel
package once the target is installed (patch 2/2) to force the scan.
So next time the feeds script or the make command is called, the linux
kernel package will be scanned.

This issue cannot be reproduced after a distclean. The distclean does't
delete target/linux/feeds directory. So the target symlinks are still
present (but broken).
So once you fetch the feeds (./scripts/feeds update), the target is 
"automatically installed" as the symlink was not removed.
So when the linux kernel is scanned (during the installation of the
target) the modules.mk makefile of the target is parsed, as the target is
in fact already installed.

The patch 1/2 adds the delete of target/linux/feeds in distclean, so the
environment is really in its initial state.

[1] https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/linux/Makefile;h=8dfb01ad66118a70be28f5c7019dd8c1c757de52;hb=HEAD#l76
[2] https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/linux/Makefile;h=8dfb01ad66118a70be28f5c7019dd8c1c757de52;hb=HEAD#l15

Thomas Richard (2):
  toplevel.mk: add target feeds in 'make distclean'
  scripts/feeds: force kernel package scan after a target installation

 include/toplevel.mk | 2 +-
 scripts/feeds       | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)