From patchwork Mon Sep 23 11:56:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1988565 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nUBvWNUe; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=CbFe8yoT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XC1h60qg0z1xsr for ; Mon, 23 Sep 2024 21:57:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hSN+t6opfC8GUZfpgmbmGzqQHhyi4Jv4gjJzqslRLJU=; b=nUBvWNUeZFVM6H 3b6mgtnqVeZ7d6Lyqw6tw3PBDg9pAHZtNgwltmMrmWjFpxKA+AaYLZfXNNHOJDFPYQFdjYscymVEG iNASpzCwo7FWptH/BmUq8qDNfaNY1d0iN5ktNOX8k5vGRlhshSITD28fx0EvqW3h9smg60ocf4pAc 5R8Yx52iumYhS7I8OTN3gYKugT2zaYeA67FNkOT5s6BvxniF/4gZNzN8zUxcwqaafZaBMjhqBA9CL VwsLVS06CgciBpgEmdAX8NSXYavk0cHUTM0VSXSA32p6bnyLeH5KUM1fz4rSt4ynDRQnvi1HQYz41 W/2ocSeqBHZzOXWj1rMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sshgt-0000000H7FQ-3KK4; Mon, 23 Sep 2024 11:57:19 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sshgq-0000000H7EY-31Jl for opensbi@lists.infradead.org; Mon, 23 Sep 2024 11:57:18 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2d87196ec9fso2846295a91.1 for ; Mon, 23 Sep 2024 04:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1727092636; x=1727697436; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2V8SI8napeAt4zo4n8cDwTvhKpc1oiimJnBN0hknaXc=; b=CbFe8yoTWEg7WU2T4CGecaHl/ZaCFDEa/vV2fC0A1CBy+hVbKXsSp0ZvJ4t2F3Dmxo zoG+0CoAOoYuiLDBuBypaVBjwd/EobAN6oOI4urnettQ50HfhYFGydjwKrst1cy4Cyp6 1/g4lrjAVGqZIbP6kK3plrMdjlP2RMqdP5a5+YlYRnipIGP3i7ap+Z6LSycEXf6wHLJi yE+X1dcGjpUIvEIGmoN4hF7Wv14+HKGoXASVZvbXF2tra0p+bvU2djScrM3LEor98QLW N7sk9d7w6zbH6pNdcBYmsoZIrEU3/gm5Z8Kms+wa6uQIBwkWS2YGpkRoxPWecjn/WjlT f/AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727092636; x=1727697436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2V8SI8napeAt4zo4n8cDwTvhKpc1oiimJnBN0hknaXc=; b=OJ7GQ6UhaljRJM474b0e2C30TkWb/LB5zKVWpMCU0P4USV8fddUYle44J1X/NUja5S yUyZv6LzA7vvXJxk/xMNsDmfoDF40SwhMy9npmWf8plnosYUmZeBXzOz5cZ48dYhJExL SmMXwmA2Pm4Wri47O18Mr1wJlcG5YWvINPoHFn0CaJSvbEY5D+6rAA62TZTHygaHE2M4 +aY/15kJR7WftouTcR78ANdMJGW4RY9yYtBwej0LdBvH+xMAVCTcwHajgchasf48nW/t qeGzVg7wAJJmuwNF5CH9rae+xveFCWIEN+362aAQGORvIUOxLHxMDWahjOyfp3UhWAwR XjmA== X-Forwarded-Encrypted: i=1; AJvYcCUlNAnfzOrGiTIMOhaCdZgZBqq5MzOvadJUGqZiweTXYvP++JrSrvxSsjN3tSVETESJwxD3CKsP@lists.infradead.org X-Gm-Message-State: AOJu0YyqoGdnL6vJNOSeWnZ4m384RvQRXfFjKvxHoVCVDaC6PvNhtyeC y1ErH8ALNpKwCtRYVZgcJVAy+ntnvmaiSxE0zDYKDEWzununxSdt20aebzVEFl8= X-Google-Smtp-Source: AGHT+IEwWp1/7xaVZtt2OmsM5fKdjx5Zs9eiEpd3XeJWQw+vhr8LQkbrZnVrzUPKg0Pb6xlTs3SXTg== X-Received: by 2002:a17:90b:890:b0:2de:ecb9:93cd with SMTP id 98e67ed59e1d1-2deecb9950fmr5718330a91.12.1727092636114; Mon, 23 Sep 2024 04:57:16 -0700 (PDT) Received: from anup-ubuntu-vm.localdomain ([103.97.165.210]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd6ef361b0sm9252106a91.44.2024.09.23.04.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 04:57:15 -0700 (PDT) From: Anup Patel To: Atish Patra Cc: Andrew Jones , Anup Patel , opensbi@lists.infradead.org, Anup Patel Subject: [PATCH 2/9] lib: utils/irqchip: Use sbi_domain_root_add_memrange() for IMSIC Date: Mon, 23 Sep 2024 17:26:53 +0530 Message-ID: <20240923115700.381916-3-apatel@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240923115700.381916-1-apatel@ventanamicro.com> References: <20240923115700.381916-1-apatel@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240923_045716_783850_FA1F41CF X-CRM114-Status: GOOD ( 10.27 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The sbi_domain_root_add_memrange() should be preferred for creating multiple memregions over a range. Update IMSIC driver to use sbi_domain_root_add_memrange() instead of explicity registering memregi [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1032 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_domain_root_add_memrange() should be preferred for creating multiple memregions over a range. Update IMSIC driver to use sbi_domain_root_add_memrange() instead of explicity registering memregions. Signed-off-by: Anup Patel --- lib/utils/irqchip/imsic.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/utils/irqchip/imsic.c b/lib/utils/irqchip/imsic.c index bac72d21..ddb372fb 100644 --- a/lib/utils/irqchip/imsic.c +++ b/lib/utils/irqchip/imsic.c @@ -348,7 +348,6 @@ int imsic_data_check(struct imsic_data *imsic) int imsic_cold_irqchip_init(struct imsic_data *imsic) { int i, rc; - struct sbi_domain_memregion reg; /* Sanity checks */ rc = imsic_data_check(imsic); @@ -378,13 +377,12 @@ int imsic_cold_irqchip_init(struct imsic_data *imsic) /* Add IMSIC regions to the root domain */ for (i = 0; i < IMSIC_MAX_REGS && imsic->regs[i].size; i++) { - sbi_domain_memregion_init(imsic->regs[i].addr, - imsic->regs[i].size, - (SBI_DOMAIN_MEMREGION_MMIO | - SBI_DOMAIN_MEMREGION_M_READABLE | - SBI_DOMAIN_MEMREGION_M_WRITABLE), - ®); - rc = sbi_domain_root_add_memregion(®); + rc = sbi_domain_root_add_memrange(imsic->regs[i].addr, + imsic->regs[i].size, + IMSIC_MMIO_PAGE_SZ, + SBI_DOMAIN_MEMREGION_MMIO | + SBI_DOMAIN_MEMREGION_M_READABLE | + SBI_DOMAIN_MEMREGION_M_WRITABLE); if (rc) return rc; }