diff mbox

[2/2] fix writing of ICCID for sysmo-usim-sjs1

Message ID 1490270837-28823-3-git-send-email-pmaier@sysmocom.de
State New
Headers show

Commit Message

Philipp Maier March 23, 2017, 12:07 p.m. UTC 
The programming procedure for sysmo-usim-sjs1 lacks
writing the ICCID. This commit adds the missing call
to update_binary()
---
 pySim/cards.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
diff mbox

Patch

diff --git a/pySim/cards.py b/pySim/cards.py
index fafc55f..925c5e6 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -434,20 +434,20 @@  class SysmoUSIMSJS1(Card):
 
 	def program(self, p):
 
+		# authenticate as ADM using default key (written on the card..)
+		if not p['pin_adm']:
+			raise ValueError("Please provide a PIN-ADM as there is no default one")
+		self._scc.verify_chv(0x0A, h2b(p['pin_adm']))
 
 		# select MF
 		r = self._scc.select_file(['3f00'])
 
+		# write EF.ICCID
+		data, sw = self._scc.update_binary('2fe2', enc_iccid(p['iccid']))
+
 		# select DF_GSM
 		r = self._scc.select_file(['7f20'])
 
-		# authenticate as ADM using default key (written on the card..)
-		if not p['pin_adm']:
-			raise ValueError("Please provide a PIN-ADM as there is no default one")
-
-		self._scc.verify_chv(0x0A, h2b(p['pin_adm']))
-
-
 		# set Ki in proprietary file
 		data, sw = self._scc.update_binary('00FF', p['ki'])