| Message ID | 3c7d455745c2265c19ed02f026dfc9610271d3c2.1725692376.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | New |
| Headers | show |
| Series | peci: npcm: Constify struct peci_controller_ops | expand |
On Sat, 2024-09-07 at 09:00 +0200, Christophe JAILLET wrote: > 'struct peci_controller_ops' is not modified in this driver. > > Constifying this structure moves some data to a read-only section, so > increase overall security, especially when the structure holds some > function pointers. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec > hex filename > 8003 784 48 8835 > 2283 drivers/peci/controller/peci-npcm.o > > After: > ===== > text data bss dec > hex filename > 8003 776 48 8827 > 227b drivers/peci/controller/peci-npcm.o > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com> Thanks -Iwona > --- > Compile tested only > --- > drivers/peci/controller/peci-npcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/peci/controller/peci-npcm.c > b/drivers/peci/controller/peci-npcm.c > index ec613d35c796..fa91be58f6f3 100644 > --- a/drivers/peci/controller/peci-npcm.c > +++ b/drivers/peci/controller/peci-npcm.c > @@ -224,7 +224,7 @@ static const struct regmap_config npcm_peci_regmap_config > = { > .fast_io = true, > }; > > -static struct peci_controller_ops npcm_ops = { > +static const struct peci_controller_ops npcm_ops = { > .xfer = npcm_peci_xfer, > }; >
diff --git a/drivers/peci/controller/peci-npcm.c b/drivers/peci/controller/peci-npcm.c index ec613d35c796..fa91be58f6f3 100644 --- a/drivers/peci/controller/peci-npcm.c +++ b/drivers/peci/controller/peci-npcm.c @@ -224,7 +224,7 @@ static const struct regmap_config npcm_peci_regmap_config = { .fast_io = true, }; -static struct peci_controller_ops npcm_ops = { +static const struct peci_controller_ops npcm_ops = { .xfer = npcm_peci_xfer, };
'struct peci_controller_ops' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 8003 784 48 8835 2283 drivers/peci/controller/peci-npcm.o After: ===== text data bss dec hex filename 8003 776 48 8827 227b drivers/peci/controller/peci-npcm.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only --- drivers/peci/controller/peci-npcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)